[Libreoffice-commits] core.git: cppu/source

cppu/source/typelib/typelib.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 6317f8cc83ec92b8700785ab67c4c66ed1aa8fb2 Author: Christophe JAILLET AuthorDate: Fri Jun 18 00:00:40 2021 +0200 Commit: Stephan Bergmann CommitDate: Fri Jun 18 11:03:47 2021 +0200 Re-add

[Libreoffice-commits] core.git: cui/source

cui/source/dialogs/QrCodeGenDialog.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 407f6c757af01ea71eb8a86b41c27d12573f51e6 Author: Christophe JAILLET AuthorDate: Sun Mar 21 09:32:05 2021 +0100 Commit: Mike Kaganski CommitDate: Sun Mar 21 12:43:23 2021

[Libreoffice-commits] core.git: sfx2/source

sfx2/source/control/thumbnailview.cxx |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) New commits: commit 9378be4825e63a3eed740403281246de26e7006d Author: Christophe JAILLET AuthorDate: Tue Nov 10 08:01:29 2020 +0100 Commit: Noel Grandin CommitDate: Tue Nov 10 09:26

[Libreoffice-commits] core.git: cui/source

cui/source/dialogs/tipofthedaydlg.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 0615f3bc125d2d02d11d336e1d0b1c204c91f432 Author: Christophe JAILLET AuthorDate: Tue Aug 20 21:21:44 2019 +0200 Commit: Heiko Tietze CommitDate: Mon Oct 28 08:33:55

[Libreoffice-commits] core.git: cui/inc cui/source

cui/inc/tipoftheday.hrc | 82 +- cui/source/dialogs/tipofthedaydlg.cxx |2 2 files changed, 42 insertions(+), 42 deletions(-) New commits: commit 0ed7f9dab2ec03e168f2013e57c21637f7700736 Author: Christophe JAILLET AuthorDate: Fri Jul 19

[Libreoffice-commits] core.git: sfx2/source

sfx2/source/dialog/filtergrouping.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit c816d9daff3bc7e90d9d3523c5756434bfa01414 Author: Christophe JAILLET AuthorDate: Sun Jul 14 10:48:31 2019 +0200 Commit: Noel Grandin CommitDate: Sun Jul 14 20:44:23 2019

[Libreoffice-commits] core.git: sfx2/source

sfx2/source/control/thumbnailview.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 4a45d35aa2b921183ad5633af8b8725b6c5ffe8f Author: Christophe JAILLET AuthorDate: Wed Jul 10 22:52:44 2019 +0200 Commit: Noel Grandin CommitDate: Thu Jul 11 09:30:32

[Libreoffice-commits] core.git: sfx2/source

sfx2/source/control/thumbnailview.cxx | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) New commits: commit fc4245e6d69829fb5acd335a01005f666c9dd21f Author: Christophe JAILLET AuthorDate: Wed Jul 10 22:31:46 2019 +0200 Commit: Noel Grandin CommitDate: Thu Jul 11

[Libreoffice-commits] core.git: Changes to 'refs/changes/00/300/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/91/291/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/89/289/2'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/89/289/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/72/372/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/72/372/2'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/69/269/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/10/310/2'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/08/308/3'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/08/308/2'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/08/308/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/10/310/1'

___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Simplify and speed-up logic for copying data

: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cppCheck: Variable is reassigned a value before the old one ...

://gerrit.libreoffice.org/2014 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I42cfb06dd8b6b0ff7d4fec6e3b296fa61302c1c0 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr

[PATCH] Remove useless function calls.

://gerrit.libreoffice.org/2015 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad739d6fffd2c40cc633789edfe88d13e87dd28b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr

[PATCH] Remove useless comment.

: Ica37d08671700adea3b0d48c1d72b6d26f56dcfb Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

[PATCH] cppCheck: remove dead assignment and dead variables

://gerrit.libreoffice.org/1153 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f0eae93be7f362ff70f8a544c46cd500d2ca50c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr

[PATCH] cppCheck: Possible NULL pointer dereference

: I1d740eea5c26e0515835c4dc6199a387b6fa8f6b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: how to change submitted (but not pushed) patches in gerrit when necessary?

Le 23/11/2012 08:06, Winfried Donkers a écrit : Hi all, I submitted a patch to gerrit with logerrit. The reviewer had some comments which need alteration of the patch. But how to 'resubmit' this changed patch once that is ready? All I can find on this area is to use git push […], but I

cppCheck: invalidPrintfArgType + minor formatting when appro...

Christophe JAILLET has abandoned this change. Change subject: cppCheck: invalidPrintfArgType + minor formatting when appropriate .. Patch Set 1: Abandoned Will provide separate patches in the future. -- To view, visit https

[PATCH] cppCheck: clarifyCondition

Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cppCheck: invalidPrintfArgType + minor formatting when appro...

Gerrit-Change-Id: Ibe8b8dd2682fad2cb7bc5cd986a1fe0eeb19db5f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] Turn some memmove into memcpy when it is safe to do so.

To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6ccf1bbb07b792fb18601a38dfaa55755d14b7d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr

[PATCH] cppCheck: redundant assignment and Possible null pointer der...

Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] s/aIter++/++aIter/

: Id80013cbab8f1633db59d2d4492c7363224871bd Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[PATCH] cppCheck: remove dead assignment

: Iea8388c16de3399853dc384e7df6bfcc92170ea2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

[PATCH] cppCheck: remove dead assignment + a little formatting

-Id: I78f7f7ae7373e00e0750abc4566c71a8b9c1640a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] Cut and paste typo ?

/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ed63439e47a89cc982d792c619c4c58335daf93 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list

[PATCH] cppCheck: Unused variable and Redundant assignment

To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I67084c1cb9dc23eb77787d2a6d57a5b70126873c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr

[PATCH] cppCheck: Various clean-up

Gerrit-MessageType: newchange Gerrit-Change-Id: I5016c12527a8811676ff10f07f7be9e855c66814 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice

[PATCH] cppCheck: Various clean-up

: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cppCheck: Possible inefficient checking for emptiness

/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ief04fa81abbba9e66353c57eb586f864c37deed0 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list

[PATCH] cppCheck: Remove some 'redundantAssignment'

-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cppCheck: unusedStructMember

://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06a901a5442cacf0f7fa2b0c775fc89709968601 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing

[PATCH] cppCheck: avoid obvious 'redundantAssignment'

Gerrit-Change-Id: Ib819c1664dc1643b0d8bf9f516fc0b328f201bff Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] cppcheck: unreadVariable

: I2878d2db002411783e814b0ecf02e2a030d2d6d4 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

[PATCH] cppcheck: clarifyCalculation

-MessageType: newchange Gerrit-Change-Id: I3dfa6566758d30bd76bed478089a0937ade24f89 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice

[PATCH] cppcheck : redundantCondition. In this case, it seems to be ...

: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cppcheck: unreadVariable.

Gerrit-Change-Id: I8f5184c58fbe812beab8580349535920645e062e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] cppcheck: Unused variable

: I872cf178a803c3210898f7f317211a8d3a2d368e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christophe JAILLET christophe.jail...@wanadoo.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Question about OUString::compareToAscii

is better because: - shorter - more meaningful - doing some ! on sal_Int32 is not as clean as using sal_Bool directly Do you think that such a clean-up is interesting ? Best regards, Christophe Jaillet ___ LibreOffice mailing list

Re: Question about OUString::compareToAscii

Le 13/07/2012 22:59, Christophe JAILLET a écrit : Hi, according to my understanding, OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM(A string)) gives exactly the same result as OUString::compareToAscii(A string) However, the first one: - is harder to read - uses the deprecated

Re: Question about OUString::compareToAscii

Le 13/07/2012 23:17, Lubos Lunak a écrit : according to my understanding, OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM(A string)) gives compareAsciiL - the L means it gets the string length from the macro I was speaking about compareToAscii, without the L. compareAsciiL does not seem

Re: Improve doc about gerrit/setup

for a 5.3 Ko patch ??? Thanks in advance for your help. Best regards, Christophe JAILLET From c203061eb60794cfdba03dc0faa6d8b5afc5879f Mon Sep 17 00:00:00 2001 From: Christophe JAILLET christophe.jail...@wanadoo.fr Date: Mon, 9 Jul 2012 23:40:03 +0200 Subject: [PATCH] Use rtl_zeroMemory in place

OUString::indexOf with 1 char string parameter

Hi, before submitting patches on gerrit, I would like to have your feed back to make sure I'm right. 'OUString' have 'indexOf' that can find a substring (literal or OUString) or a char. IMO, looking for a 1 char long string is the same as looking for this char itself. However, the later is

Improve doc about gerrit/setup

figuring which username I had to provide Knowing that I manage to get $ ./logerrit test Your gerrit setup was succesfull! :) Best regards Christophe JAILLET ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Question about calling a method with a default parameter

Hacks for Beginners Best regards Christophe JAILLET ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] - Report correct test name

Hi, In '\sal\qa\rtl_strings\rtl_OUString.cxx', I think that this one should be 'ctor_005' and not 'ctor_004'. Best regards Christophe JAILLET diff --git a/sal/qa/rtl_strings/rtl_OUString.cxx b/sal/qa/rtl_strings/rtl_OUString.cxx index 8271253..64b9aa1 100644 --- a/sal/qa/rtl_strings

[PATCH] - use indexOfAsciiL and avoid static variable

, I've not checked for the includes for 'strlen'. Best regards, Christophe JAILLET diff --git a/comphelper/source/misc/logging.cxx b/comphelper/source/misc/logging.cxx index 19f7f42..9d830e1 100644 --- a/comphelper/source/misc/logging.cxx +++ b/comphelper/source/misc/logging.cxx @@ -131,14 +131,14

Duplication of some includes due to last commit

Looking at the last commit : http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec5fa0164b9bae5c5bc6654f581e493206584301 we can see that replacing .hdl include with equivalent .hpp includes leads to duplication of some includes. For example in filter/source/svg/svgfilter.cxx

Re: Duplication of some includes due to last commit

Le 21/06/2012 22:52, Michael Stahl a écrit : On 21/06/12 22:44, Christophe JAILLET wrote: Looking at the last commit : http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec5fa0164b9bae5c5bc6654f581e493206584301 we can see that replacing .hdl include with equivalent .hpp includes leads

[PATCH] - avoid some memset

Hi, this patch removes some useless memset(..., 0, ...) of memory that has been calloc'ated It also improves a bit some formating, (type*) -- (type *) It is against : vcl/source/fontsubset/sft.cxx Best regards Christophe JAILLET From b81145830995f9808be3ebed3f451cd6befd73db Mon Sep 17

[PATCH] - avoid some memset

Hi, in a previous commit, the only memset in the file has been removed, so it should be safe to remove this include. See http://cgit.freedesktop.org/libreoffice/core/commit/?id=441b28d4e9d0345f91fed6a2345d4d6a7c7eb5f7 Best regards, Christophe JAILLET From

Re: [PUSHED] - avoid a memset

regards, Christophe JAILLET Le 14/06/2012 12:34, Michael Meeks a écrit : Hi Christophe, On Tue, 2012-06-12 at 22:53 +0200, Marion Christophe JAILLET wrote: first try to send a patch for libreoffice, First - sorry for the delay reviewing this :-) This one, is to avoid a call to memset

[PATCH] - avoid a memset

Christophe JAILLET http://lists.freedesktop.org/mailman/listinfo/libreoffice diff --git a/i18npool/source/breakiterator/breakiterator_ctl.cxx b/i18npool/source/breakiterator/breakiterator_ctl.cxx index 70a3124..5d1d7a1 100644 --- a/i18npool/source/breakiterator/breakiterator_ctl.cxx +++ b/i18npool/source