Re: [PUSHED] [PATCH] Object Catalog in Dialog Editor

2012-08-21 Thread János Uray
the Layout class has some virtual methods with no implementation, this sounds like these need to be pure virtual making Layout an abstract class ( which makes sense ) When I looked a little close at some of those methods I notice IMO, not all empty virtual functions need to be pure virtual.

Re: [PATCH] [PUSHED] IDE: PTR_CAST, ISA - dynamic_cast

2012-08-07 Thread János Uray
Sorry, but I forgot to compile before patching. Please, push this fix too. Uray M. János 2012/8/7 Tor Lillqvist t...@iki.fi Thanks, puxhed. --tml From aef47b5e204067ae406eca664a504155cc699ef8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uray=20M.=20J=C3=A1nos?= uray.ja...@gmail.com Date: Tue, 7

Re: [PATCH] [PUSHED] IDE: PTR_CAST, ISA - dynamic_cast

2012-08-07 Thread János Uray
http://wiki.services.openoffice.org/wiki/Writer/Code_Conventions#Vetoed_Conventionssays that C++ RTTI is preferred over tools/rtti.hxx. In my opinion, the best would be not using casts at all (using e.g. virtual functions instead). Uray M. János 2012/8/7 Caolán McNamara caol...@redhat.com On

Re: [PATCH] Cleanup in Tools - Options - User Data

2012-08-03 Thread János Uray
For me, it doesn't crash, so I've no idea how to fix it. I don't understand this DELETEZ thing... DELETEZ deletes than zeros a pointer. This is now done automatically by boost::shared_ptr::~shared_ptr(). Uray M. János Nice work! :) I wanted to push this, but it seems it causes a crash here when

[PATCH] fdo#42492: fixing Basic HEX command

2012-07-31 Thread János Uray
The patch solves this bug: https://bugs.freedesktop.org/show_bug.cgi?id=42492 There was a buffer overflow: char aBuffer[16] had no room for the terminating null character. But the hex command was still wrong, because the printf used %X and %lX, which are very platform-dependent. Actually the

Re: fdo#47907: fix flickering scrolling in Basic IDE

2012-07-31 Thread János Uray
Again? Oh, yes. Now here it is. On Tue, Jul 31, 2012 at 11:10 AM, Noel Power nopo...@suse.com wrote: Hi János you forgot to attach the patch :-) On 30/07/12 19:04, János Uray wrote: This patch solves this bug: https://bugs.freedesktop.org/show_bug.cgi?id=47907 The text was flickering

Re: [PATCH] fdo#42492: fixing Basic HEX command

2012-07-31 Thread János Uray
://msdn.microsoft.com/en-US/library/47zceaw7%28v=vs.110%29 Uray M. János On Tue, Jul 31, 2012 at 11:08 AM, Noel Power nopo...@suse.com wrote: On 31/07/12 07:13, János Uray wrote: The patch solves this bug: https://bugs.freedesktop.org/** show_bug.cgi?id=42492https://bugs.freedesktop.org/show_bug.cgi?id

Re: [PATCH] fdo#42492: fixing Basic HEX command

2012-07-31 Thread János Uray
I also like to avoid C-style string handling, but valueOf() doesn't support unsigned integers (it should support all C++ integer types), and converting to sal_Int64 didn't come into my mind. Why did you extend the comment: // converting value to unsigned *and limit to 2 or 4 byte representation*?

[PATCH] fdo#46968: fixing undo of textbox resizing

2012-07-30 Thread János Uray
This patch indends to solve this bug: http://bugs.freedesktop.org/show_bug.cgi?id=46968 The undo just assigned to SdrTextObj::aRect its previous value. Now it calls NbcSetLogicRect() for this task. This function calls -- among others -- NbcSetMinTextFrameHeight(), which is neccessary to avoid

fdo#47907: fix flickering scrolling in Basic IDE

2012-07-30 Thread János Uray
This patch solves this bug: https://bugs.freedesktop.org/show_bug.cgi?id=47907 The text was flickering because Window::Invalidate() clears the client area by default. To prevent this, I've added an INVALIDATE_NOERASE parameter to Invalidate() calls. On the other hand, the background still needed

[PATCH] fdo#40152: replace with empty string in Basic IDE

2012-07-25 Thread János Uray
This patch solves https://bugs.freedesktop.org/show_bug.cgi?id=40152 . Uray M. János From d10f4ddea22d332fee1a642d076bbce25ac4b10a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uray=20M.=20J=C3=A1nos?= uray.ja...@gmail.com Date: Wed, 25 Jul 2012 09:42:12 +0200 Subject: [PATCH] fdo#40152 replace with

Re: [PATCH] fdo#40152: replace with empty string in Basic IDE

2012-07-25 Thread János Uray
It still works for me. Am I doing something wrong? On Wed, Jul 25, 2012 at 11:36 AM, Noel Power nopo...@suse.com wrote: On 25/07/12 08:48, János Uray wrote: This patch solves https://bugs.freedesktop.org/**show_bug.cgi?id=40152https://bugs.freedesktop.org/show_bug.cgi?id=40152. weirdly

[PATCH] fixed Replace all message in Basic IDE

2012-07-25 Thread János Uray
In Basic IDE, Replace all said Search key replaced times, so without the number. This patch fixes it. (The nFound was treated as a character instead of an integer.) Uray M. János From e6266f1374ccb193314dcb8ac882897b2b5150a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uray=20M.=20J=C3=A1nos?=

[PATCH] fdo#50632 IDE: update Object Catalog when closing a document

2012-07-25 Thread János Uray
This patch fixed this bug: https://bugs.freedesktop.org/show_bug.cgi?id=50632 The Object Catalog was not updated, because at the point when onDocumentClosed() event was generated in BasicTreeListBox, the to-be-closed document is still alive, so UpdateEntries() doesn't remove the entry. I removed

[PATCH] fdo#50633 IDE: select current module in Object Catalog on open

2012-07-24 Thread János Uray
This patch solves this bug: https://bugs.freedesktop.org/show_bug.cgi?id=50633 Uray M. János ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] fdo#50633 IDE: select current module in Object Catalog on open

2012-07-24 Thread János Uray
Oh, yes, I'm sorry. On Tue, Jul 24, 2012 at 11:33 AM, Noel Grandin n...@peralex.com wrote: I think you forgot to attach it. On 2012-07-24 11:31, János Uray wrote: This patch solves this bug: https://bugs.freedesktop.org/show_bug.cgi?id=50633 Uray M. János

Re: [PATCH] fdo#50633 IDE: select current module in Object Catalog on open

2012-07-24 Thread János Uray
Oh, yes, I'm sorry. On Tue, Jul 24, 2012 at 11:35 AM, Korrawit Pruegsanusak detective.conan.1...@gmail.com wrote: Hello, On Tue, Jul 24, 2012 at 4:31 PM, János Uray uray.ja...@gmail.com wrote: This patch solves this bug: Seems you forgot to attach the patch? :-) Bets Regards

[PATCH] fdo#52223: fix Object Catalog in Basic IDE when resizing

2012-07-23 Thread János Uray
This patch fixes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=52223 From ef69583b67ff9f34e615b3595984090515dec501 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uray=20M.=20J=C3=A1nos?= uray.ja...@gmail.com Date: Mon, 23 Jul 2012 18:48:47 +0200 Subject: [PATCH] fdo#52223 fix Object Catalog in

Re: C++11 in LibreOffice

2012-07-17 Thread János Uray
Thank you again. Unfortunately gcc starts to support C++11 only in 4.3, and MSVC has very little C++11 in 2008 (2010 has much more). Uray M. János On Mon, Jul 16, 2012 at 6:53 PM, Kohei Yoshida kohei.yosh...@gmail.comwrote: On Mon, Jul 16, 2012 at 12:35 PM, János Uray uray.ja...@gmail.com

License statement

2012-07-16 Thread János Uray
License statement All my current and past contributions made to the LibreOffice project are done under MPL1.1+ / GPLv3+ / LGPLv3+. Until further notice, all my future contributions to the LibreOffice project are available under MPL1.1+ / GPLv3+ / LGPLv3+. Uray M. János

C++11 in LibreOffice

2012-07-16 Thread János Uray
I have a simple question. Can I use C++11 in LibreOffice development? Or at least some parts of C++11? Thanks Uray M. János ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice