[PATCH] Cleaning: remove use of old edt1 from dlg.h (Windows)

2013-06-14 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4283 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/4283/1 Cleaning: remove use of old edt1 from dlg.h (Windows) edt1 was used before cmb13 (used from Win2K version) So us

[PATCH] cppcheck: fix operatorEqVarError (in lotuswordpro)

2013-06-13 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4281 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/4281/1 cppcheck: fix operatorEqVarError (in lotuswordpro) Change-Id: I0fb3d99326ec3cb930b85626c749613f65ee8b6e --- M lo

[PATCH] cppcheck: fix duplicateExpression

2013-06-13 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4279 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/4279/1 cppcheck: fix duplicateExpression (It seemed logical to me, hope I'm not wrong) Change-Id: I2c1ffbe69b90655b260

[PATCH] cppcheck: fix duplicateExpression

2013-06-13 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4278 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/4278/1 cppcheck: fix duplicateExpression Change-Id: If3b7b1faab858afa82d4c665ee1a5036190e69aa --- M binaryurp/source/le

[ABANDONED] clang, -Wuninitialized

2013-06-03 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: clang, -Wuninitialized .. Patch Set 1: Abandoned Thank you Stephan for your review. Thank you Lubos about the patch. Following what you said, I abandon this change. -- T

[PATCH] clang, -Wuninitialized

2013-06-02 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4137 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/4137/1 clang, -Wuninitialized Change-Id: Ib7c585c227d999870d5277cbee0f5bfd562185c3 --- M bridges/source/cpp_uno/gcc3_li

[PATCH] fdo#65044, manage Publisher files in Document Converter

2013-05-30 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4106 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/4106/1 fdo#65044, manage Publisher files in Document Converter Change-Id: I932d53c3c46fb0d654a1ba31b782ebcaced9bbc3 ---

[ABANDONED] coverity#983032: Resource leak

2013-05-16 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#983032: Resource leak .. Patch Set 1: Abandoned Hopefully you noticed this Michael. I was obviously too confident with this patch :-) Thank you for your review!

[PATCH] cppcheck: fix uselessAssignmentPtrArg

2013-05-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3873 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3873/1 cppcheck: fix uselessAssignmentPtrArg Change-Id: I260bb1207cebb8cefb52fe1db3f51b63239b25a7 --- M sc/source/core/

[PATCH] cppcheck: fix arrayIndexThenCheck in vcl

2013-05-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3868 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3868/1 cppcheck: fix arrayIndexThenCheck in vcl Change-Id: Id7258dd35c131c2c8151bc5e0f97076241e6d10f --- M vcl/source/c

[PATCH] cppcheck: fix arrayIndexThenCheck/optimize loops

2013-05-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3869 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3869/1 cppcheck: fix arrayIndexThenCheck/optimize loops Change-Id: If399abf5fb3eaea91f4f5d5e86b86b37790d3c9a --- M sc/s

[ABANDONED] coverity#982464: Explicit null dereferenced

2013-05-10 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#982464: Explicit null dereferenced .. Patch Set 1: Abandoned I don't know what to do with this so I prefer to abandon. -- To view, visit https://gerrit.libreoff

[PATCH] coverity#982460: Explicit null dereferenced

2013-05-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3823 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3823/1 coverity#982460: Explicit null dereferenced Change-Id: I64d559603bff0d618dce72927566531296984d3c --- M l10ntools

[PATCH] coverity#982464: Explicit null dereferenced

2013-05-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3822 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/3822/1 coverity#982464: Explicit null dereferenced Change-Id: Idb75b5b9040ce7f54775f8bc02c150f87e811af0 --- M sc/source

[PATCH] coverity#982973: Resource leak

2013-05-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3821 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3821/1 coverity#982973: Resource leak Change-Id: I1ea51b29c3ad05016f42c215b71877cd8c3f92f4 --- M extensions/source/nspl

[PATCH] coverity#983032: Resource leak

2013-05-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3820 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/3820/1 coverity#983032: Resource leak Change-Id: I0f2b245c98d80a009076494a232229c19cc034a9 --- M l10ntools/source/xrmle

[PATCH] coverity#983036/37/38: Resource leak

2013-05-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3819 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/3819/1 coverity#983036/37/38: Resource leak Change-Id: I8a2c079a60cc06ca82d9f516cf009359a0c083a7 --- M o3tl/qa/test-sor

[PATCH] coverity#983096: Resource leak

2013-05-07 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3818 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3818/1 coverity#983096: Resource leak Change-Id: I91c1d505ef0b0eb442bf76e4da66c95fa0e1bb2d --- M rsc/source/rscpp/cpp3.

[PATCH] coverity#1000604: Dereference after null check

2013-05-05 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3791 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/3791/1 coverity#1000604: Dereference after null check Change-Id: Id9c3b7eb29c58c55c100db6da644b232ada550ee --- M sw/sou

[PATCH] fdo#60265 Really fixes Basic problem

2013-05-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3729 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/3729/1 fdo#60265 Really fixes Basic problem GetFilterName function in FilesModul.xba needs the extension be repeated to

[PATCH] Forgot "with_dir"

2013-04-29 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3688 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3688/1 Forgot "with_dir" Change-Id: I1457f5619984671e8cb88173d204d3157d3cb883 --- M liblangtag/ExternalPackage_liblangt

[PATCH] fdo#63197: convert osxres

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3652 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3652/1 fdo#63197: convert osxres Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885 --- M scp2/source/ooo/file_ooo.sc

[PATCH] fdo#63197: convert liblangtag_data

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3650/1 fdo#63197: convert liblangtag_data Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9 --- A liblangtag/Externa

[PATCH] fdo#63197: convert helpxsl

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3649 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3649/1 fdo#63197: convert helpxsl Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089 --- M scp2/source/ooo/file_ooo.s

[PATCH] fdo#63197: convert fontunxafm

2013-04-28 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3648 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3648/1 fdo#63197: convert fontunxafm Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804 --- R afms/ExternalPackage_fo

[PATCH] fdo#63197: convert 3 out 4 from scripting part

2013-04-18 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3470 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3470/1 fdo#63197: convert 3 out 4 from scripting part Change-Id: Ie359d0ef00f62dd3c2d1f1dfd86e115409438e76 --- M scp2/s

[PATCH] fdo#63197: convert the rest of accessoriesgallery*

2013-04-18 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3454 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/3454/1 fdo#63197: convert the rest of accessoriesgallery* Change-Id: Ib664ba3f208c87570db284b5fc38fa58d8d8a679 --- A ex

[PATCH] fdo#63197, convert some accessories

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3449 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3449/1 fdo#63197, convert some accessories Change-Id: I0b406734603ad61d7a00ea2f6114103e10f265ed --- A extras/ExternalPa

[PATCH] fdo#63197, convert accessoriesgallerydrawspeople

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3444 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3444/1 fdo#63197, convert accessoriesgallerydrawspeople Change-Id: I9743fd98691695f831fa282a64482b23178f0026 --- A extr

[ABANDONED] fdo#63197: convert psprint_config files

2013-04-17 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: fdo#63197: convert psprint_config files .. Patch Set 1: Abandoned I tested logerrit resubmit but i must have missed something since it created https://gerrit.libreoffice.

[PATCH] fdo#63197: convert psprint_config files

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3443 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3443/1 fdo#63197: convert psprint_config files Change-Id: I99660704931c7341a72fe303fae47f984f968ecb --- M psprint_confi

[PATCH] fdo#63197: convert psprint_config files

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3442 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3442/1 fdo#63197: convert psprint_config files Change-Id: I8e3046a6ed30ac8ee60940844b8ceda6ec1ffd39 --- M psprint_confi

[PATCH] fdo#63197, convert sysui osxicons

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3440 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3440/1 fdo#63197, convert sysui osxicons Change-Id: Iab9cb3704385c115e1d25189a3d8833bd6721e24 --- M scp2/source/ooo/fil

[PATCH] fdo#63197: convert wizards

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3439 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3439/1 fdo#63197: convert wizards Change-Id: Ic7fa577fbdb527a75643c4e2919e0527432d5536 --- M scp2/source/ooo/file_ooo.s

[PATCH] Remove unused web wizard

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3438 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3438/1 Remove unused web wizard Change-Id: I76ed89c4a46e5a7b6a639e2c2717bc53d9b68bc9 --- M wizards/Module_wizards.mk D

[PATCH] Remove unused launcher wizard

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3437 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/3437/1 Remove unused launcher wizard Change-Id: I6c071f00eef88d3f56e76efddf6f0c71aa56b089 --- M wizards/Module_wizards.

[PATCH] fdo#63197, Remove Zip_launcher part

2013-04-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3436 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3436/1 fdo#63197, Remove Zip_launcher part Change-Id: I3d14cf90ec4d745a8fb70db8319a3a3042e93306 --- M wizards/Module_wi

[ABANDONED] Really use 'nCategoriesLength'

2013-04-17 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Really use 'nCategoriesLength' .. Patch Set 1: Abandoned Let's drop it. -- To view, visit https://gerrit.libreoffice.org/3161 To unsubscribe, visit https://gerrit.libreo

[PATCH] fdo#63197, convert Zip_accessoriesgallery

2013-04-16 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3416 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/3416/1 fdo#63197, convert Zip_accessoriesgallery Change-Id: I23d31c9574269f9d945a6940728c90cb7a9ae51d --- R extras/Exte

[PATCH] fdo#63197, Convert Zip_tpl*

2013-04-15 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3396 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/3396/1 fdo#63197, Convert Zip_tpl* Change-Id: I0175c31865ca442ce57f688a642bbc7d726fab69 --- M extras/Module_extras.mk R

[PATCH] fdo#63197: Convert list below:

2013-04-14 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3382 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3382/1 fdo#63197: Convert list below: Zip_gallbullets, Zip_gallhtmlexpo, Zip_gallroot, Zip_gallsound Zip_gallsounds, Zi

[PATCH] fdo#63197, Convert Zip_cfgsrvbitmapunx, Zip_cfgsrvnolang and...

2013-04-12 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3368 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3368/1 fdo#63197, Convert Zip_cfgsrvbitmapunx, Zip_cfgsrvnolang and Zip_cfgusr Change-Id: I11064116d44f4e45676553dd26a9

[PATCH] fdo#63197, Convert Zip_autotextuser

2013-04-11 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3348 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3348/1 fdo#63197, Convert Zip_autotextuser Change-Id: I6a7764637f6e5754e68ee6e4ab417224f542592d --- M extras/Module_ext

[PATCH] fdo#63197, Convert Zip_databasebiblio

2013-04-10 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3318 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3318/1 fdo#63197, Convert Zip_databasebiblio Change-Id: I58d387c4bbfd4af9cc1e800bc8c715e34a61a970 --- M extras/Module_e

[PATCH] fdo#63197, Convert Zip_database

2013-04-09 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3302 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/3302/1 fdo#63197, Convert Zip_database Change-Id: I459b27065869b50639330dcbbae8bc7a1651882f --- M extras/Module_extras.

[PATCH] Really use 'nCategoriesLength'

2013-04-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3161 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3161/1 Really use 'nCategoriesLength' Git history shows it's been there since a bugfix for #i110617# See e9ec6f67bf4aa0

[ABANDONED] Try to optimize a bit

2013-04-01 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Try to optimize a bit .. Patch Set 3: Abandoned Sorry, didn't see you had already pushed the fix. Thank you anyway for your review and explanations! :-) -- To view, visi

[RESTORED] Try to optimize a bit

2013-04-01 Thread Julien Nabet (via Code Review)
Julien Nabet has restored this change. Change subject: Try to optimize a bit .. Patch Set 2: Restored I understand a little better Markus, so I'm gonna use your patch. -- To view, visit https://gerrit.libreoffice.org/3153 To

[ABANDONED] Try to optimize a bit

2013-04-01 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: Try to optimize a bit .. Patch Set 2: Abandoned I failed with gerrit things, I resubmitted the same thing :-( Anyway, my second change was almost like yours Markus but I

[PATCH] Try to optimize a bit

2013-04-01 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3153 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/3153/1 Try to optimize a bit Change-Id: I36a529ef29b93ee46e4a3ff6823fbce15d176c27 --- M chart2/source/tools/InternalDat

[PATCH] coverity#704129: Operands don't affect result

2013-03-31 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3141 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3141/1 coverity#704129: Operands don't affect result Change-Id: I6faf86c3a41296ba4a267a58d7d0814e526b85a8 --- M sw/sour

[ABANDONED] coverity#983561: Arguments in wrong order

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#983561: Arguments in wrong order .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3126 To unsubscribe, visit https://gerrit.libreoffice

[ABANDONED] coverity#704245 Logically dead code

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704245 Logically dead code .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2949 To unsubscribe, visit https://gerrit.libreoffice.org/s

[ABANDONED] coverity#704300 Logically dead code

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704300 Logically dead code .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2976 To unsubscribe, visit https://gerrit.libreoffice.org/s

[PATCH] coverity#983561: Arguments in wrong order

2013-03-30 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3126 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3126/1 coverity#983561: Arguments in wrong order Change-Id: I3035457e93a659fe09cfe383735328f2854e5871 --- M basegfx/sou

[PATCH] Simplify a bit

2013-03-30 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3123 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3123/1 Simplify a bit Change-Id: I77cb2b08b1d92f3c8ad406bb1ebd2d080cdbfa1a --- M package/source/xstor/ohierarchyholder.

[PATCH] coverity#704145 Resource leak in object

2013-03-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3071 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/3071/1 coverity#704145 Resource leak in object Change-Id: Ia676d215cf8ef4830e31a1caf4153e33af84c200 --- M forms/source/

[ABANDONED] coverity#704453 Non-array delete for scalars

2013-03-26 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704453 Non-array delete for scalars .. Patch Set 1: Abandoned Sorry Markus, I missed the fact you had assigned yourself. -- To view, visit https://gerrit.libreo

[PATCH] coverity#704453 Non-array delete for scalars

2013-03-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3069 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/3069/1 coverity#704453 Non-array delete for scalars Change-Id: I3bc1c8c0d0cfb0df1cb059982ffa9ad10de0ccc4 --- M sw/sourc

[PATCH] coverity#982290 Logically dead code

2013-03-26 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3067 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3067/1 coverity#982290 Logically dead code Change-Id: Ia684369faa5fd0eb854d204ac7e8dbf74f032606 --- M connectivity/sour

[PATCH] coverity#704348 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3048 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3048/1 coverity#704348 Logically dead code Change-Id: I8c97042c07e3eb66468591fa9c486998ffb1e37f --- M sw/source/core/do

[PATCH] coverity#704345 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3047 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3047/1 coverity#704345 Logically dead code Change-Id: I72360ada3abedc75b2718742e8a038eb6d214f0c --- M sw/source/core/cr

[PATCH] coverity#704341 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3046 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3046/1 coverity#704341 Logically dead code Change-Id: I5a097afe1c582eab023cecadc0b1cc77faf774a1 --- M svx/source/table/

[PATCH] coverity#704334/704335/704336 Logically dead code

2013-03-25 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3045 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/3045/1 coverity#704334/704335/704336 Logically dead code Change-Id: Ieaa3c8ed735692a16c40ff01ea1dec52c2a29f31 --- M svx

[PATCH] coverity#704302 Logically dead code

2013-03-24 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2977 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2977/1 coverity#704302 Logically dead code Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37 --- M sfx2/source/dialo

[PATCH] coverity#704300 Logically dead code

2013-03-24 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2976 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/2976/1 coverity#704300 Logically dead code Change-Id: I05bf1fc737896d99419597850b70a5ca156e1b8a --- M sfx2/source/appl/

[PATCH] coverity#704247 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2952 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/2952/1 coverity#704247 Logically dead code Change-Id: Iaefddeb816d36d4a07234d903fafab3d6b83e1d2 --- M sal/rtl/strtmpl.c

[PATCH] coverity#704245 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2949 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2949/1 coverity#704245 Logically dead code Change-Id: I34d642f383b7fd323b4d5cbd1e8e7e726f83e32f --- M reportdesign/sour

[PATCH] coverity#704243 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2942 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2942/1 coverity#704243 Logically dead code Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742 --- M package/source/zi

[PUSHED] Related coverity#704213/704214/704215 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2930 -- To view, visit https://gerrit.libreoffice.org/2930 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: mer

[PATCH] Related coverity#704213/704214/704215 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2930 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2930/1 Related coverity#704213/704214/704215 Logically dead code Change-Id: I80c119b2287ff0c4f2e467943be6a7682914934a -

[PATCH] Related coverity#441160 Logically dead code

2013-03-23 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2929 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2929/1 Related coverity#441160 Logically dead code Change-Id: Ibb4cff2b9a53eb1d9f4ea6043ed2b1b2deba1e2b --- M filter/so

[ABANDONED] coverity#704622 Explicit null dereferenced

2013-03-21 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704622 Explicit null dereferenced .. Patch Set 1: Abandoned Thank you Lionel for your feedback. I'm really hesitating about all this, the more I think about this

[PATCH] coverity#704931 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2881 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/2881/1 coverity#704931 Explicit null dereferenced Change-Id: I03fe61ace1ab408d51e93f1e447591bb4eb9449c --- M sw/source/

[PATCH] Related to coverity#704822 (Explicit null dereference)

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2872 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2872/1 Related to coverity#704822 (Explicit null dereference) aSlotIds.push_back(0) => aSlotIds can't be empty => pSlot

[PATCH] coverity#704774 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2870/1 coverity#704774 Explicit null dereferenced Change-Id: Ief63d63233d11015f64f5e6a19544889f0389ca3 --- M sd/source/

[PATCH] coverity#704628/704629/704630 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2869 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/2869/1 coverity#704628/704629/704630 Explicit null dereferenced + return early if no whichid or after default case Cha

[PATCH] coverity#704622 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2867/1 coverity#704622 Explicit null dereferenced Change-Id: I3328390799a87f2acff6ee689879325e4aa4357e --- M dbaccess/s

[PATCH] coverity#704618 Explicit null dereferenced

2013-03-20 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2866 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2866/1 coverity#704618 Explicit null dereferenced Change-Id: I9f3befc235b0fb7933294be4a97d168ef203a79c --- M dbaccess/s

[ABANDONED] coverity#735383 Copy-paste error

2013-03-20 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#735383 Copy-paste error .. Patch Set 1: Abandoned I was not sure at all for this one. You confirmed my doubts so I can abandon this patch and set false positive i

[PATCH] coverity#704590 Explicit null dereferenced

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2860 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/2860/1 coverity#704590 Explicit null dereferenced Change-Id: I787a39959a1558fe4f284bc1941194a841e2d600 --- M connectivi

[PATCH] coverity#735389 Copy-paste error

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2858 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/2858/1 coverity#735389 Copy-paste error Change-Id: I74098cd2b58a64ff231d86549812d5a565835bed --- M sw/source/filter/htm

[PATCH] coverity#735383 Copy-paste error

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2855 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/2855/1 coverity#735383 Copy-paste error Change-Id: I2449c7b71d2bc575f92e064ff5438c56dd238af4 --- M sc/source/ui/Accessi

[PATCH] coverity#735382 Copy-paste error

2013-03-19 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2854 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/2854/1 coverity#735382 Copy-paste error Change-Id: I7f033b189feee848dff1e3682be04a9b2f76fae8 --- M sc/source/core/tool/

[PATCH] coverity#982272 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2806 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/2806/1 coverity#982272 Copy-paste error Change-Id: Iac5de5ea434e843c4bbf27763f16751d75e798ec --- M vcl/source/window/la

[PATCH] coverity#982271 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2802 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/2802/1 coverity#982271 Copy-paste error Change-Id: I42800a846ba0cb935f97f8e99f774f58f3b525f8 --- M ucb/source/cacher/ca

[PATCH] coverity#982269 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2801 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/2801/1 coverity#982269 Copy-paste error Change-Id: I8d900e83543d3914b215451ebbd77f823835643b --- M l10ntools/source/exp

[ABANDONED] coverity#735379 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#735379 Copy-paste error .. Patch Set 1: Abandoned Sorry Kohei/Markus, I had overlooked assignment part in scan coverity. -- To view, visit https://gerrit.libreo

[PATCH] coverity#735379 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2800 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/2800/1 coverity#735379 Copy-paste error Change-Id: Ic700edb903fd9b306173d0136e5a6421899c9377 --- M sc/source/core/data/

[PATCH] coverity#735375 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2799 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/2799/1 coverity#735375 Copy-paste error Change-Id: Ib976de6a5a1c54fd80645b675b20186a4b9d6661 --- M filter/source/msfilt

[PATCH] coverity#735374 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2798 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/2798/1 coverity#735374 Copy-paste error Change-Id: Icbd64c87f6a8fb87f4f2d82f23d3df613bbb6cfb --- M editeng/source/rtf/r

[PATCH] coverity#735373 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2797 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/2797/1 coverity#735373 Copy-paste error Change-Id: I0273a08a7aa23aa9bb7aa2139a0cea02611e8feb --- M editeng/source/items

[PATCH] coverity#735372 Copy-paste error

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2795 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/2795/1 coverity#735372 Copy-paste error Change-Id: Id25a5216a3814fbb3f4f1d7ac88cd87270b63fde --- M cui/source/tabpages/

[PATCH] coverity#736014 Using invalid iterator

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2787 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2787/1 coverity#736014 Using invalid iterator Change-Id: I53c9079aa78a28f50e91474b8347c4830583a6f1 --- M lotuswordpro/s

[PATCH] coverity#705115 Using invalid iterator

2013-03-17 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2785 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/2785/1 coverity#705115 Using invalid iterator Change-Id: Ia8b5a0654ded07d939e8be93a2dea2a6f84165b3 --- M sw/source/ui/d

[PATCH] coverity#705137 Missing break in switch

2013-03-16 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2780 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/2780/1 coverity#705137 Missing break in switch Change-Id: Ie54c888e15e9564c7e1d0efb54f587a586a53631 --- M cppu/source/t

[PATCH] coverity#705135 Missing break in switch

2013-03-16 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2779 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/2779/1 coverity#705135 Missing break in switch Change-Id: Ie610b3b10b5d83b772ad96e455d59360368086a4 --- M connectivity/

[PATCH] coverity#988428 Missing break in switch

2013-03-16 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2775 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2775/1 coverity#988428 Missing break in switch Change-Id: I7f127409c65f692c2eec3684c79b40b11e7ce240 --- M writerfilter/

[PATCH] coverity#738979 Use after free

2013-03-15 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2766 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2766/1 coverity#738979 Use after free Change-Id: I843556f18542ac601fd7e16c6f51218ef913de31 --- M svx/source/gallery2/ga

[PATCH] coverity#708921: Use after free

2013-03-14 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2738 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/2738/1 coverity#708921: Use after free Change-Id: I446fa717dfd11fc5d6045cb1e8dc3eaf8861262e --- M svx/source/gallery2/g

  1   2   >