[PUSHED libreoffice-4-1] remove inherited number formats, fdo#60215

2013-06-03 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4147 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4147 To unsubscribe, visi

[PUSHED] coverity#1000855 Unitialized scalar variable

2013-05-13 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3896 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3896 To unsubscribe, visi

[PUSHED] gbuild: Replace SHOWINCLUDES_PREFIX without regexp.

2013-05-13 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3579 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3579 To unsubscribe, visi

[PUSHED libreoffice-4-0] c:varyColor is true by default in Excel

2013-05-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3686 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3686 To unsubscribe, visi

[PUSHED libreoffice-4-0] c:delete is true by default in Excel

2013-05-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3685 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3685 To unsubscribe, visi

[PUSHED libreoffice-4-0] change order to allow validation of chart part

2013-05-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3657 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3657 To unsubscribe, visi

[PATCH libreoffice-4-0] fdo#61820: Avoid crasher when file URL contains unicode byte...

2013-04-23 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3581 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/3581/1 fdo#61820: Avoid crasher when file URL contains unicode bytes. This is a cherry-pick of 6374df20c2a8378209cce21c

[PATCH libreoffice-4-0] Remove the 4th option from the pivot table source selection ...

2013-04-15 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3402 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/3402/1 Remove the 4th option from the pivot table source selection dialog. Change-Id: I39ed1a9fd0476506cac0852af6318207

[PUSHED libreoffice-3-6] prevent vector and sequence out of bounds access, fdo#60300

2013-04-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3344 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3344 To unsubscribe, visi

[PUSHED libreoffice-4-0] prevent vector and sequence out of bounds access, fdo#60300

2013-04-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3340 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3340 To unsubscribe, visi

[PUSHED libreoffice-3-6] prevent out of bounds vector access in ooo62493-1.xls recalc...

2013-04-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3339 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3339 To unsubscribe, visi

[PUSHED libreoffice-4-0] prevent out of bounds vector access in ooo62493-1.xls recalc...

2013-04-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3336 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3336 To unsubscribe, visi

[PUSHED libreoffice-4-0] disable cached value import for ODS for now, fdo#60215

2013-04-09 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3290 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3290 To unsubscribe, visi

[PUSHED libreoffice-4-0] fdo#51296 Patch accounts security setting requiring ctrl+cli...

2013-03-25 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3032 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3032 To unsubscribe, visi

[PUSHED] Remove commented code in VCL demo app - should make the exam...

2013-03-22 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2920 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2920 To unsubscribe, visi

[PATCH libreoffice-4-0] fdo#54651: Only pick non-default number format for pivot fie...

2013-03-07 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2585 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/2585/1 fdo#54651: Only pick non-default number format for pivot field. Change-Id: Ia88282803c8df8389ed24efd8b1ca7600a39

[PUSHED] calc : multiple tabs can be hidden at once

2013-02-14 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2053 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2053 To unsubscribe, visi

[PATCH libreoffice-4-0] bnc#802350: Cell validation is not a special (cell) content.

2013-02-13 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2128 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/2128/1 bnc#802350: Cell validation is not a special (cell) content. Cell validation is stored as cell attributes which

[PUSHED libreoffice-3-6] resolved fdo#60366 make MATCH() accept a single cell referen...

2013-02-07 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2019 Approvals: Kohei Yoshida: Verified; Looks good to me, approved Norbert Thiebaud: Looks good to me, but someone else must approve -- To

[PUSHED libreoffice-4-0] resolved fdo#60366 make MATCH() accept a single cell referen...

2013-02-07 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2018 Approvals: Kohei Yoshida: Verified; Looks good to me, approved Norbert Thiebaud: Looks good to me, but someone else must approve -- To

[PATCH libreoffice-4-0] API CHANGE: unpublish com.sun.star.document.MediaDescriptor.

2013-02-07 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2016 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/2016/1 API CHANGE: unpublish com.sun.star.document.MediaDescriptor. This is a service that basically describes the prop

[PATCH libreoffice-3-6] fdo#39135: Prevent integer overflow & update the character d...

2013-02-06 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2008 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2008/1 fdo#39135: Prevent integer overflow & update the character during loop. These two errors in the code contributed

[PATCH libreoffice-4-0] fdo#39135: Prevent integer overflow & update the character d...

2013-02-06 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2007 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/2007/1 fdo#39135: Prevent integer overflow & update the character during loop. These two errors in the code contributed

[PATCH libreoffice-4-0] fdo#59426: Don't try to repair package during flat detection...

2013-02-04 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1984 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/1984/1 fdo#59426: Don't try to repair package during flat detection phase. Change-Id: I35968241a79db0aabe06e25c0efac2aa

[PATCH libreoffice-4-0] bnc#801152: Scan all columns to determine the first data row...

2013-02-02 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1959 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1959/1 bnc#801152: Scan all columns to determine the first data row. When scanning the entire data range in an attempt

Change in core[libreoffice-4-0-0]: fdo#51232: i#119987# fix Impress crash when pasting text und...

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1933 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1933 To unsubscribe, visi

Change in core[libreoffice-4-0]: we need to use SCROW for row numbers, fdo#59894

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1945 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1945 To unsubscribe, visi

Change in core[libreoffice-4-0]: we need to parse the cell address after import, fdo#59843

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1944 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1944 To unsubscribe, visi

Change in core[libreoffice-4-0]: show style when dialog is created with existing cond format, ...

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1943 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1943 To unsubscribe, visi

Change in core[libreoffice-4-0]: if no cond format is valid use the existing protection, fdo#...

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1942 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1942 To unsubscribe, visi

Change in core[libreoffice-4-0]: make it possible to update DDE links after loading, fdo#5903...

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1940 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1940 To unsubscribe, visi

Change in core[libreoffice-4-0]: resolved fdo#60087 corrected .xlsx export of functions

2013-02-01 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1929 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1929 To unsubscribe, visi

Change in core[libreoffice-4-0]: resolved fdo#60078 correctly calculate IMCSCH and IMSECH

2013-01-31 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1926 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1926 To unsubscribe, visi

Change in core[libreoffice-4-0]: bnc#437516: Hide minimum password info in the password dialo...

2013-01-31 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1946 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1946/1 bnc#437516: Hide minimum password info in the password dialog. When launching it from the Security tab of the PD

Change in core[libreoffice-4-0]: bnc#492440: Sort autofilter popup items correctly.

2013-01-30 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1932 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1932/1 bnc#492440: Sort autofilter popup items correctly. Use locale-aware collator to sort strings, instead of using t

Change in core[libreoffice-4-0]: bnc#615317: Recompile cells with #NAME! for English function...

2013-01-30 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1931 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1931/1 bnc#615317: Recompile cells with #NAME! for English function name option. When the option for using English func

Change in core[libreoffice-4-0]: resolved fdo#60043 write correct IM* function names

2013-01-30 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1920 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1920 To unsubscribe, visi

Change in core[libreoffice-4-0-0]: fdo#59056: Re-calculate cell anchor position of a pasted dra...

2013-01-28 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1899 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1899/1 fdo#59056: Re-calculate cell anchor position of a pasted drawing object. Else it would re-use the anchor positio

[PATCH] Change in core[libreoffice-4-0]: fdo#59056: Re-calculate cell anchor position of a pasted dra...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1869 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1869/1 fdo#59056: Re-calculate cell anchor position of a pasted drawing object. Else it would re-use the anchor positio

[PATCH] Change in core[libreoffice-3-6]: bnc#590020: Sort data points stably.

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1872 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1872/1 bnc#590020: Sort data points stably. std::sort is unstable sort, which is not what we want. Use std::stable_sor

[PATCH] Change in core[libreoffice-4-0]: bnc#590020: Sort data points stably.

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1871 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1871/1 bnc#590020: Sort data points stably. std::sort is unstable sort, which is not what we want. Use std::stable_sor

[PUSHED] Change in core[libreoffice-4-0]: import inherited number formats with cached values, fdo#5972...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1866 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1866 To unsubscribe, visi

[PATCH] Change in core[libreoffice-4-0-0]: bnc#798271: Don't delete the PropertyMapEntry instance prema...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1860 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/1860/1 bnc#798271: Don't delete the PropertyMapEntry instance prematurely. When using comphelper::PropertyMapEntry arra

[PATCH] Change in core[libreoffice-3-6]: bnc#798271: Don't delete the PropertyMapEntry instance prema...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1859 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1859/1 bnc#798271: Don't delete the PropertyMapEntry instance prematurely. When using comphelper::PropertyMapEntry arra

[PATCH] Change in core[libreoffice-4-0]: bnc#798271: Don't delete the PropertyMapEntry instance prema...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1858 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1858/1 bnc#798271: Don't delete the PropertyMapEntry instance prematurely. When using comphelper::PropertyMapEntry arra

[PATCH] Change in core[libreoffice-4-0-0]: fdo#58562: Ensure internal data is always used when pasting ...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1846 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1846/1 fdo#58562: Ensure internal data is always used when pasting to another doc. Without this, pasting a chart object

[PUSHED] Change in core[libreoffice-4-0-0]: reset automatic row height flag after import, fdo#59193

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1832 Approvals: Kohei Yoshida: Verified; Looks good to me, approved Noel Power: Verified; Looks good to me, but someone else must approve Jor

[PATCH] Change in core[libreoffice-4-0]: fdo#58562: Ensure internal data is always used when pasting ...

2013-01-25 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1835 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/1835/1 fdo#58562: Ensure internal data is always used when pasting to another doc. Without this, pasting a chart object

[PUSHED] Change in core[libreoffice-3-6]: reset one of the sort containers before refilling, fdo#57465

2013-01-18 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1753 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1753 To unsubscribe, visi

[PUSHED] Change in core[libreoffice-4-0]: reset one of the sort containers before refilling, fdo#57465

2013-01-18 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1752 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1752 To unsubscribe, visi

[PATCH] Change in core[libreoffice-4-0]: fdo#58988, fdo#58562: Populate draw clip document with data ...

2013-01-18 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1757 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/1757/1 fdo#58988, fdo#58562: Populate draw clip document with data for charts. Without populating the clip document, co

[PUSHED] Resolves: fdo#58865 hard-coded LibreOffice strings

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1656 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1656 To unsubscribe, visi

[PATCH] Change in core[libreoffice-3-6]: Let's not return here to prevent memory leak.

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1654 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1654/1 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the

[PATCH] Change in core[libreoffice-4-0]: Let's not return here to prevent memory leak.

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1653 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1653/1 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the

[PATCH] Change in core[libreoffice-3-6]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1651 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/1651/1 fdo#59084: Sync dimension members after reloading the group data. Else the syncing would end up syncing to the o

[PATCH] Change in core[libreoffice-4-0]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1635 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/1635/1 fdo#59084: Sync dimension members after reloading the group data. Else the syncing would end up syncing to the o

[PUSHED] Change in core[libreoffice-4-0]: Resolves: fdo#58301 make sure ScrollBar OptimalSize is up to...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1630 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1630 To unsubscribe, visi

[PUSHED] Change in core[libreoffice-4-0]: Resolves: fdo#59112 re-scroll to current entry when dialog r...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1628 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1628 To unsubscribe, visi

[PUSHED] Change in core[libreoffice-4-0]: - fdo#46460 - Missing Circles and Ovals toolbar

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1627 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1627 To unsubscribe, visi

[PATCH] Change in core[libreoffice-4-0]: fdo#58069: Invalidate sheet stream cache when directory path...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1634 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1634/1 fdo#58069: Invalidate sheet stream cache when directory path changes. To properly regenerate hyperlinks (among o

[PATCH] Change in core[libreoffice-4-0]: fdo#58531: Register cells with external references at compil...

2013-01-10 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1631 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1631/1 fdo#58531: Register cells with external references at compile time. In the old code, we would do this during int

[PATCH] Change in core[libreoffice-4-0]: fdo#58539: Correctly set cached matrix formula result.

2013-01-09 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1623 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1623/1 fdo#58539: Correctly set cached matrix formula result. During the import, a cached matrix value only has an empt

[PUSHED] tabs to spaces

2012-12-20 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1458 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1458 To unsubscribe, visit

[PUSHED] Remove unused method from sc: importBiffRecord

2012-12-18 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1410 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1410 To unsubscribe, visit

[PUSHED] fdo#58370 - 'Send Feedback...' URL invalid in other language...

2012-12-18 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1408 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1408 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: fix sometimes data corruption with xlsx import ( with scenar...

2012-12-17 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1338 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1338 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: fix fdo#58237 import hyperlinks for shapes in xlsx documents

2012-12-17 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1337 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1337 To unsubscribe, visit

[PATCH] Change in core[libreoffice-3-6]: Do extra check on source range to make sure no funny things ...

2012-12-14 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1345 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1345/1 Do extra check on source range to make sure no funny things happen. Like a crash in the pivot layout dialog... :

[PUSHED] fdo#31309 Taskpane items visibility can't be restored

2012-12-12 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1231 Approvals: Lennard Wasserthal: Looks good to me, but someone else must approve Kohei Yoshida: Verified; Looks good to me, approved -- To

[PUSHED] Change in core[libreoffice-3-6]: fdo#52240 added [hr-HR] date acceptance patterns D/M/Y; D/M

2012-12-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1288 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1288 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: fdo#52240 added [no-NO] date acceptance patterns D.M; D/M/Y; D...

2012-12-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1287 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1287 To unsubscribe, visit

[PATCH] Change in core[libreoffice-3-6]: fdo#57497: Remove group table data when all group dimensions...

2012-12-05 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1247 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1247/1 fdo#57497: Remove group table data when all group dimensions are gone. Otherwise ungrouping date grouped dimensi

[PUSHED] Change in core[libreoffice-3-6-4]: resolved fdo#56278 broadcast deletion to dependent formula c...

2012-11-16 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1081 Approvals: Markus Mohrhard: Looks good to me, but someone else must approve Kohei Yoshida: Verified; Looks good to me, approved -- T

[PATCH] Change in core[libreoffice-3-6]: fdo#56776: Change in formula options should cause repaint.

2012-11-13 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1049 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1049/1 fdo#56776: Change in formula options should cause repaint. Else Calc would fail to update the column headers due

[PATCH] Change in core[libreoffice-3-6-4]: fdo#56776: Change in formula options should cause repaint.

2012-11-13 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1050 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1050/1 fdo#56776: Change in formula options should cause repaint. Else Calc would fail to update the column headers due

[PATCH] Change in core[libreoffice-3-6]: fdo#54898: Test equality by order index (integer) which is m...

2012-11-08 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1013 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1013/1 fdo#54898: Test equality by order index (integer) which is more stable. At the point where std::unique is called

[PATCH] Change in core[libreoffice-3-6]: Minor enhancements on the autofilter popup window.

2012-11-06 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/997 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/997/1 Minor enhancements on the autofilter popup window. 1) Launch pop-up right-aligned in case the cell is wider than t

[PATCH] Change in core[libreoffice-3-6]: fdo#53531: Time field can be represented with an extended ti...

2012-11-05 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/992 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/992/1 fdo#53531: Time field can be represented with an extended time field type. And Calc's header footer currently don'

[PUSHED] Change in core[libreoffice-3-6]: fix xlsx export missing alignment attributes with cellstyle ...

2012-11-05 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/959 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/959 To unsubscribe, vis

[PUSHED] Change in core[libreoffice-3-6]: halt corrupted styles with multi-saved xlsx document fdo#554...

2012-11-05 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/958 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/958 To unsubscribe, vis

[PUSHED] Change in core[libreoffice-3-6-3]: kill this hard coded sheet limit for xlsx import, rhbz#86485...

2012-10-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/857 Approvals: Kohei Yoshida: Verified; Looks good to me, approved Eike Rathke: Looks good to me, but someone else must approve -- To vie

[PUSHED] Change in core[libreoffice-3-6]: Fix crash on Mac when a11y in use, and avoid infinite loop, ...

2012-09-27 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/708 -- To view, visit https://gerrit.libreoffice.org/708 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

Change in core[libreoffice-3-6]: Fix crash on Mac when a11y in use, and avoid infinite loop, ...

2012-09-27 Thread Kohei Yoshida (via Code Review)
Hello Norbert Thiebaud, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/708 to look at the new patch set (#2). Change subject: Fix crash on Mac when a11y in use, and avoid infinite loop, fdo#47275

[PUSHED] sax: com.sun.star.xml.sax.FastSerializer seems to be unused

2012-09-07 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/480 Approvals: Kohei Yoshida: Verified Michael Meeks: Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/480 To

[PUSHED] Better center status bar items between separators

2012-09-07 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/298 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/298 To unsubscribe, vis