Hello Julien
On 02/01/2012 11:40 PM, julien2412 wrote:
> Here are the lines :
> 961 // dann mal die Tabellenkoepfe raus:
> 962 for( SwSelBoxes::iterator it = rBoxes.begin(); it !=
> rBoxes.end(); ++it )
> 963 {
> 964 pLine = i
Hello Stephan,
On 24.01.2012 09:30, Stephan Bergmann wrote:
> However, I have another question: I notice that, while most
> occurrences are replaced with SAL_WARN, some were left as OSL_ENSURE
> (which I changed to SAL_WARN; one missed a comma, anyway) and some
> are changed to SAL_INFO. Was th
cution
would stand out while the macros could easily be skipped.
The code size shouldn't matter because after the preprocessor run the
output is exactly the same and I prefer code clarity over source code size.
regards Marcel Metz
___
LibreOffice m
Hello lo-devs,
the attached patches replace some of the ENSURE_OR_* macros, with
regular code. I can't see any advantage in these macros aside from save
some typing.
regards Marcel Metz
>From 1d0aeb0f7266646da553ea7d120afcc9065118e5 Mon Sep 17 00:00:00 2001
Me
Hello lo-devs,
this patch removes the unused DBG_WARNING4 and DBG_WARNING5 macros and
replaces also the DBG_WARNINGFILE with SAL_INFO as suggested in the
tools/debug.hxx headers.
regards
Marcel
---
cui/source/dialogs/iconcdlg.cxx |2 +-
sfx2/source/dialog/tabdlg.cxx |4 ++--
tools/in
---
binfilter/bf_sfx2/source/bastyp/sfx2_bitset.cxx | 10 --
binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx |6 --
2 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/binfilter/bf_sfx2/source/bastyp/sfx2_bitset.cxx b/binfilter/bf_sfx2/source/bastyp/sfx2_bitset.c
ignore the memory block.
regards
Marcel Metz
---
sfx2/source/appl/appopen.cxx |6 -
sfx2/source/appl/appserv.cxx |4 -
sfx2/source/bastyp/bitset.cxx| 14 ---
sfx2/source/bastyp/minarray.cxx |9 --
sfx2/source/control/bindings.cxx | 22
sfx2/source/control
Hello lo-devs,
this patch removes another use of the tools Table class.
regards
Marcel Metz
---
vcl/source/control/combobox.cxx | 21 +++--
1 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
Hello lo-devs,
this patch removes the superfluous _ZFORLIST_DECLARE_TABLE define that
is explicit defined right in in front of the conditional code.
regards
Marcel Metz
---
chart2/source/controller/dialogs/DataBrowser.cxx |3 ---
.../controller/dialogs/dlg_ObjectProperties.cxx|3
---
binfilter/inc/bf_sfx2/fcontnr.hxx |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/binfilter/inc/bf_sfx2/fcontnr.hxx b/binfilter/inc/bf_sfx2/fcontnr.hxx
index 07f9c75..13d62fb 100644
--- a/binfilter/inc/bf_sfx2/fcontnr.hxx
+++ b/binfilter/inc/bf_sfx2/fcontnr.hxx
@@ -35
---
binfilter/bf_so3/source/solink/impldde.hxx |1 +
binfilter/inc/bf_basic/sbstar.hxx |1 +
binfilter/inc/bf_sc/cellsuno.hxx |1 +
binfilter/inc/bf_sw/crsrsh.hxx |1 +
4 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/binfilter/bf_so3/s
---
cui/source/dialogs/SpellDialog.cxx |1 -
cui/source/dialogs/cuitbxform.cxx |1 -
cui/source/dialogs/dlgname.cxx |1 -
cui/source/tabpages/tabarea.cxx|1 -
fileaccess/source/FileAccess.cxx |1 -
sc/source/ui/view/tabview5.cxx |1 -
ilter --enable-dbgutil --enable-debug.
regards
Marcel Metz
---
basic/inc/basic/sbstar.hxx |1 +
dbaccess/source/ui/inc/linkeddocuments.hxx |1 -
editeng/inc/editeng/unoedsrc.hxx |1 -
embeddedobj/source/msole/graphconvert.cxx |
---
binfilter/bf_xmloff/source/core/xmloff_xmlexp.cxx |1 +
.../bf_xmloff/source/meta/xmloff_xmlmetae.cxx |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/binfilter/bf_xmloff/source/core/xmloff_xmlexp.cxx b/binfilter/bf_xmloff/source/core/xmloff_xmlexp.cxx
index
---
binfilter/inc/bf_starmath/smmod.hxx |2 ++
binfilter/inc/bf_sw/shellres.hxx|2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/binfilter/inc/bf_starmath/smmod.hxx b/binfilter/inc/bf_starmath/smmod.hxx
index f3f4ec4..1ec73db 100644
--- a/binfilter/inc/bf_starmath/
---
binfilter/inc/bf_starmath/smmod.hxx |2 ++
binfilter/inc/bf_sw/shellres.hxx|2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/binfilter/inc/bf_starmath/smmod.hxx
b/binfilter/inc/bf_starmath/smmod.hxx
index f3f4ec4..1ec73db 100644
--- a/binfilter/inc/bf_starmath/s
---
sd/source/filter/eppt/pptx-epptbase.cxx |1 -
sfx2/source/doc/docfile.cxx |1 -
sfx2/source/doc/objstor.cxx |1 -
vcl/unx/generic/app/salinst.cxx |1 -
4 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sd/source/filter/eppt/pptx-epp
---
avmedia/source/gstreamer/gstcommon.hxx |1 -
avmedia/source/quicktime/quicktimecommon.hxx |1 -
avmedia/source/win/wincommon.hxx |1 -
basic/source/sbx/sbxres.cxx|2 ++
basic/source/sbx/sbxres.hxx
---
cui/source/factory/cuiresmgr.cxx |1 -
cui/source/factory/dlgfact.cxx |1 -
cui/source/inc/about.hxx |1 -
dbaccess/source/core/api/viewcontainer.cxx |1 -
dbaccess/source/ui/inc/charsets.hxx
cker.mm so it would be maybe a good
idea to test this patch.
regards Marcel Metz
---
basic/source/classes/sb.cxx|1 -
chart2/source/view/axes/VAxisProperties.cxx|1 -
chart2/source/view/diagram/VDiagram.cxx|1 -
chart2/source
Hello lo-devs,
this patch removes the unused (according to OpenGrok) GetIsoFallback
function from the tools module.
regards Marcel
---
rsc/source/parser/rscdb.cxx |1 -
tools/Library_tl.mk |1 -
tools/Package_inc.mk|1 -
tools/inc/tools/isofallback.hxx |
Hello lo-devs,
There is never an instance of mpDateTable allocated and a lot of
code is never executed because of that. This patch removes the
unused code.
regards Marcel
---
svtools/inc/svtools/calendar.hxx|3 -
svtools/source/control/calendar.cxx | 119
++-
Hello lo-devs,
this patch reduces the copyright notice noise of the FCFGMerge tool.
regards Marcel
---
l10ntools/source/filter/merge/FCFGMerge.java |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/l10ntools/source/filter/merge/FCFGMerge.java b/l10ntools/source/filter
Hello Eike,
after testing the change tracking feature in calc I've found yet
another bug in the UI. The attached patch fixes the bug in
question.
regards Marcel
---
sc/source/ui/miscdlgs/acredlin.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sc/source/ui/miscdlg
On 21.12.2011 21:00, Eike Rathke wrote:
>
> The assertion tells if there was a dup, in that case something was going
> wrong and memory leaks.
>
> Anyway, aparently you were confused by the two different tables/maps and
> mixing iterator from different map, see
> http://cgit.freedesktop.org/libre
On 21.12.2011 20:27, Michael Stahl wrote:
>
> pushed to master, with 2 small corrections:
>
> this here inverted the logic, Get == 0 means not found:
> - if ( p != pAct && !rTable.Get( p->GetActionNumber() ) )
> + if ( p != pAct && rMap.find( p->GetActionNumber() ) != rMap.end() )
>
> and in Sc
Hello lo-devs,
this patch replaces yet another Table class use.
regards Marcel Metz
---
sw/source/core/text/inftxt.hxx | 19 ---
1 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/sw/source/core/text/inftxt.hxx b/sw/source/core/text/inftxt.hxx
index 34845ec
with the
same key so that this assertion for double keys is not required but
maybe I'm missing something.
regards Marcel Metz
---
sc/inc/chgtrack.hxx| 42 --
sc/source/core/tool/chgtrack.cxx | 138
++--
sc/source/filt
---
svl/source/misc/inettype.cxx | 38 ++
1 files changed, 22 insertions(+), 16 deletions(-)
diff --git a/svl/source/misc/inettype.cxx b/svl/source/misc/inettype.cxx
index 1cba9dc..b043f06 100644
--- a/svl/source/misc/inettype.cxx
+++ b/svl/source/misc/inett
---
cui/source/options/optasian.cxx | 73
+++
1 files changed, 36 insertions(+), 37 deletions(-)
diff --git a/cui/source/options/optasian.cxx b/cui/source/options/optasian.cxx
index 5cafe5d..326f4dc 100644
--- a/cui/source/options/optasian.cxx
+++ b/cui/sour
---
cui/source/dialogs/pastedlg.cxx | 20
cui/source/inc/pastedlg.hxx |4 ++--
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/cui/source/dialogs/pastedlg.cxx b/cui/source/dialogs/pastedlg.cxx
index 47fdf2f..656a813 100644
--- a/cui/source/dialogs/p
Hello lo-devs,
This patch series replaces some DECLARE_TABLE macros with
the std::map equivalent.
regards
Marcel
---
vcl/source/window/accel.cxx | 20
1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/vcl/source/window/accel.cxx b/vcl/source/window/accel.c
Hello LO-devs,
As the subject already mentions this patch removes unnessecary
header includes for the tools table implementation.
I'm using OpenGrok quite often for the cleanups so I would like
to know how often the indices are updated.
---
filter/source/xsltdialog/xmlfileview.hxx |
Hello Eike,
> In the mean time, as this is your first contribution to the
> code base, could you please send a blanket statement to the
> mailing list (preferably in this thread) that you contribute
> this and further patches under LGPLv3+ and MPL 1.1 licenses?
I totally forgot that, well today d
Hello Eike,
On 01.12.2011 20:28, Eike Rathke wrote:
> Hi Marcel,
>
> On Thursday, 2011-12-01 11:08:40 +0100, Marcel Metz wrote:
>
>> this is my first patch series to the lo project.
> Wow, large and great one :-)
> I'll inspect details later or tomorrow, from a
---
starmath/inc/parse.hxx |3 +-
starmath/source/math_pch.cxx |1 -
starmath/source/mathmlimport.cxx | 223
++
starmath/source/mathmlimport.hxx |8 ++-
starmath/source/parse.cxx| 222
--
5
Hello libreoffice devs,
this is my first patch series to the lo project. It replaces the use
of the tools Stack class and corresponding macros with the std::stack
as suggested in in bug #39445 [1] (an easy hack).
I would like to continue with cleaning up the tools module. I've seen
that there ar
---
filter/source/svg/svgwriter.hxx | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/filter/source/svg/svgwriter.hxx b/filter/source/svg/svgwriter.hxx
index dd033a2..0b6048e 100644
--- a/filter/source/svg/svgwriter.hxx
+++ b/filter/source/svg/svgwriter.hxx
---
sc/source/filter/inc/XclExpChangeTrack.hxx | 23 +++-
sc/source/filter/xcl97/XclExpChangeTrack.cxx | 29
++---
2 files changed, 16 insertions(+), 36 deletions(-)
diff --git a/sc/source/filter/inc/XclExpChangeTrack.hxx b/sc/source/filter/inc/XclExpCha
---
vcl/inc/vcl/cvtsvm.hxx|5 ++---
vcl/source/gdi/cvtsvm.cxx | 16 ++--
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/vcl/inc/vcl/cvtsvm.hxx b/vcl/inc/vcl/cvtsvm.hxx
index de4158e..370871b 100644
--- a/vcl/inc/vcl/cvtsvm.hxx
+++ b/vcl/inc/vcl/cvtsvm.hxx
@@
---
sc/source/filter/html/htmlpars.cxx | 14 ++
sc/source/filter/inc/htmlpars.hxx |4 +---
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx
index bb79d59f..67644c2 100644
--- a/sc/source/filt
---
sc/source/filter/inc/xcl97esc.hxx |4 ++--
sc/source/filter/xcl97/xcl97esc.cxx | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sc/source/filter/inc/xcl97esc.hxx b/sc/source/filter/inc/xcl97esc.hxx
index df7c09d..a2af601 100644
--- a/sc/source/filter/inc
---
sc/source/filter/xml/xmlfilti.hxx | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/sc/source/filter/xml/xmlfilti.hxx b/sc/source/filter/xml/xmlfilti.hxx
index 92a094c..11a5300 100644
--- a/sc/source/filter/xml/xmlfilti.hxx
+++ b/sc/source/filter
---
sc/source/filter/inc/filt_pch.hxx |1 -
tools/Package_inc.mk |1 -
tools/inc/tools/stack.hxx | 103
-
3 files changed, 0 insertions(+), 105 deletions(-)
delete mode 100644 tools/inc/tools/stack.hxx
diff --git a/sc/source/filt
---
vcl/source/gdi/cvtsvm.cxx | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/vcl/source/gdi/cvtsvm.cxx b/vcl/source/gdi/cvtsvm.cxx
index 7d9ec4d..bb5628f 100644
--- a/vcl/source/gdi/cvtsvm.cxx
+++ b/vcl/source/gdi/cvtsvm.cxx
@@ -29,7 +29,6 @@
#inclu
---
sc/source/filter/html/htmlpars.cxx | 20 +---
sc/source/filter/inc/htmlpars.hxx |3 ++-
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx
index 6cebfae..bb79d59f 100644
--- a/sc/source
46 matches
Mail list logo
