Help with #fdo52622

2012-11-26 Thread Marcos Souza
Hi LO guys, After take a look in bugzilla, I reached a "simple" work: Remove duplicated code. So, what can I do? Create a new file in tools dir? If you can send me some tips, I believe I can help in this issue :) Until now, I don't understood very well how to build process work, a lot of .mk fi

Re: Help with #fdo52622

2012-11-27 Thread Marcos Souza
Hi Michael! 2012/11/27 Michael Meeks > Hi Marcos, > > On Tue, 2012-11-27 at 00:13 -0200, Marcos Souza wrote: > > After take a look in bugzilla, I reached a "simple" work: Remove > > duplicated code. > > Ah - so, by now this task is very nearly done a

Re: Help with #fdo52622

2012-11-27 Thread Marcos Souza
me Vanz" > escreveu: > > >> >> >> 2012/11/27 Marcos Souza >> >>> Hi Michael! >>> >>> 2012/11/27 Michael Meeks >>> >>>> Hi Marcos, >>>> >>>> On Tue, 2012-11-27 at 00:13 -0200, Marcos Souza wrote: >

Build error libxmlsec

2012-11-28 Thread Marcos Souza
Hi guys, I'm getting this error when trying to build the master: checking for gnutls libraries >= 0.8.1... no checking for mscrypto libraries... none checking for crypto library... configure: error: At least one crypto library should exist for xmlsec1 dmake: Error code 1, while making './ unxlngi

[PATCH] Fix copy&paste in test

2012-11-01 Thread Marcos Souza
The patch is attached. -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC Github: https://github.com/marcosps/ "Uma vida sem desafios é uma vida sem razão" "A life without challenges, is a non reason life" 0001-Fix-copy-paste-in-test.patch Description: Binary data ___

framework - Find/remove useless ifdefs and dead code within them

2012-11-10 Thread Marcos Souza
Hi List! Some days ago, I developed a script that can show to us all ifdefs that don't have a "#define". After run this script in the "framework" dir, I get this list: ifdef ENABLE_COMPONENT_SELF_CHECK without #define. This can be removed? ifdef DBG_UTIL without #define. This can be removed? ifd

Re: framework - Find/remove useless ifdefs and dead code within them

2012-11-12 Thread Marcos Souza
2012/11/10 Matúš Kukan > On 10 November 2012 17:51, Marcos Souza > wrote: > > Hi List! > > > > Some days ago, I developed a script that can show to us all ifdefs that > > don't have a "#define". > > > > After run this scri

licence

2012-09-25 Thread Marcos Souza
All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Marcos Paulo de Souza -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC Github: https://github.com/marcosps/ "Uma vida sem desafios é uma vida sem razão" "A life w

Redland - Build error in Ubuntu 12.10 x86

2013-04-03 Thread Marcos Souza
Hi guys, In master , I'm getting this error: Redland build summary: Using monolithic storage backends Oracle Berkeley DB (BDB) : Missing Triple stores available : memory file hashes(memory) trees Triple stores enabled: memory file hashes trees RDF parsers : raptor(sy

Re: Redland - Build error in Ubuntu 12.10 x86

2013-04-03 Thread Marcos Souza
Thanks Caolan! Now it's working :) 2013/4/3 Caolán McNamara > On Wed, 2013-04-03 at 14:45 -0300, Marcos Souza wrote: > > Hi guys, > > > > > > In master , I'm getting this error: > > > /home/marcos/gitroot/core/solver/unxlngi6/inc/extern

Help in the issue fdo#70807

2013-12-16 Thread Marcos Souza
Hi guys! I'm trying to solve the issues fdo#70807. I putted some points in the bug, but I need to understand where the code set a style as used. Can someone point to me where a style is set as used inside the code base? Thanks since now! signature.asc Description: OpenPGP digital signature __

Re: Want to get started with libreoffice development

2013-06-22 Thread Marcos Souza
Hi Sonakshi! Nice to know that you want to help LO! So, a nice place to start maybe could be the String -> OUString conversion, or maybe the chained appends! The're quite easy, and a nice start point. A did a lot of patches with this target! Bug from String -> OUString conversion: https://bugs.

Thank

2013-11-11 Thread Marcos Souza
Hi LO people! I'm here to say a HUGE THANKS YOU about my travel to Germany. It's awesome when we can link faces and names, to know nice people and work together in some tasks! I just want to say a "I'm sorry" if I did less than you expected for you, but I really enjoyed! So, I just need to learn

Re: Thank

2013-11-12 Thread Marcos Souza
Hi Eike, Em 11/11/2013 05:16 PM, Eike Rathke escreveu: > Hi Marcos, > > On Monday, 2013-11-11 08:00:58 -0200, Marcos Souza wrote: > >> So, again, a HUGE THANKS YOU for all you guys that helped me in Germany, >> and to the guys who invited me to visit them in their hou

Re: Need for starmath expert

2013-11-12 Thread Marcos Souza
Hi abdulaziz, Em 11/11/2013 07:11 AM, abdulaziz escreveu: > Hi all ; > > we have an idea for RTL (arabic) support in Math and we want someone who > expert in starmath to answering the following questions : I'm not the expert, but maybe I know somethings that can help you :) > > 1- is it pos

Re: Need for starmath expert

2013-11-14 Thread Marcos Souza
Hi abdulaziz, Em 11/14/2013 01:41 PM, abdulaziz escreveu: > so many thanks Marcos , You're welcome :) > > you really help me ... > > I'll let you know if I need help > > again , Thank you... I would love to help you guys to port Math to RTL :) > > > > -- > View this message in context: >

Fwd: Problem while moving oox to autoinstallation

2013-11-21 Thread Marcos Souza
Sending to list, because maybe _mst is very busy and some other guy can help me on this :) Mensagem original Assunto: Problem while moving oox to autoinstallation Data: Tue, 19 Nov 2013 09:07:13 -0200 De: Marcos Souza Para: mst...@redhat.com Hi Michail, how are you? I hope

Doubt about OpenSymbol and Math

2013-06-03 Thread Marcos Souza
Hi LO guys, Some after looking at all Math bugs(I looked at AOO bugs too), I saw something interesting: About 30 % of bugs are about Symbols. Someone asking to put new symbols, another guys asking about a "Symbol manager" to add new symbols by UI and more. So, I saw this commit of Olivier:

Re: Doubt about OpenSymbol and Math

2013-06-03 Thread Marcos Souza
ripts to test if we the matrics are the same in both fonts...? Regards. 2013/6/3 Marcos Souza : Hi LO guys, Some after looking at all Math bugs(I looked at AOO bugs too), I saw something interesting: About 30 % of bugs are about Symbols. Someone asking to put new symbols, another guys a

Re: Doubt about OpenSymbol and Math

2013-06-04 Thread Marcos Souza
Hi Michael, Em 06/04/2013 05:41 AM, Michael Meeks escreveu: Hi Marcos, On Mon, 2013-06-03 at 19:20 -0300, Marcos Souza wrote: Some after looking at all Math bugs, I saw something interesting: :-) About 30 % of bugs are about Symbols. Someone asking to put new symbols, another guys

Re: Doubt about OpenSymbol and Math

2013-06-04 Thread Marcos Souza
Hi Noel, Em 06/04/2013 06:43 AM, Noel Grandin escreveu: On 2013-06-04 10:41, Michael Meeks wrote: > > On Mon, 2013-06-03 at 19:20 -0300, Marcos Souza wrote: >> Some after looking at all Math bugs, I saw something interesting: >> About 30 % of bugs are about Symbols. Someone

Code pointer for fdo#67534

2013-09-18 Thread Marcos Souza
Hi guys, Can someone give me some tips of bug https://bugs.freedesktop.org/show_bug.cgi?id=67534 ? Thanks since now! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Can't access logerrit buildbot logs

2013-10-07 Thread Marcos Souza
Stephan, Em 10/07/2013 08:43 AM, Stephan Bergmann escreveu: Just had the following IRC conversation; can anybody help? Oct 07 12:33:40 floeff, getting keeps timing out here; that sth for you to look at? Oct 07 13:16:26 sberg: for the machine, im

Error in languagetag unittest

2013-10-16 Thread Marcos Souza
Hi LO guys, I'm getting this error since last week, I did a lot of pulls and it's still broken: /languagetag.cxx:674: LanguageTag::registerOnTheFly: not cross-inserted 0x51 for 'dz' have 'bo' canvasbitmaptest.cxx:183:Assertion Test name: (anonymous namespace)::CanvasBitmapTest::runTest assertion

Re: error in unit test

2013-10-16 Thread Marcos Souza
Now it worked for me... I don't know why. I pulled this afternoon(in Brazil) and it worked. I did a make clean and compiled this again. Thanks a lot for helping me in this issue. @Cor, can you try this now? Do a pull and try to build again? Maybe do a make clean. Em 10/16/2013 07:09 PM, Thorste

Context Menu - Writer

2014-08-15 Thread Marcos Souza
Hello guys, I'm trying to contribute to LibreOffice. But I can not find the piece of code that refers to the 'context menu' in writer module. I would like to do what suggests Bug 62947 in bugzilla. Could anyone help me with this? I really want to contribute but can not find me in the code. I alrea

Re: Context Menu - Writer

2014-08-18 Thread Marcos Souza
Thank you guys! 2014-08-16 9:02 GMT-03:00 Tomaž Vajngerl : > Hi, > > On Sat, Aug 16, 2014 at 12:16 AM, Marcos Souza > wrote: > > Hello guys, > > > > I'm trying to contribute to LibreOffice. But I can not find the piece of > > code that refers to the &#x

Re: Build error libxmlsec

2012-12-02 Thread Marcos Souza
Hi Caolán! After some days, and pulling again, now xmlsec is building again! Thanks a lot for the quick answer! 2012/11/30 Caolán McNamara > On Wed, 2012-11-28 at 19:02 -0200, Marcos Souza wrote: > > Hi guys, > > > > I'm getting this error when trying to build th

Personas in LibreOffice

2012-12-06 Thread Marcos Souza
Hi list, After take a look in some commits in LO about the FFox Personas, I saw that this is only for Windows until now... There is a reason for that? There is something that we can do for extend this for Linux users? I belvei that's a nice feature for LO! Congrats to the authors! Thanks a lot

Crash in Base with empty database

2012-12-12 Thread Marcos Souza
Hi guys! Some days ago I was playing with the Base app. I never touched this before, so I was pressing some buttons after create a new database to see what it can do for me. And, I crashed LO :) But, I was trying to learn how to debug LO, but I'm almost without free time... so I'm sending this

GSoC 2013 and LO

2013-01-15 Thread Marcos Souza
Hi LO guys! Can anybody tells me when GSoC will start? And, there is a place for put some ideas?(I believe this exists in the wiki, but unfortunately I didn't found where it can be... ) Thanks for all! -- Att, Marcos Paulo de Souza Acadêmico de Ciencia da Computação - FURB - SC Github: https:

LOGO Toolbar in front of New Document when closing and reopen LO

2013-01-15 Thread Marcos Souza
Hi guys! I believe this maybe be simple to solve, so I'm just sending this email to tell you this issue. I was playing with the LOGO toolbar, and if we close and reopen Writer with View->Toolbar->Logo set, the LOGO toolbar appears in front of New document! I tried to master branch now, so I beli

Fwd: LOGO Toolbar in front of New Document when closing and reopen LO

2013-01-16 Thread Marcos Souza
CCing the list =D -- Forwarded message -- From: Marcos Souza Date: 2013/1/16 Subject: Re: LOGO Toolbar in front of New Document when closing and reopen LO To: ten...@iseries-guru.com Hum... I believed that is could be so simple that we don't need to create a new bug...

Re: GSoC 2013 and LO

2013-01-21 Thread Marcos Souza
Thanks guys! I have an idea for base, and I sent an email to Muthu and to Lionel talking abou this idea. I'm still waiting for their response! Thanks again! 2013/1/15 Simos Xenitellis > On Tue, Jan 15, 2013 at 9:01 PM, Marcos Souza > wrote: > > Hi LO guys! > > > &

Code pointers for replace HSQLDB for Firebird

2013-03-20 Thread Marcos Souza
Hi guys! As suggested by Cecric and Muthu, I'm here to ask some code pointers to work in the HSQLDB replacement for Firebird. I'm reading https://bugs.freedesktop.org/show_bug.cgi?id=51781 from Lionel, and trying to understand what needs to be done to achieve this, but some code pointers are bett

Re: Code pointers for replace HSQLDB for Firebird

2013-03-21 Thread Marcos Souza
Hi David, 2013/3/21 David Ostrovsky > On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote: > > Hi guys! > > > > > > As suggested by Cecric and Muthu, I'm here to ask some code pointers > > to work in the HSQLDB replacement for Firebird. > > >

Re: Code pointers for replace HSQLDB for Firebird

2013-03-21 Thread Marcos Souza
Hi Lionel! 2013/3/21 Lionel Elie Mamane > On Thu, Mar 21, 2013 at 08:26:42AM +0100, David Ostrovsky wrote: > > On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote: > > > Hi guys! > > > > > > > > > As suggested by Cecric and Muthu, I'm h

Build error - testFdo60915

2013-03-22 Thread Marcos Souza
Hi guys, I'm trying to build LO with head 683142294f291a77329a2d266124432aeba8522b and I'm getting the following error message: [build CXX] svx/source/unodraw/unopool.cxx svl.cxx:321:Assertion Test name: (anonymous namespace)::Test::testFdo60915 equality assertion failed - Expected: 18/05/2446 -

Re: Build error - testFdo60915

2013-03-22 Thread Marcos Souza
AHuahUAHauhAUAHU Brazil makes me laught in LO too T.T Yes this is my timezone 2013/3/22 Eike Rathke > Hi Marcos, > > On Friday, 2013-03-22 14:34:45 -0300, Marcos Souza wrote: > > > [build CXX] svx/source/unodraw/unopool.cxx > > svl.cxx:321:Assertion &

Re: Build error - testFdo60915

2013-03-24 Thread Marcos Souza
=/ > > Att, > Rodolfo > > 2013/3/22 Eike Rathke : > > Hi Marcos, > > > > On Friday, 2013-03-22 17:01:12 -0300, Marcos Souza wrote: > > > >> AHuahUAHauhAUAHU > >> > >> Brazil makes me laught in LO too T.T > > > > Glad you had

Same function implemented 6 times in calc tests

2013-01-28 Thread Marcos Souza
Hi guys! While I was looking at some STRINGPARAM macros in calc, I saw the function createFileURL is implemented several times: http://opengrok.libreoffice.org/search?q=void+createFileURL&project=core&defs=&refs=&path=sc&hist= And they are all equal. In UnoApiTest exists a createFileURL too, and

Base tests are disabled?

2013-01-31 Thread Marcos Souza
Hi guys, while I was looking some code that implement it's own version of createFileURL, I saw that dbaccess have some test files, but it seems that's disabled: [marcos@jedi core]$ make dbaccess.subsequentcheck cd dbaccess && make -j 2 -rs subsequentcheck /mnt/dados/gitroot/core/solenv/gbuild/Pac

Help with fdo#60471

2013-02-12 Thread Marcos Souza
Hi guys! I was trying to solve this issue, but I need some code pointers... Can you guys point to me some places to start? And one more thing, there is a place for "learn" how UNO works and how this is used inside LO? I believe UNO is used in every case that we handle files right? Thanks since

Re: Help with fdo#60471

2013-02-12 Thread Marcos Souza
out debug=true!! 2013/2/12 Jan Holesovsky > Hi Marcos, > > Marcos Souza píše v Út 12. 02. 2013 v 16:04 -0200: > > > I was trying to solve this issue, but I need some code pointers... > > > > Can you guys point to me some places to start? > > Yes - so please

Re: Help with fdo#60471

2013-02-12 Thread Marcos Souza
I tried to get the error message from uno::Exception using a SAL_WARN, but this is the message: [ line 4]: error This don't say anything to me : ) 2013/2/12 Marcos Souza > Hi Kendy and list! > > This is the point where we get this issue: > > // final

Asking about math issue

2013-05-14 Thread Marcos Souza
Hi guys! I was looking at this old issue in math. I can reproduce this behavior, and it maybe be simple to fix: https://bugs.freedesktop.org/show_bug.cgi?id=32062 So, my idea: If we have the formula selected, and we insert a new unary operator operator(+- , -+, ¬, +, -) we will prepend the curren

Remove unused methods from unicode

2012-11-26 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove unused methods from unicode .. Patch Set 1: Abandoned These methods will be used in some time. -- To view, visit https://gerrit.libreoffice.org/1087 To

framework: Remove code inside a ifdef without define

2012-11-26 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: framework: Remove code inside a ifdef without define .. Patch Set 1: Abandoned We need to talk with community to verify what can be removed. -- To view, visit https

[PATCH] Remove useless method SetBackgroundBitmap

2012-11-28 Thread Marcos Souza (via Code Review)
essageType: newchange Gerrit-Change-Id: I3e10bea4eac114326ff981fb21ba0d292818b1da Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.o

[PATCH] Remove not used acros form sd

2012-10-12 Thread Marcos Souza (via Code Review)
: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove not used macros from connectivity

2012-10-12 Thread Marcos Souza (via Code Review)
-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove some unused methods

2012-10-14 Thread Marcos Souza (via Code Review)
Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Remove not used acros form sd

2012-10-15 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove not used acros form sd .. Patch Set 1: Abandoned These macros are documentation. Remove these patches about macros. -- To view, visit https

Remove not used macros from connectivity

2012-10-15 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove not used macros from connectivity .. Patch Set 1: Abandoned This remove documentation. -- To view, visit https://gerrit.libreoffice.org/862 To unsubscribe, visit

[PATCH] Remove unused methods

2012-10-30 Thread Marcos Souza (via Code Review)
-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused method in formula module

2012-10-30 Thread Marcos Souza (via Code Review)
: newchange Gerrit-Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

[PATCH] Remove unused method in editeng

2012-10-30 Thread Marcos Souza (via Code Review)
: Ia283f2e70fa623d0155b6de51ad5441163505cc0 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused method from test

2012-10-30 Thread Marcos Souza (via Code Review)
-MessageType: newchange Gerrit-Change-Id: Id54d9bd2963573c4b8e77de0dfafe33ea5882d32 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] Remove a unused method from sd

2012-10-30 Thread Marcos Souza (via Code Review)
Gerrit-MessageType: newchange Gerrit-Change-Id: Iae918397a61f1b08983b666248075feeded8d99b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] Remove unused method and also remove not build test

2012-11-03 Thread Marcos Souza (via Code Review)
Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Remove unused methods

2012-11-08 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove unused methods .. Patch Set 1: Abandoned Caolan already changed and comitted -- To view, visit https://gerrit.libreoffice.org/937 To unsubscribe, visit https

Remove a unused method from sd

2012-11-08 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove a unused method from sd .. Patch Set 1: Abandoned Ow... just remove it :) -- To view, visit https://gerrit.libreoffice.org/948 To unsubscribe, visit https

[PATCH] framework: Remove code inside a ifdef without define

2012-11-08 Thread Marcos Souza (via Code Review)
, 385 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1012 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb6e92b78782f7cb7520ffd050be1654678ef866 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: M

[PATCH] Remove unused methods from writerfilter

2012-11-15 Thread Marcos Souza (via Code Review)
(-) -- To view, visit https://gerrit.libreoffice.org/1074 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63b0510fea80c12579985fbc4d4eb4646376e25b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza

[PATCH] Remove unused methods from unicode

2012-11-16 Thread Marcos Souza (via Code Review)
: newchange Gerrit-Change-Id: I12004788d58809fbf5c135f6badf5cc3c184bd17 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

[PATCH] Remove unused methods

2012-10-01 Thread Marcos Souza (via Code Review)
-MessageType: newchange Gerrit-Change-Id: I8fc47c39ede4e5b06af2144667ede5e9c2d5b397 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] Remove blocks of code that will never execute("#if 0" blocks...

2012-10-01 Thread Marcos Souza (via Code Review)
isit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63de52342ce6435b6e8e19b041e2dae59c681f34 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freed

[PATCH] Remove not used macros from lotusworkpro

2012-10-02 Thread Marcos Souza (via Code Review)
-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove some unused methods listed by unusedcode.easy

2012-10-02 Thread Marcos Souza (via Code Review)
-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Remove unused methods

2012-10-03 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove unused methods .. Patch Set 1: Abandoned Already applied in master -- To view, visit https://gerrit.libreoffice.org/742 To unsubscribe, visit https

Remove some unused methods listed by unusedcode.easy

2012-10-04 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove some unused methods listed by unusedcode.easy .. Patch Set 1: Abandoned Caolan already remvoe some methods in your last merge -- To view, visit https

[PATCH] Remove useless code

2012-10-05 Thread Marcos Souza (via Code Review)
Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Kill use of macro LINGU_EXCEPTIONS

2012-10-06 Thread Marcos Souza (via Code Review)
g/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6f784859210d5a59210af51766ef4d7b8d7ead6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedeskto

[PATCH] Remove more unused methods

2012-10-07 Thread Marcos Souza (via Code Review)
: I5c6bb319458b1ce60cedfe0e2b0f5eaa8ba55e9d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove more useless code inside "#if 0" blocks

2012-10-08 Thread Marcos Souza (via Code Review)
ch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] More useless code, "#if 0" blocks in lingucomponent, sal, an...

2012-10-08 Thread Marcos Souza (via Code Review)
gs Gerrit-MessageType: newchange Gerrit-Change-Id: I1dda0f2b3bc2bb4a4a877c160026e53a90471d54 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedeskto

[PATCH] Get ride of not used macros in filter

2012-10-08 Thread Marcos Souza (via Code Review)
://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7f06720c9f4614b763066bb3cf136f2464b2c7bd Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice

[PATCH] fdo#57950: Chained appends in postgresql driver

2013-04-02 Thread Marcos Souza (via Code Review)
tractStringProperty( past, st.TABLE_NAME ) ); -// buf.appendAscii( RTL_CONSTASCII_STRINGPARAM( " to table " ) ); -// buf.append( extractStringProperty( past, st.TABLE_NAME ) ); -// throw SQLException( buf.makeStringAndClear(), Reference< XInterface > () ); -//

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

2013-04-11 Thread Marcos Souza (via Code Review)
unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice

[ABANDONED] Fix fdo#32720: limit buttons doesn't add the sum sign

2013-05-30 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Fix fdo#32720: limit buttons doesn't add the sum sign .. Patch Set 1: Abandoned So, leave it as is. -- To view, visit https://gerrit.libreoffice.org/4067 To unsubs

[ABANDONED] Fix fdo#32062: Math overwrites selected area when new elemen...

2013-06-04 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Fix fdo#32062: Math overwrites selected area when new element .. Patch Set 1: Abandoned Forgive this by now -- To view, visit https://gerrit.libreoffice.org/3982 To

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add calc module

2013-06-10 Thread Marcos Souza (via Code Review)
_Executable_$$(group) :=)) -- To view, visit https://gerrit.libreoffice.org/4225 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89e87f2e107bdb31f19262c83f8e20be9642a4eb Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-B

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move some libs to OOO a...

2013-06-11 Thread Marcos Souza (via Code Review)
id_File_Jar_Email, gid_File_Jar_Mail, gid_File_Jar_Activation, -- To view, visit https://gerrit.libreoffice.org/4231 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52ecc75e26f5f1997d3a575682b78fbd673e4591 Gerrit-PatchSet: 1 Gerrit-Project: core

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-06-11 Thread Marcos Souza (via Code Review)
onfig); -- To view, visit https://gerrit.libreoffice.org/4232 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1553317afe8df9877a41b1d4087c96d861ed1377 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Sou

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-06-13 Thread Marcos Souza (via Code Review)
://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a3511172ac8ddd060c51c0339a4b9ff16216668 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list Libr

[PATCH] fdo#60924 autoinstall - gbuild/scp2: still more libs to OOO

2013-06-13 Thread Marcos Souza (via Code Review)
gid_File_Lib_Policy_Cli_Oootypes_Assembly, gid_File_Lib_Policy_Cli_Oootypes_Config); -- To view, visit https://gerrit.libreoffice.org/4268 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3a0a740263e92752115665ab5e25c5063b18

[PATCH] Remove useless attributions in starmath

2013-06-14 Thread Marcos Souza (via Code Review)
Token.cMathChar = '\0'; aToken.nGroup = TRGROUP; -aToken.nLevel = 0; aToken.eType = TMATRIX; SmMatrixNode *pSNode = new SmMatrixNode(aToken); pSNode->SetSubNodes(aExpressionArray); -- To view, visit https://gerrit.libreoffice.org/4282 To unsubscribe, visit http

[PATCH] Fixes fdo#59642

2013-06-17 Thread Marcos Souza (via Code Review)
rrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-21 Thread Marcos Souza (via Code Review)
core Gerrit-Branch: master Gerrit-Owner: Marcos Souza Gerrit-Reviewer: LibreOffice gerrit bot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-21 Thread Marcos Souza (via Code Review)
et: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza Gerrit-Reviewer: Björn Michaelsen Gerrit-Reviewer: LibreOffice gerrit bot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-22 Thread Marcos Souza (via Code Review)
et: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza Gerrit-Reviewer: Björn Michaelsen Gerrit-Reviewer: LibreOffice gerrit bot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-26 Thread Marcos Souza (via Code Review)
errit-Branch: master Gerrit-Owner: Marcos Souza Gerrit-Reviewer: LibreOffice gerrit bot Gerrit-Reviewer: Marcos Souza Gerrit-Reviewer: Michael Stahl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-26 Thread Marcos Souza (via Code Review)
errit-Branch: master Gerrit-Owner: Marcos Souza Gerrit-Reviewer: LibreOffice gerrit bot Gerrit-Reviewer: Marcos Souza Gerrit-Reviewer: Michael Stahl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

[PATCH] fdo#61513: Remove FSysFailOnErrorImpl macro

2013-03-03 Thread Marcos Souza (via Code Review)
f /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- To view, visit https://gerrit.libreoffice.org/2535 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3842ef28ea676e75b18c192f8d9610dcb3c3d0c Gerrit-PatchSet: 1 Gerrit-Project: c

[PATCH] fdo#57950: Remove chained appends in codemaker

2013-03-07 Thread Marcos Souza (via Code Review)
>loadStringConstant("component context fails to supply service " + unoName + + " of type " + realJavaBaseName); // stack: ex ex "..." code->loadLocalReference(1); // stack: ex ex "...&qu

[PATCH] Removed last RTL_CONST* macros from codemaker

2013-03-08 Thread Marcos Souza (via Code Review)
ector< unsigned char > & stream, rtl::OString const & signature) { if (!signature.isEmpty()) { -appendU2( -stream, - addUtf8Info(rtl::OString(RTL_CONSTASCII_STRINGPARAM("Signature"; +appendU2(stream, addUtf8Info("Signature")); appendU4(stream, 2); appendU2(stream, addUtf8Info(signature)); } diff --git a/codemaker/source/javamaker/javamaker.cxx b/codemaker/source/javamaker/javamaker.cxx index af4796d..182eb2d 100644 --- a/codemaker/source/javamaker/javamaker.cxx +++ b/codemaker/source/javamaker/javamaker.cxx @@ -179,7 +179,7 @@ if (tmpName == "*") { // produce this type and his scope. -if (typeName.equals("*")) +if (typeName == "*") { tmpName = "/"; } else diff --git a/codemaker/source/javamaker/javatype.cxx b/codemaker/source/javamaker/javatype.cxx index b5662bb..108dc6c 100644 --- a/codemaker/source/javamaker/javatype.cxx +++ b/codemaker/source/javamaker/javatype.cxx @@ -2474,9 +2474,7 @@ codemaker::GeneratedTypeSet & generated, JavaOptions * options) { OSL_ASSERT(options != 0); -if (type.equals("/") -|| type.equals(manager.getBase()) -|| generated.contains(type)) +if (type == "/" || type == manager.getBase() || generated.contains(type)) { return true; } @@ -2548,9 +2546,7 @@ ::rtl::OString typeName = manager.getTypeName(rTypeKey); OSL_ASSERT(options != 0); -if (typeName.equals("/") -|| typeName.equals(manager.getBase()) -|| generated.contains(typeName)) +if (typeName == "/" || typeName == manager.getBase() || generated.contains(typeName)) { return true; } -- To view, visit https://gerrit.libreoffice.org/2605 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ce4fd2cc7c62a18e059e945b42cc01425802aa0 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fod#57950: Removed some chained appends from sw

2013-03-10 Thread Marcos Souza (via Code Review)
tring(nDocSh)); +rData.CopyByteString(SOT_FORMATSTR_ID_SONLK, sStrBuf); } sal_Bool NaviContentBookmark::Paste( TransferableDataHelper& rData ) diff --git a/sw/source/ui/wrtsh/wrtundo.cxx b/sw/source/ui/wrtsh/wrtundo.cxx index 7760525..88da0d6 100644 --- a/sw/source/ui/wrtsh/wrtundo.cxx +++ b/sw/source/ui/wrtsh/wrtundo.cxx @@ -114,10 +114,9 @@ default:;//prevent warning } -::rtl::OUStringBuffer buf = ::rtl::OUStringBuffer( String( SvtResId( nResStr ) ) ); -buf.append(aUndoStr); +OUStringBuffer buf = ::rtl::OUStringBuffer( String( SvtResId( nResStr ) ) ); -return buf.makeStringAndClear(); +return buf.makeStringAndClear() + aUndoStr; } sal_uInt16 SwWrtShell::GetDoStrings( DoType eDoType, SfxStringListItem& rStrs ) const @@ -134,12 +133,11 @@ default:;//prevent warning } -::rtl::OUStringBuffer buf; +OUStringBuffer buf; for (size_t i = 0; i < comments.size(); ++i) { OSL_ENSURE(!comments[i].isEmpty(), "no Undo/Redo Text set"); -buf.append(comments[i]); -buf.append(sal_Unicode('\n')); +buf.append(comments[i] + "\n"); } rStrs.SetString(buf.makeStringAndClear()); return static_cast(comments.size()); @@ -156,8 +154,7 @@ return str; } -::rtl::OUStringBuffer buf( String(SvtResId(STR_REPEAT)) ); -buf.append(str); +::rtl::OUStringBuffer buf( String(SvtResId(STR_REPEAT)) + str); return buf.makeStringAndClear(); } -- To view, visit https://gerrit.libreoffice.org/2643 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b78b4a8f2fc0fb0c4a67042ac4924e375c2d63a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove rtl:: from a test in test/

2012-11-30 Thread Marcos Souza (via Code Review)
: I151dc2e733c6c3a56d316b931934ff80aa076580 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused method from desktop

2012-12-01 Thread Marcos Souza (via Code Review)
Gerrit-MessageType: newchange Gerrit-Change-Id: I17b269c70bbf82aa5a4345d488777ac98d1d6938 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PATCH] Remove UniString from uui module

2012-12-10 Thread Marcos Souza (via Code Review)
Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

  1   2   >