[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-26 Thread Marcos Souza (via Code Review)
Hello Michael Stahl, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5631 to look at the new patch set (#4). Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO ..

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-26 Thread Marcos Souza (via Code Review)
Hello Michael Stahl, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5631 to look at the new patch set (#5). Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO ..

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-22 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, Björn Michaelsen, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5571 to look at the new patch set (#4). Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-21 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5571 to look at the new patch set (#2). Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-08-21 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, Björn Michaelsen, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5571 to look at the new patch set (#3). Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[PATCH] Fixes fdo#59642

2013-06-17 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4314 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/4314/1 Fixes fdo#59642 By making just the one test, the most generic one, and not nesting strstr functions calls.

[PATCH] Remove useless attributions in starmath

2013-06-14 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4282 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/4282/1 Remove useless attributions in starmath These values are initialized as 0 in the constructor(see

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-06-13 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4267 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/4267/1 fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO Change-Id: I7a3511172ac8ddd060c51c0339a4b9ff16216668

[PATCH] fdo#60924 autoinstall - gbuild/scp2: still more libs to OOO

2013-06-13 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4268 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/4268/1 fdo#60924 autoinstall - gbuild/scp2: still more libs to OOO Change-Id:

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move some libs to OOO a...

2013-06-11 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4231 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/4231/1 fdo#60924 autoinstall - gbuild/scp2: Move some libs to OOO and clean a little Also put the vbaswobj lib in the

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

2013-06-11 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4232 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/4232/1 fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO Change-Id: I1553317afe8df9877a41b1d4087c96d861ed1377

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add calc module

2013-06-10 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4225 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/4225/1 fdo#60924 autoinstall - gbuild/scp2: add calc module Change-Id: I89e87f2e107bdb31f19262c83f8e20be9642a4eb --- M

[ABANDONED] Fix fdo#32062: Math overwrites selected area when new elemen...

2013-06-04 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Fix fdo#32062: Math overwrites selected area when new element .. Patch Set 1: Abandoned Forgive this by now -- To view, visit https://gerrit.libreoffice.org/3982 To

[ABANDONED] Fix fdo#32720: limit buttons doesn't add the sum sign

2013-05-30 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Fix fdo#32720: limit buttons doesn't add the sum sign .. Patch Set 1: Abandoned So, leave it as is. -- To view, visit https://gerrit.libreoffice.org/4067 To

[ABANDONED] fdo#60924 autoinstall - gbuild/scp2: add math module

2013-05-27 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#60924 autoinstall - gbuild/scp2: add math module .. Patch Set 1: Abandoned Will send a new rebased patch -- To view, visit https://gerrit.libreoffice.org/3919 To

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add math module

2013-05-27 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4065 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/4065/1 fdo#60924 autoinstall - gbuild/scp2: add math module Change-Id: I466dd68069576d57740ef34b8f6fcd8f9025c5c8 --- M

[PATCH] Fix fdo#32720: limit buttons doesn't add the sum sign

2013-05-27 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4067 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/4067/1 Fix fdo#32720: limit buttons doesn't add the sum sign Change-Id: I9086707f14335ea26bb94c36ee0f87e770c9418b ---

[ABANDONED] fdo#60924: autoinstall onlineupdate libraries

2013-05-22 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#60924: autoinstall onlineupdate libraries .. Patch Set 1: Abandoned This change is merged with other commit related to onlineupdate -- To view, visit

[PATCH] Remove dead log-area

2013-05-21 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3992 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/3992/1 Remove dead log-area The nullcanvas was removed in 1cd9b5d859a6468164b043b0fcaaf49c1907500c Change-Id:

[PATCH] Fix fdo#32062: Math overwrites selected area when new elemen...

2013-05-20 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3982 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3982/1 Fix fdo#32062: Math overwrites selected area when new element We're appending the new simbol in front of the

[PATCH] Fix fdo#32059: Commands merge with variables

2013-05-20 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3983 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3983/1 Fix fdo#32059: Commands merge with variables Verify if there is a space before insert a new command to not

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add math module

2013-05-16 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3919 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/3919/1 fdo#60924 autoinstall - gbuild/scp2: add math module Change-Id: I0ee6ac3fc32356dac6b3cc498d98ab71fdea29ad --- M

[PATCH] Big ISDigit method and use isAsciiDigit from CharClass

2013-05-13 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3888 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3888/1 Big ISDigit method and use isAsciiDigit from CharClass Also remove the unused function strnccmp. Change-Id:

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add onlineupdate module

2013-05-12 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3877 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3877/1 fdo#60924 autoinstall - gbuild/scp2: add onlineupdate module Change-Id:

[PATCH] fdo#60924: autoinstall onlineupdate libraries

2013-05-12 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3878 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3878/1 fdo#60924: autoinstall onlineupdate libraries Change-Id: I9e06d165351161ff144b7605094a3e490d13d5f2 --- M

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add graphicfilter modul...

2013-05-08 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3827 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/3827/1 fdo#60924 autoinstall - gbuild/scp2: add graphicfilter module Change-Id:

[PATCH] fdo#60924: autoinstall graphicfilter libraries

2013-05-08 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3829 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/3829/1 fdo#60924: autoinstall graphicfilter libraries Change-Id: I406ecef9bc1865d0cd17e3428bff137d972f --- M

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add tde module

2013-05-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3808 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/3808/1 fdo#60924 autoinstall - gbuild/scp2: add tde module Change-Id: I4c13d1cd4b7490a0b4db8f0dd40d823a5906c8aa --- M

[PATCH] fdo#60924: autoinstall tde libraries

2013-05-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3809 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3809/1 fdo#60924: autoinstall tde libraries Change-Id: Id986bc7f9f09902dfda849bc86f9c48ccb0f30c3 --- M Repository.mk M

[PATCH] fdo#60924: autoinstall gnome libraries

2013-05-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3813 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/3813/1 fdo#60924: autoinstall gnome libraries Change-Id: I0fd872d15a0c938d32aac185c3c00c5fb14a091a --- M Repository.mk

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add gnome module

2013-05-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3812 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3812/1 fdo#60924 autoinstall - gbuild/scp2: add gnome module Change-Id: I37570787815d85d30eed3b5291e1e4450e5ffd51 ---

[PATCH] fdo#60924: Move some more libs to autoinstallation

2013-05-03 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3758 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/3758/1 fdo#60924: Move some more libs to autoinstallation Change-Id: I7383da4390995ad9ea2d4fb494098dab6287609f --- M

[PATCH] fdo#63154: Remove _CL and _LF from solar.h

2013-05-02 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3740 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3740/1 fdo#63154: Remove _CL and _LF from solar.h And use RTL_CHAR_{CR,LF} from rtl/string.h Change-Id:

[PATCH] fdo#60949: Remove last UNOLIBS_OOO

2013-04-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3682 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3682/1 fdo#60949: Remove last UNOLIBS_OOO Change-Id: I79af32f188a0e7de71ec8e6743fe73b3bb030a3f --- M Repository.mk 1

[PATCH] fdo#60924: Move more libs to autoinstallation

2013-04-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3689 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3689/1 fdo#60924: Move more libs to autoinstallation Change-Id: I5c136760ca59278ba6bfcd1d11c56d810e9cfa76 --- M

[PATCH] fdo#60924: Move some libs to autoinstallation

2013-04-27 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3630 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3630/1 fdo#60924: Move some libs to autoinstallation Change-Id: I58421587784260bd88994926bca031ab26a6214f --- M

[PATCH] fdo#60924: Move some libs to autoinstallation

2013-04-27 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3630 to look at the new patch set (#2). Change subject: fdo#60924: Move some libs to autoinstallation

[PATCH] fdo#63154: Remove all usages of the macro EXTERN_C

2013-04-26 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3621 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3621/1 fdo#63154: Remove all usages of the macro EXTERN_C Change-Id: I25b7f509ba5d1007a16c84ad05870a8174c094ec --- M

[PATCH] fdo#60949: Remove UNOLIBS_OOO

2013-04-26 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3626 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3626/1 fdo#60949: Remove UNOLIBS_OOO By removing the last two libs: nullcanvas and directx5canvas. directx5canvas

[PATCH] fdo#60949: Move the last libs to OOOLIBS

2013-04-24 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3561 to look at the new patch set (#3). Change subject: fdo#60949: Move the last libs to OOOLIBS

[PATCH] fdo#63154: Removed all usages of SVLIBRARY

2013-04-23 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3574 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3574/1 fdo#63154: Removed all usages of SVLIBRARY Change-Id: Ib1b6ba1220657343a264525d1cb55138e481f4fd --- M

[PATCH] fdo#60949: Move the last libs to OOOLIBS

2013-04-23 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, Matúš Kukan, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3561 to look at the new patch set (#2). Change subject: fdo#60949: Move the last libs to OOOLIBS

[PATCH] fdo#60949: Move the last libs to OOOLIBS

2013-04-22 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3561 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3561/1 fdo#60949: Move the last libs to OOOLIBS Change-Id: Ieec4edf41140f9c5af3dcc227c917b06157a26f3 --- M

[PATCH] fdo#60949: Move more libs to OOOLIBS

2013-04-20 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3511 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3511/1 fdo#60949: Move more libs to OOOLIBS Change-Id: Ibd45f7004f8eaa151b9a60d7369d396411f60a2b --- M Repository.mk M

[ABANDONED] fdo#57950: Chained appends in postgresql driver

2013-04-19 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#57950: Chained appends in postgresql driver .. Patch Set 1: Abandoned Needs a rework. -- To view, visit https://gerrit.libreoffice.org/3170 To unsubscribe, visit

[PATCH] fdo#60949: Move more libs to OOOLIBS

2013-04-19 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3484 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/3484/1 fdo#60949: Move more libs to OOOLIBS Change-Id: I566602028556aa954bcbd116c375b9b61cc3df6f --- M Repository.mk M

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

2013-04-19 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3326 to look at the new patch set (#3). Change subject: fdo#63154: Change macros Min/Max for std::min/max ..

[PATCH] fdo#60949: Move some libs to OOOLIBS

2013-04-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3467 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3467/1 fdo#60949: Move some libs to OOOLIBS Compile test only :) Change-Id: I14a64ba0b61933372c2e3c99666d74f3d115d134

[PATCH] fdo#62699: Drop wrapper header

2013-04-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3473 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3473/1 fdo#62699: Drop wrapper header Change-Id: I21e91ab136c944c6dc77a90500b1bcebbf7cf851 --- M

[PATCH] fdo#60949: Move some libs to OOOLIBS

2013-04-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3476 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/3476/1 fdo#60949: Move some libs to OOOLIBS Compile test only :) Change-Id: I1e546b824ec027bb1321e36fb060af5b4cfd1bf1

[ABANDONED] fdo#60949: Move some libs to OOOLIBS

2013-04-18 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#60949: Move some libs to OOOLIBS .. Patch Set 1: Abandoned A new change-id was generated(my bad) so abandoning this -- To view, visit

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

2013-04-18 Thread Marcos Souza (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/3326 to look at the new patch set (#2). Change subject: fdo#63154: Change macros Min/Max for std::min/max ..

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

2013-04-11 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3326 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3326/1 fdo#63154: Change macros Min/Max for std::min/max Now all these usages were removed from LO. Change-Id:

[PATCH] fdo#57950: Chained appends in postgresql driver

2013-04-02 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3170 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/3170/1 fdo#57950: Chained appends in postgresql driver While studing the postgresql driver I found these chained

[PATCH] fod#57950: Removed some chained appends from sw

2013-03-10 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2643 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/2643/1 fod#57950: Removed some chained appends from sw Change-Id: I5b78b4a8f2fc0fb0c4a67042ac4924e375c2d63a --- M

[PATCH] Removed last RTL_CONST* macros from codemaker

2013-03-08 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2605 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/2605/1 Removed last RTL_CONST* macros from codemaker Also, change .equals fro == and drop a useless function.

[PATCH] fdo#57950: Remove chained appends in codemaker

2013-03-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2583 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/2583/1 fdo#57950: Remove chained appends in codemaker And another cleanups like removing RTL_CONST* macros and other

[PATCH] fdo#61513: Remove FSysFailOnErrorImpl macro

2013-03-03 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2535 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/2535/1 fdo#61513: Remove FSysFailOnErrorImpl macro This patch removes all used of this useless macro. Change-Id:

[PATCH] fdo#57950: Remove more chained appends in filter

2013-02-17 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2186 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/2186/1 fdo#57950: Remove more chained appends in filter And also sanitize some OUStringBuffer uses. Change-Id:

[PATCH] Remove not needed function in calc

2013-02-17 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2187 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2187/1 Remove not needed function in calc Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64 --- M

[PATCH] fdo#57950: Remove some chained appends in filter

2013-02-12 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2117 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/2117/1 fdo#57950: Remove some chained appends in filter Change-Id: I2386eb47ad7190d626966020e96c1a7ddc07ab4a --- M

Change in core[master]: Use a method from UnoApitest instead of implement a new one ...

2013-01-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1923 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1923/1 Use a method from UnoApitest instead of implement a new one in calc In calc, we see a lot of implementations of

Change in core[master]: Remove more STRINGPARAM macros form dbaccess

2013-01-26 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1878 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1878/1 Remove more STRINGPARAM macros form dbaccess Change-Id: I283ccd03dc811dda2f10963f400cd517f42ea7b3 --- M

[PATCH] Only call getScDocument when needed

2013-01-25 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1861 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/1861/1 Only call getScDocument when needed Change-Id: I2dca76af46e63b5dd833f5a60549d4b1a7b03d84 --- M

[PATCH] Remove some RTL_* macdros from connectivity and..

2013-01-19 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1767 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1767/1 Remove some RTL_* macdros from connectivity and.. ...also simplify a lot some functions calls. Change-Id:

[PATCH] fdo#57950: Remove some chained appends in connectivity and..

2013-01-19 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1768 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1768/1 fdo#57950: Remove some chained appends in connectivity and.. ... remove some RTL* macros. Change-Id:

[PATCH] Remove more STRINGPARAM macros from dbaccess

2013-01-19 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1771 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1771/1 Remove more STRINGPARAM macros from dbaccess Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8 --- M

[PATCH] Remove some unneeded variables in filter

2013-01-19 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1773 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1773/1 Remove some unneeded variables in filter Change-Id: Ia2963498a197a795155a42b2588f983019d89f35 --- M

[PATCH] fdo#57950: Remove chained appends in filter

2013-01-15 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1687 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/1687/1 fdo#57950: Remove chained appends in filter Also removed a lot of *STRINGPARAM macros. Change-Id:

[PATCH] fdo#57950: dbaccess: STRINGPARAM and more chained appends

2013-01-15 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1706 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/1706/1 fdo#57950: dbaccess: STRINGPARAM and more chained appends Change-Id: Iab1ba5eb6702d386e2775d7426c3398b606d2d97

[PATCH] Sanitize/simplify some parameters of functions in dbaccess

2013-01-15 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1707 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/1707/1 Sanitize/simplify some parameters of functions in dbaccess Some functions have parameters of OUString, so, we

[PATCH] fdo#57950: Remove some chained appends in shell

2013-01-14 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1682 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/1682/1 fdo#57950: Remove some chained appends in shell And remove some *STRINGPARAM macros. Change-Id:

fdo#57950: Remove chained appends in dbaccess

2013-01-11 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#57950: Remove chained appends in dbaccess .. Patch Set 1: Abandoned I will send this again rebased, and aiehtout any oatch that depends on this. -- To view, visit

fdo#57950: More chained appends in dbaccess

2013-01-11 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#57950: More chained appends in dbaccess .. Patch Set 4: Abandoned Will send again. -- To view, visit https://gerrit.libreoffice.org/1564 To unsubscribe, visit

[PATCH] fdo#57950: Remove chained appends in dbaccess

2013-01-08 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1604 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1604/1 fdo#57950: Remove chained appends in dbaccess Also remove some rtl:: prefixes. Change-Id:

[PATCH] fdo#57950: Remove some chained appends in dbaccess

2013-01-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1559 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1559/1 fdo#57950: Remove some chained appends in dbaccess Also simplify logic a little bit. Change-Id:

[PATCH] fdo#57950: More fixes for chained appends in dbaccess

2013-01-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1561 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/1561/1 fdo#57950: More fixes for chained appends in dbaccess And also: Remove some RTL_* macros Remove

[PATCH] fdo#57950: More chained appends in dbaccess

2013-01-07 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1564 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/1564/1 fdo#57950: More chained appends in dbaccess And more: Remove RTL_* macros Remove ::rtl prefix

[PATCH] fdo#57950: Remove last chained appends from avmedia

2013-01-05 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1548 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1548/1 fdo#57950: Remove last chained appends from avmedia Change-Id: I0906bf7493828c5923f3243c6849a2eca5f37bb0

[PATCH] fdo#57950: Remove some chained appends in chart2 and more

2013-01-05 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1549 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1549/1 fdo#57950: Remove some chained appends in chart2 and more Removed a not needed variable; Removed some rt::

[PATCH] Remove some RTL_* and some rtl:: prefixes in chart2

2013-01-05 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1550 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1550/1 Remove some RTL_* and some rtl:: prefixes in chart2 Change-Id: I47889319530d8f03bd7c78e937de55cf380d2d41

[PATCH] fdo#57950: Remove some chained appends and more in dbaccess

2013-01-05 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1552 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/1552/1 fdo#57950: Remove some chained appends and more in dbaccess - Sanitized some OUStringBuilder, avoiding

[PATCH] Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test...

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1512 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1512/1 Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test_scanner.cxx Change-Id:

[PATCH] Remove all occurences of RTL_* and ::rtl prefix from basic

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1513 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1513/1 Remove all occurences of RTL_* and ::rtl prefix from basic This is a big commit, so thanks for your time

[PATCH] fdo#57950: One more chained append in basic

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1516 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1516/1 fdo#57950: One more chained append in basic Change-Id: I179b5bfd1d85152a53bb821ab9eeb78efb8a6083 Signed-off-by:

[PATCH] fdo#57950: Fix some chained appends in basic

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1515 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1515/1 fdo#57950: Fix some chained appends in basic Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444

[PATCH] Remove some unused functions

2012-12-30 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1517 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1517/1 Remove some unused functions Change-Id: I618de5d34d891b1b183cca12b71aff4128b2f92e Signed-off-by: Marcos Paulo

[PATCH] Remove last RTL_CONSTASCII_* from accessibility

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1500 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/1500/1 Remove last RTL_CONSTASCII_* from accessibility Change-Id: Icb8f66c9f6ad70828aa55580a1f3aae8b2af1593

[PATCH] Remove last usage of RTL_CONSTASCII_STRINGPARAM in basctl

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1502 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/1502/1 Remove last usage of RTL_CONSTASCII_STRINGPARAM in basctl Change-Id: I5bc79699e794de47611d785b9ae48b4badf9f2f6

[PATCH] Remove last RTL_CONSTASCII_STRINGPARAM from animations

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1501 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1501/1 Remove last RTL_CONSTASCII_STRINGPARAM from animations Change-Id: Ib774bc7f70492910a2f3e7ac3088c4e07127b563

[PATCH] fdo#57950: Remove chained append and simplify strings

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1503 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1503/1 fdo#57950: Remove chained append and simplify strings No need to two strings here, since just destFolder is

[PATCH] Remove rtl prefixes and some RTL_CONST* from basic

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1504 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1504/1 Remove rtl prefixes and some RTL_CONST* from basic Change-Id: If15d7c97de5295ea7d7f341e6b34acbfc917218d

[PATCH] fdo#57950: remove consecutive append in basctl with StringBu...

2012-12-26 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1486 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/1486/1 fdo#57950: remove consecutive append in basctl with StringBuffer Change-Id:

It seems that readBiffData( BiffInputStream rStrm ) is ot u...

2012-12-19 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: It seems that readBiffData( BiffInputStream rStrm ) is ot used .. Patch Set 1: Abandoned Well, this is used... so abandon this patch. -- To view, visit

Remove unused method from oox: dump

2012-12-19 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove unused method from oox: dump .. Patch Set 2: Abandoned This is used for debug porpouses... So leave it as is =D -- To view, visit

Remove empty method from sc

2012-12-19 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: Remove empty method from sc .. Patch Set 1: Abandoned Will be used in the future -- To view, visit https://gerrit.libreoffice.org/1411 To unsubscribe, visit

[PATCH] Remove unused ScTabPopShell

2012-12-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1392 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/1392/1 Remove unused ScTabPopShell As Thomas Arnhold pointed, it seems that ScTabPopShell is useless. I did a full

[PATCH] Remove unused method from oox: dump

2012-12-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1409 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1409/1 Remove unused method from oox: dump Change-Id: Iba22e1dbfffb90ee9894fb753e5f57cd7e378548 Signed-off-by: Marcos

[PATCH] Remove unused method from sc: importBiffRecord

2012-12-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1410 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/1410/1 Remove unused method from sc: importBiffRecord As Thomas Arnhold pointed, these method eems to be useless.

[PATCH] Remove empty method from sc

2012-12-18 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1411 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1411/1 Remove empty method from sc These methods are emprt and are called by another file. I don't if this is a kind

  1   2   >