[PATCH] Fix icu version checks.

2013-06-03 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4139 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/4139/1 Fix icu version checks. commit 30c303 "Make charmap.cxx compile with icu >= 4.4." was incomplete and had wrong v

[PATCH] Make charmap.cxx compile with icu >= 4.4.

2013-05-30 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4112 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/4112/1 Make charmap.cxx compile with icu >= 4.4. configure.ac claims ICU >= 4.2 is supported. Make it so. Change-Id: I

[PATCH] propacc.cxx include limits.h for USHRT_MAX.

2013-05-30 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4111 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/4111/1 propacc.cxx include limits.h for USHRT_MAX. Don't depend on accidental definition depending on the version of bo

[PATCH] Source files shouldn't have executable bit set.

2013-05-28 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4070 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/4070/1 Source files shouldn't have executable bit set. Change-Id: Iafad6249a7998d7c749c1ca2979a606078cfcb5e --- M cli_u

[PATCH] Robustify and fix leak in NBOTypeMgrBase::ImplLoad().

2013-05-24 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4031 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/4031/1 Robustify and fix leak in NBOTypeMgrBase::ImplLoad(). The >>operator of SvStream doesn't initialize a variable i

[PATCH] Fix memory leak in DrawViewShell::GetAttrState().

2013-05-24 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4020 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/4020/1 Fix memory leak in DrawViewShell::GetAttrState(). DrawViewShell::GetAttrState() might create a temporary new Svx

[PATCH] Splitter::ImplInitHorVer(bool) should always initialize all ...

2013-05-22 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4007 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/4007/1 Splitter::ImplInitHorVer(bool) should always initialize all state. When creating a new Splitter ImplInitHorVer(b

[PATCH] valgrind: Initialize all of struct sockaddr_rc for binding A...

2013-05-21 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3998 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/3998/1 valgrind: Initialize all of struct sockaddr_rc for binding AF_BLUETOOTH. valgrind doesn't know that struct socka

[PATCH] Fix two SfxFilterMatcher_Impl memory leaks.

2013-05-21 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3989 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3989/1 Fix two SfxFilterMatcher_Impl memory leaks. First SfxFilterMatcher_Impl::InitForIterating() will set pList to ei

[PATCH] sal osl_getGlobalTimer: Don't confuse start and current time...

2013-05-20 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3979 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/3979/1 sal osl_getGlobalTimer: Don't confuse start and current time. Change-Id: I575dd70d6b80d4f3279476037e509550cfa23f

[PATCH] Fix memory leak in mapToFontConfigLangTag.

2013-05-19 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3967 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3967/1 Fix memory leak in mapToFontConfigLangTag. FcGetLangs() will return a new FCStrSet that needs to be freed after

[PATCH] valgrind support is useful independent from DBGUTIL support.

2013-05-19 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3966 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3966/1 valgrind support is useful independent from DBGUTIL support. Especially when valgrinding an optimized libreoffic

[PATCH] Require at least gio 2.26 for the dbus support.

2013-05-14 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3904 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/3904/1 Require at least gio 2.26 for the dbus support. Change-Id: I6276d55081098f567104f61fde896d1b66591522 --- M confi

[PATCH] Remove --disable-unix-qstart-libpng from distro-configs.

2013-05-14 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3900 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/3900/1 Remove --disable-unix-qstart-libpng from distro-configs. commit cc858aca0ebf653eebceaf09e2316763d8d81051 "config

[PATCH] datetime.cxx (ISO8601parseTime) ‘bFrac’ may be used uninitia...

2013-05-13 Thread Mark Wielaard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3885 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3885/1 datetime.cxx (ISO8601parseTime) ‘bFrac’ may be used uninitialized. gcc 4.4.7 warns about the above because getIS