[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-04-03 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/geometry/viewinformation2d.hxx |6 drawinglayer/source/geometry/viewinformation2d.cxx | 80 ++- 2 files changed, 20 insertions(+), 66 deletions(-) New commits: commit 0c85109e647ab1d1d8d87891b3bba23d90cd7e65 Author: Thomas Arnhold tho

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-04-03 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/geometry/viewinformation3d.hxx |6 drawinglayer/source/geometry/viewinformation3d.cxx | 80 ++- 2 files changed, 20 insertions(+), 66 deletions(-) New commits: commit 78bec2b6f40144277464a64a9851d1dc940ed336 Author: Thomas Arnhold tho

[Libreoffice-commits] core.git: basic/source vcl/aqua vcl/headless vcl/inc vcl/Library_vcl.mk vcl/Package_inc.mk vcl/source vcl/unx vcl/win

2013-04-03 Thread Thomas Arnhold
|8 +++ 18 files changed, 129 insertions(+) New commits: commit 47664d3f2e12649d324b031ca6ffd5589fe3d197 Author: Thomas Arnhold tho...@arnhold.org Date: Sat Mar 30 14:55:24 2013 +0100 fdo#58807 bring Beep() for basic back The functionality was removed by fdo#48549

[PATCH] fdo#58807 bring Beep() for basic back

2013-04-03 Thread Thomas Arnhold (via Code Review)
https://gerrit.libreoffice.org/3184 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I176dc5a18b8ceec467946f4544418f502880c611 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

[ABANDONED] fdo#58807 bring Beep() for basic back

2013-04-03 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fdo#58807 bring Beep() for basic back .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3184 To unsubscribe, visit https

[PATCH libreoffice-4-0] fdo#58807 bring Beep() for basic back

2013-04-03 Thread Thomas Arnhold (via Code Review)
Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: unit test failure in forms module, something do with com.sun.star.form.control.FixedText

2013-04-03 Thread Thomas Arnhold
Hi Noel, maybe this grepping for control\.FixedText helps you: stardiv.vcl.control.FixedText com.sun.star.form.control.FixedText So there is toolkit/source/helper/servicenames.cxx which uses szServiceName_UnoControlFixedText[] = stardiv.vcl.control.FixedText Maybe that wasn't converted in

[PUSHED libreoffice-4-0] Keep semantics, but improve readibility.

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3186 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3186 To unsubscribe

[PATCH] unotools: remove some unused items

2013-04-03 Thread Thomas Arnhold (via Code Review)
Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3179 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3179 To unsubscribe

[Libreoffice-commits] core.git: sc/source

2013-04-02 Thread Thomas Arnhold
sc/source/ui/drawfunc/chartsh.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 83810a61bab4fe079de3539dc3489b008e776eaf Author: Thomas Arnhold tho...@arnhold.org Date: Tue Apr 2 08:48:28 2013 +0200 fix build css is ::com::sun::star already

Re: reduce some uglyness

2013-04-02 Thread Thomas Arnhold
On 02.04.2013 11:51, Michael Stahl wrote: it's a mystery why it works on other compilers, because you have removed the header guard #define _SFXRNGITEM_HXX which causes multiple inclusion of the header to define the same types multiple times, which MSVC rightfully complains about. i grant that

[PATCH] Revert Revert reduce some uglyness

2013-04-02 Thread Thomas Arnhold (via Code Review)
: I27869be9c70e79a366a547ce061e71a3743f87da Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 3 commits - drawinglayer/inc drawinglayer/source

2013-04-02 Thread Thomas Arnhold
Author: Thomas Arnhold tho...@arnhold.org Date: Tue Apr 2 14:54:29 2013 +0200 fdo#62525: use cow_wrapper for MaterialAttribute3D Change-Id: I7ee65afe8065525e6af198a4d1b75e1035644983 diff --git a/drawinglayer/inc/drawinglayer/attribute/materialattribute3d.hxx b/drawinglayer/inc

[Libreoffice-commits] core.git: sal/inc vcl/unx

2013-04-02 Thread Thomas Arnhold
insertions(+), 53 deletions(-) New commits: commit 60212d610762c262782eaf79bfd1fa3798d8afa7 Author: Thomas Arnhold tho...@arnhold.org Date: Sat Mar 30 19:38:29 2013 +0100 vcl: convert some fprintf to SAL_INFO Change-Id: I4b9a20e62e8e137a1bfaa1c654307f15c33e3d3c Reviewed-on: https

[PUSHED] vcl: convert some fprintf to SAL_INFO

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3143 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3143 To unsubscribe

[ABANDONED] API CHANGE: drop rtl::O[U]StringBuffer::{charAt, setCharAt}

2013-04-02 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt} .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3155 To unsubscribe, visit https

[Libreoffice-commits] core.git: svl/inc svl/source

2013-04-02 Thread Thomas Arnhold
1416669670de6f93b40d8a2f8f001e92ec0bf101 Author: Thomas Arnhold tho...@arnhold.org Date: Tue Apr 2 14:21:42 2013 +0200 Revert Revert reduce some uglyness The header guard seems to solve the problem. This reverts commit df8c41cceeca27ae49e9fa6b5cd64c65c8feb218. Change-Id

[PATCH] Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges

2013-04-02 Thread Thomas Arnhold (via Code Review)
Hello LibreOffice gerrit bot, Luboš Luňák, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3139 to look at the new rebased patch set (#2). Change subject: Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges

[Libreoffice-commits] core.git: sfx2/source

2013-04-02 Thread Thomas Arnhold
sfx2/source/appl/app.hrc |1 - sfx2/source/appl/app.src |5 - sfx2/source/appl/appdata.cxx |1 - sfx2/source/inc/appdata.hxx |1 - 4 files changed, 8 deletions(-) New commits: commit e72072029ad22fdde8310e22667fd8f2f46db28e Author: Thomas Arnhold tho...@arnhold.org

[PATCH] Remove SvtInternalOptions

2013-04-02 Thread Thomas Arnhold (via Code Review)
, visit https://gerrit.libreoffice.org/3180 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I482719b0de9df0a77c2fef0bf25ae1fb68926375 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ (Part 3)

2013-04-01 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3144 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3144 To unsubscribe

[Libreoffice-commits] core.git: basctl/source reportdesign/inc reportdesign/source sc/inc sc/source

2013-04-01 Thread Thomas Arnhold
/drwlayer.cxx | 15 --- 6 files changed, 33 deletions(-) New commits: commit 08b91c63131b7e625d2a2c489bc537dafe5c5963 Author: Thomas Arnhold tho...@arnhold.org Date: Mon Apr 1 13:19:59 2013 +0200 remove unused GetCurDocViewWin Change-Id

unusedcode some step further

2013-04-01 Thread Thomas Arnhold
Hi, there are several unused methods in the source which callcatcher doesn't catch. Two examples: 08b91c63131b7e625d2a2c489bc537dafe5c5963 and c12ab867f282e783507fcf74ab5c90e784681f65 which had only (virtual) definitions, but no calls. The same applies to inlines like

[PATCH] API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt}

2013-04-01 Thread Thomas Arnhold (via Code Review)
://gerrit.libreoffice.org/3155 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ief3a418e2ab0039bdf5100ec6e1505a4887487e7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

[Libreoffice-commits] core.git: forms/source

2013-04-01 Thread Thomas Arnhold
forms/source/inc/frm_strings.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c893d404c6bb90990ea18db70f27647269a6369f Author: Thomas Arnhold tho...@arnhold.org Date: Mon Apr 1 22:48:35 2013 +0200 Revert Remove RTL_CONSTASCII_(U)STRINGPARAM in forms

[PUSHED] Multiple typo fixes, small code changes

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3135 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3135 To unsubscribe

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Thomas Arnhold
Hi Regina, you're right, the other methods are using the order (fVer, fHor), like createUnitSpherePolyPolygon() does. So the definition is correct: inline B3DPoint getPointFromCartesian(double fVer, double fHor) But on the call side it's used like: aNew.append(getPointFromCartesian(fHor,

[PUSHED] fdo#62096 Replace O(U)String compareTo with ==

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3136 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3136 To unsubscribe

[PUSHED] Remove commented code in component.cxx (odk)

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3137 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3137 To unsubscribe

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ PART2

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3129 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3129 To unsubscribe

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Thomas Arnhold
On 31.03.2013 15:49, Regina Henschel wrote: Draw a sphere from the set of predefined 3D-objects and set the line style to continues to see the segments. Set Segments Vertical to 8 to see, which part of the drawing is affected by Vertical. In Version 4.0.1.2 (Build ID:

[PUSHED] Remove commented code in odk/examples

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3138 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3138 To unsubscribe

[PATCH] vcl: convert some fprintf to SAL_INFO

2013-03-31 Thread Thomas Arnhold (via Code Review)
: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] [PATCH] vincent: fix the spell error: change unkown to unknown

2013-03-30 Thread Thomas Arnhold
Hello Vincent, they are already pushed on master. https://gerrit.libreoffice.org/#/c/3030/ http://cgit.freedesktop.org/libreoffice/core/commit/?id=002a0d91e4b0d8214656741192ec3260a8764a73 Thomas ___ LibreOffice mailing list

[PATCH] fdo#58807 bring Beep() for basic back

2013-03-30 Thread Thomas Arnhold (via Code Review)
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] drawinglayer depends on o3tl_inc

2013-03-30 Thread Thomas Arnhold (via Code Review)
https://gerrit.libreoffice.org/3125 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9dab86e62eb34819be1564b3d7be50cf6acb6f73 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

[Libreoffice-commits] core.git: connectivity/source dbaccess/source extensions/source oox/source sal/inc sc/source sdext/source stoc/source sw/source

2013-03-30 Thread Thomas Arnhold
commits: commit 083092e808ed94325f103a721cc11882c6878b06 Author: Thomas Arnhold tho...@arnhold.org Date: Sat Mar 30 04:57:16 2013 +0100 OSL_FAIL - SAL_WARN Change-Id: I1871e5e3a319b2d5177ae4bd470046c022c14eb7 Reviewed-on: https://gerrit.libreoffice.org/3121 Reviewed-by: David

[ABANDONED] drawinglayer depends on o3tl_inc

2013-03-30 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: drawinglayer depends on o3tl_inc .. Patch Set 1: Abandoned Not needed. Thanks David :) -- To view, visit https://gerrit.libreoffice.org/3125 To unsubscribe, visit

[Libreoffice-commits] core.git: cui/source fpicker/source unotools/source uui/source xmlsecurity/inc xmlsecurity/source

2013-03-29 Thread Thomas Arnhold
/warnings.cxx|2 - 19 files changed, 58 insertions(+), 98 deletions(-) New commits: commit 049ce78144650d92eb6bd73292868f73d37c9010 Author: Thomas Arnhold tho...@arnhold.org Date: Sat Mar 30 00:32:52 2013 +0100 remove local css definitions follow-up

[PATCH] OSL_FAIL - SAL_WARN

2013-03-29 Thread Thomas Arnhold (via Code Review)
://gerrit.libreoffice.org/3121 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1871e5e3a319b2d5177ae4bd470046c022c14eb7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ (Part1)

2013-03-29 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3101 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3101 To unsubscribe

[Libreoffice-commits] core.git: sw/source

2013-03-29 Thread Thomas Arnhold
sw/source/ui/utlui/content.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 6c541cb3168c103f3e13686232fa2e6084570182 Author: Thomas Arnhold tho...@arnhold.org Date: Sat Mar 30 05:21:08 2013 +0100 fix build Change-Id: Icb72b18785bb37457f2eaf86e0639cedc119ee92 diff

[PUSHED] String::AppendAscii cleanup in dbaccess

2013-03-28 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3068 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3068 To unsubscribe

[Libreoffice-commits] core.git: desktop/unx

2013-03-27 Thread Thomas Arnhold
desktop/unx/source/splashx.c | 12 1 file changed, 12 deletions(-) New commits: commit 71907bb06ae6fc3c0ea1485b6ed0efaed196a57a Author: Thomas Arnhold tho...@arnhold.org Date: Wed Mar 27 11:49:40 2013 +0100 -Wunused-macros Change-Id

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-03-27 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/attribute/fillhatchattribute.hxx |6 drawinglayer/source/attribute/fillhatchattribute.cxx | 85 ++ 2 files changed, 27 insertions(+), 64 deletions(-) New commits: commit 63da9d632827e7d08450dfd72bdcdfbed9c73cae Author: Thomas Arnhold tho

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-03-27 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/attribute/fontattribute.hxx |6 drawinglayer/source/attribute/fontattribute.cxx | 89 -- 2 files changed, 32 insertions(+), 63 deletions(-) New commits: commit 32ec7666596b2a0f27c72f9d856e2ec0f0545f6b Author: Thomas Arnhold tho

[PUSHED] Cleanup comments and some translations in style.cxx

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3062 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3062 To unsubscribe

[Libreoffice-commits] core.git: connectivity/source cppuhelper/inc dbaccess/inc embedserv/source filter/source fpicker/source framework/inc idlc/source lotuswordpro/source rsc/inc rsc/source sal/inc s

2013-03-26 Thread Thomas Arnhold
488e6875e992e11601611a119476624822fc4635 Author: Thomas Arnhold tho...@arnhold.org Date: Mon Mar 25 19:56:20 2013 +0100 remove external include guards Change-Id: If5758e02baa8e019923355b6c97043b306223fdd diff --git a/connectivity/source/inc/hsqldb/HConnection.hxx b/connectivity/source/inc/hsqldb

[PUSHED] Translate German comments, fix some ws

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3063 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3063 To unsubscribe

[PUSHED] fdo#39468 Translate German comments - vcl/source/control/

2013-03-26 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2966 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2966 To unsubscribe

[Libreoffice-commits] core.git: editeng/source sc/source sw/source vcl/source xmloff/source

2013-03-26 Thread Thomas Arnhold
/text/txtflde.cxx | 12 12 files changed, 112 deletions(-) New commits: commit 646daee253b69404591c006ec6e717b6660af30b Author: Thomas Arnhold tho...@arnhold.org Date: Wed Mar 27 02:57:35 2013 +0100 kill some unused inlines Change-Id

[PATCH] fdo#62525: use cow_wrapper for FontAttribute

2013-03-26 Thread Thomas Arnhold (via Code Review)
: Ic07da7c7cf225a910e6f0fa4f6d20c4700e7ec7a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#62525: use cow_wrapper for FillHatchAttribute

2013-03-26 Thread Thomas Arnhold (via Code Review)
: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sd/source sw/source

2013-03-25 Thread Thomas Arnhold
Author: Thomas Arnhold tho...@arnhold.org Date: Mon Mar 25 08:58:06 2013 +0100 random src cleaning Change-Id: I9b246beee646ce1dd68e916ac7fcda138cc9e6f9 diff --git a/sd/source/ui/animations/CustomAnimationDialog.src b/sd/source/ui/animations/CustomAnimationDialog.src index b07f147

[PUSHED] Translate German comments, fix some whitespace

2013-03-25 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2916 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2916 To unsubscribe

Re: [PATCH] vincent: fix the spell error: change unkown to unknown

2013-03-25 Thread Thomas Arnhold
Hi Vincent, I uploaded the patch to gerrit, so it gets more attention ;) https://gerrit.libreoffice.org/#/c/3030/ This Get_UnknownTags() method was unused all over the way, so I removed it. Here's an introduction on gerrit and how to use it:

[PATCH] Fix spelling errors and typos: 'unkown' change to 'unknown'

2013-03-25 Thread Thomas Arnhold (via Code Review)
-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: basic/source

2013-03-24 Thread Thomas Arnhold
basic/source/runtime/methods.cxx |7 --- basic/source/runtime/rtlproto.hxx |1 - basic/source/runtime/stdobj.cxx |2 -- 3 files changed, 10 deletions(-) New commits: commit 7f4a34e3145673681c0ff3aee8de8c440e790ece Author: Thomas Arnhold tho...@arnhold.org Date: Thu Mar 21 19

[ABANDONED] [draft] use pragma once

2013-03-24 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: [draft] use pragma once .. Patch Set 3: Abandoned Not as easy as it seems. Clashes with Windows headers at least. Why ever... -- To view, visit https

[PUSHED] General comment cleanup for demo/test vcl apps

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2921 Approvals: Tor Lillqvist: Verified; Looks good to me, approved Thomas Arnhold: -- To view, visit https://gerrit.libreoffice.org/2921

[PUSHED] Improve size and positions of widgets for CustomAnimationDia...

2013-03-23 Thread Thomas Arnhold (via Code Review)
: merged Gerrit-Change-Id: I38a9cbd533c742657c4af6c83d146706684c1ff6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Xiaoli Duan duan19002...@gmail.com Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list

[PUSHED] fdo#39468 Translate German comments - vcl/win/source/app

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2938 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2938 To unsubscribe

[PATCH] wip

2013-03-23 Thread Thomas Arnhold (via Code Review)
://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I23427e1e3bfb583ef10123577ebec76af617f917 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing

[PATCH] fdo#62525: use cow_wrapper for SdrShadowAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
-- To view, visit https://gerrit.libreoffice.org/2945 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2713bacd10538dfe177cb975a9633dd65285c6fa Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho

[ABANDONED] wip

2013-03-23 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: wip .. Patch Set 1: Abandoned ... -- To view, visit https://gerrit.libreoffice.org/2944 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit

[PATCH] fdo#62525: use cow_wrapper for SdrShadowAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
-- To view, visit https://gerrit.libreoffice.org/2946 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b5435d2326e9ebf340e88025eeea25ff6388ea2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho

[ABANDONED] fdo#62525: use cow_wrapper for SdrShadowAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fdo#62525: use cow_wrapper for SdrShadowAttribute .. Patch Set 1: Abandoned bla -- To view, visit https://gerrit.libreoffice.org/2945 To unsubscribe, visit https

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-03-23 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/attribute/sdrshadowattribute.hxx |6 drawinglayer/source/attribute/sdrshadowattribute.cxx | 81 ++ 2 files changed, 25 insertions(+), 62 deletions(-) New commits: commit 62fca307fc0fc775234572c79a1237494c2d72a7 Author: Thomas Arnhold tho

[PATCH] fdo#62525: use cow_wrapper for FillBitmapAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f666d4baaf6dc4e9f7ea30a518a8904f01d749f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-03-23 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/attribute/fillbitmapattribute.hxx |6 drawinglayer/source/attribute/fillbitmapattribute.cxx | 80 ++ 2 files changed, 24 insertions(+), 62 deletions(-) New commits: commit cafc879f8978ea9f7fca1be9f6aa5057f0a59617 Author: Thomas Arnhold tho

[PATCH] fdo#62525: use cow_wrapper for FillGradientAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change duplicate short-cut Alt-I-U

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2943 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2943 To unsubscribe

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

2013-03-23 Thread Thomas Arnhold
drawinglayer/inc/drawinglayer/attribute/fillgradientattribute.hxx |6 drawinglayer/source/attribute/fillgradientattribute.cxx | 89 ++ 2 files changed, 30 insertions(+), 65 deletions(-) New commits: commit 75ad992d1801334a2bb39e1b0bdf3ca5f3714625 Author: Thomas Arnhold

[PATCH] fdo#62525: use cow_wrapper for FillGradientAttribute

2013-03-23 Thread Thomas Arnhold (via Code Review)
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#39468 Translate German Comments - salframe.cxx

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2931 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2931 To unsubscribe

[PUSHED] fdo#39468 Translate German comments - vcl/win/source/gdi/

2013-03-23 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2937 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2937 To unsubscribe

[Libreoffice-commits] core.git: officecfg/registry

2013-03-22 Thread Thomas Arnhold
/WriterReportWindowState.xcu | 37 -- officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu | 37 -- 8 files changed, 162 deletions(-) New commits: commit 0e49bd05eef97ddd25a5657cdd5fb277a2a86014 Author: Thomas Arnhold tho...@arnhold.org Date: Fri Mar 22 03

[Libreoffice-commits] core.git: oox/source sal/inc tools/source vcl/source

2013-03-22 Thread Thomas Arnhold
: commit 5ea8a48a3b26ac326ea5fe4a637a2d9b59cd2b94 Author: Thomas Arnhold tho...@arnhold.org Date: Thu Mar 21 10:19:50 2013 +0100 clean up DBG_ERRORn Those were DBG_ERRORn before and were falsely changed to OSL_TRACE by me. See: 1707a350af8a0909ae88c2b11deb714f8b2a93ff

[PATCH] basic: Remove non working AboutStarBasic

2013-03-21 Thread Thomas Arnhold (via Code Review)
: Ia46674f7bdc12e80d61a8142697e875f5c58f482 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] clean up DBG_ERRORn

2013-03-21 Thread Thomas Arnhold (via Code Review)
-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Thomas Arnhold
On 21.03.2013 15:06, Michael Meeks wrote: So I'd say that these huge spews of ascii-art don't serve a useful purpose: //- and bulky content-free comments (which we still have plenty of) should clearly take be a higher priority

[Libreoffice-commits] core.git: Repository.mk

2013-03-21 Thread Thomas Arnhold
Repository.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 211a9a9cdcc34316e40c893179d7d3d0c160cfe4 Author: Thomas Arnhold tho...@arnhold.org Date: Thu Mar 21 19:46:23 2013 +0100 rscdep is dead 18d37cf9fb21dd809ec79135ce93f9a55512c9b3 Change-Id

[Libreoffice-commits] core.git: sfx2/source svx/source

2013-03-21 Thread Thomas Arnhold
sfx2/source/appl/newhelp.cxx | 10 +- svx/source/table/tablecontroller.cxx |4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 3dd40efee6ca280ef205c75517621b5f8d5089cd Author: Thomas Arnhold tho...@arnhold.org Date: Fri Mar 22 00:48:24 2013 +0100

[PUSHED] Comment translation GER-ENG in sw/source/ui/wrtsh/

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2902 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2902 To unsubscribe

[PUSHED] Comment translation - GER-ENG in sw/source/ui/wrtsh/wrtsh1.c...

2013-03-21 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2883 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2883 To unsubscribe

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Thomas Arnhold
Yes, but our internal RSC doesn't support #pragma once ;) On 19.03.2013 07:53, vincent wrote: HI, I found some wiki about #pragma once compiler support http://en.wikipedia.org/wiki/Pragma_once#Portability http://en.wikipedia.org/wiki/Pragma_once#Portability Compiler#pragma once Clang

Re: [SCRIPT] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-20 Thread Thomas Arnhold
On 20.03.2013 12:09, Stephan Bergmann wrote: On 03/19/2013 07:38 PM, Thomas Arnhold wrote: #!/usr/bin/perl # git grep 'RTL_CONSTASCII_USTRINGPARAM' -- '*.[hc]xx' | cut -d':' -f1 | sort -u | xargs perl constascii.pl foreach (@ARGV) { my $file = $_; my $data = ; my $fh; open

[Libreoffice-commits] core.git: extensions/source ucb/source

2013-03-20 Thread Thomas Arnhold
extensions/source/update/ui/updatecheckui.cxx |2 +- ucb/source/ucp/webdav/DAVProperties.cxx | 20 +++- 2 files changed, 8 insertions(+), 14 deletions(-) New commits: commit 11878c68c6e22373c95d4b7707aaf2c91e6a1fa1 Author: Thomas Arnhold tho...@arnhold.org Date: Wed

[Libreoffice-commits] core.git: connectivity/source

2013-03-20 Thread Thomas Arnhold
3c5b0853944d922e70d7c488712df6780ff2b5f7 Author: Thomas Arnhold tho...@arnhold.org Date: Wed Mar 20 13:29:22 2013 +0100 no need for include guard value Change-Id: Ib12b2c975d90cf842381916f3eb98dad3b4b3b4d diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSInit.hxx b/connectivity

[PATCH] this looks better

2013-03-20 Thread Thomas Arnhold (via Code Review)
: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: #ifdef vs #if for feature checks [proof of concept]

2013-03-20 Thread Thomas Arnhold
Hi, https://gerrit.libreoffice.org/#/c/2875/ At least on Linux with --without-java --enable-werror works for me. I only replaced guards like *_HXX_, *_HXX__ and *_HXX_INCLUDED which are not used at any other place. Those are ~8700 matches. Approx. 500 look like guards, but don't match the

[PUSHED] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2832 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2832 To unsubscribe

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Thomas Arnhold
On 19.03.2013 00:02, Norbert Thiebaud wrote: On Mon, Mar 18, 2013 at 11:17 AM, Lubos Lunak l.lu...@suse.cz wrote: On Monday 18 of March 2013, Tor Lillqvist wrote: Sounds great to me too; though of course I'd prefer to keep the diff smaller and not replace all the header guards: #ifndef

Re: [PATCH] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Thomas Arnhold
, explicit OUString is necessary only with return and ? such as return OUString(bla bla bla); and aOUString = bCond ? OUString(String_true) : OUString(String_false); Olivier Em 19-03-2013 05:26, Thomas Arnhold (via Code Review) escreveu: Hi, I have submitted a patch for review: https

[PATCH] removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold tho...@arnhold.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings ...

2013-03-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2835 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2835 To unsubscribe

[Libreoffice-commits] core.git: basctl/source basic/qa canvas/source dbaccess/source desktop/source desktop/unx extensions/source filter/source i18npool/source idlc/source io/source io/test odk/exampl

2013-03-19 Thread Thomas Arnhold
/qa/cppunittests/odiapi/testProperty.cxx |2 - writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 - 46 files changed, 94 insertions(+), 101 deletions(-) New commits: commit 5bb4a2ba1d8a6b98720868786e552aa8fd2a22eb Author: Thomas Arnhold tho

[SCRIPT] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

2013-03-19 Thread Thomas Arnhold
Hi, if someone has problems while rebasing due to this huge change, please use the attached script to do my change on your branch. Thomas On 19.03.2013 10:00, Thomas Arnhold (via Code Review) wrote: Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested

[Libreoffice-commits] core.git: cppuhelper/inc

2013-03-19 Thread Thomas Arnhold
cppuhelper/inc/cppuhelper/propertysetmixin.hxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 5e2fd3b3c96362368a516f59555a42450126be85 Author: Thomas Arnhold tho...@arnhold.org Date: Wed Mar 20 03:29:03 2013 +0100 this should be enough Change-Id

<    2   3   4   5   6   7   8   9   10   11   >