Re: 'make check' fails when building with gcov code coverage

2022-06-01 Thread Miklos Vajna
Hi Maarten, On Tue, May 31, 2022 at 01:30:58PM +0200, Maarten Hoes wrote: > As for checking if skia gets built with gcc instead of skipped when clang > is not available, what would be the best way to verify that ? I guess that > after the build a 'libskia.so' or something should be present ? I h

Re: 'make check' fails when building with gcov code coverage

2022-06-01 Thread Maarten Hoes
On Wed, Jun 1, 2022 at 5:22 PM Stephan Bergmann wrote: > > I agree with you that the status quo would not be useful (and don't > think you are annoying in any way). > > I still strongly (but naively, without digging into the code in any way) > assume that those tests are not failing for you all t

Re: 'make check' fails when building with gcov code coverage

2022-06-01 Thread Stephan Bergmann
On 01/06/2022 16:57, Maarten Hoes wrote: Ok, so let me see if I understood that correctly : *if* lcov reports were to be generated automatically on a regular basis again, then the desired behaviour would be to just let the build fail/stop (whatever the reason, gcov related, spuriously failure,

Re: 'make check' fails when building with gcov code coverage

2022-06-01 Thread Maarten Hoes
Hi, On Tue, May 31, 2022 at 2:07 PM Stephan Bergmann wrote: > So the general advice would be to ignore occasional failed builds (which > might not only fail due to spurious test failures, but also because e.g. > a build breaker got submitted by accident). If some specific tests > cause enough b

Re: 'make check' fails when building with gcov code coverage

2022-05-31 Thread Stephan Bergmann
On 31/05/2022 13:43, Maarten Hoes wrote: Anyway, if more tests fail sometimes without there being a 'real' failure, then I am not sure how to deal with that in relation to generating an lcov report for a full build. My initial idea was to not generate a report if 'make check' failed, but hearin

Re: 'make check' fails when building with gcov code coverage

2022-05-31 Thread Maarten Hoes
Hi, On Mon, May 30, 2022 at 10:03 AM Stephan Bergmann wrote: > On 25/05/2022 14:38, Maarten Hoes wrote: > > gb_GCOV=YES verbose=t make UITest_solver > > gb_GCOV=YES verbose=t make CppunitTest_sccomp_solver > > gb_GCOV=YES verbose=t make CppunitTest_sccomp_swarmsolvertest > > I /think/ to rememb

Re: 'make check' fails when building with gcov code coverage

2022-05-31 Thread Maarten Hoes
Hi Miklos, I totally agree that ideally, if the 'right' way to set these flags for this build system is setting 'gb_GCOV=YES' on the make commandline, then this should be fixed. However, I have no knowledge of this particular build system or makefiles in general, so I am unable to fix that myself

Re: 'make check' fails when building with gcov code coverage

2022-05-30 Thread Miklos Vajna
Hi Maarten, On Fri, May 27, 2022 at 10:26:21AM +0200, Maarten Hoes wrote: > CFLAGS='-fprofile-arcs -ftest-coverage' CXXFLAGS='-fprofile-arcs > -ftest-coverage' LDFLAGS='-fprofile-arcs -lgcov' ./autogen.sh > --enable-python=internal --without-system-libs --without-system-headers > gb_GCOV=YES ver

Re: 'make check' fails when building with gcov code coverage

2022-05-30 Thread Stephan Bergmann
On 25/05/2022 14:38, Maarten Hoes wrote: gb_GCOV=YES verbose=t make UITest_solver gb_GCOV=YES verbose=t make CppunitTest_sccomp_solver gb_GCOV=YES verbose=t make CppunitTest_sccomp_swarmsolvertest I /think/ to remember that at least some of those solver tests are time based, so that they may o

Re: 'make check' fails when building with gcov code coverage

2022-05-27 Thread Maarten Hoes
On Fri, May 27, 2022 at 8:13 AM Miklos Vajna wrote: > Hi Maarten, > > On Wed, May 25, 2022 at 02:38:27PM +0200, Maarten Hoes < > hoes.maar...@gmail.com> wrote: > > I've been trying to run 'make check' in combination with building > > LibreOffice with gcov code coverage, and get failures for the f

Re: 'make check' fails when building with gcov code coverage

2022-05-26 Thread Miklos Vajna
Hi Maarten, On Wed, May 25, 2022 at 02:38:27PM +0200, Maarten Hoes wrote: > I've been trying to run 'make check' in combination with building > LibreOffice with gcov code coverage, and get failures for the following > tests : > > > gb_GCOV=YES verbose=t make UITest_solver > gb_GCOV=YES verbose

'make check' fails when building with gcov code coverage

2022-05-25 Thread Maarten Hoes
Hi, I've been trying to run 'make check' in combination with building LibreOffice with gcov code coverage, and get failures for the following tests : gb_GCOV=YES verbose=t make UITest_solver gb_GCOV=YES verbose=t make CppunitTest_sccomp_solver gb_GCOV=YES verbose=t make CppunitTest_sccomp_swarm