[Bug 39631] add optimisation helpers

https://bugs.documentfoundation.org/show_bug.cgi?id=39631 Michael Stahl changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 39631] add optimisation helpers

https://bugs.documentfoundation.org/show_bug.cgi?id=39631 --- Comment #13 from Commit Notification --- Sheikha AL-Hinai committed a patch related to this issue. It has been pushed to "master":

[Bug 39631] add optimisation helpers

https://bugs.documentfoundation.org/show_bug.cgi?id=39631 Commit Notification changed: What|Removed |Added Whiteboard|

[Bug 39631] add optimisation helpers

https://bugs.documentfoundation.org/show_bug.cgi?id=39631 --- Comment #14 from Commit Notification --- Michael Meeks committed a patch related to this issue. It has been pushed to "master":

[Bug 39631] add optimisation helpers

https://bugs.documentfoundation.org/show_bug.cgi?id=39631 --- Comment #11 from sheikha --- I add SAL_LIKELY, SAL_UNLIKELY ,SAL_HOT, SAL_COLD pair of macro in sal/types.h , before that I add _SAL_BOOLEAN_EXPR which is an alternative way of using __builtin_expect which is

[Bug 39631] add optimisation helpers

https://bugs.documentfoundation.org/show_bug.cgi?id=39631 --- Comment #12 from jan iversen --- you point at the ci build job not the patch. the patch is https://gerrit.libreoffice.org/#/c/21070 I have added it to my review list. -- You are receiving this mail

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #8 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #7) I just dug throught he commit log for glib =) I'd be inclined to simply re-use G_LIKELY and G_UNLIKELY with a SAL prefix myself. That _G_BOOLEAN_EXPR trick

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #9 from Michael Meeks michael.me...@collabora.com --- As you like; we have less and less C these days I guess, and IIRC we compile it as C++ (?) =) -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #6 from Stephan Bergmann sberg...@redhat.com --- also note that GCC __builtin_expect (with its first parameter being of type long) is plain, simple, and generally does not work as one would naively hope: class C { private:

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #7 from Michael Meeks michael.me...@collabora.com --- I guess it might be worth talking to the glib developers; gmacros.h has a reasonably workable version - however the _G_BOOLEAN_EXPR stuff is not the ultimate in beauty =) The

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC|

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #3 from Kohei Yoshida libreoff...@kohei.us --- That header sal/inc/sal/macros.h these days lives in include/sal/macros.h. BTW, there never was sal/inc/sal/macros.hxx. It was always sal/inc/sal/macros.h. -- You are receiving this

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 Michal Strnad high...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |high...@gmail.com

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #4 from Michal Strnad high...@gmail.com --- I am working on this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list

[Libreoffice-bugs] [Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #3 from Kohei Yoshida libreoff...@kohei.us --- That header sal/inc/sal/macros.h these days lives in include/sal/macros.h. BTW, there never was sal/inc/sal/macros.hxx. It was always sal/inc/sal/macros.h. -- You are receiving this

[Libreoffice-bugs] [Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 Michal Strnad high...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |high...@gmail.com

[Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 39631] add optimisation helpers

https://bugs.freedesktop.org/show_bug.cgi?id=39631 Florian Reisinger reisi...@gmail.com changed: What|Removed |Added Summary|[EasyHack] add optimisation |add optimisation