[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.documentfoundation.org/show_bug.cgi?id=63154 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.documentfoundation.org/show_bug.cgi?id=63154 Michael Stahl changed: What|Removed |Added Status|NEW |RESOLVED

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.documentfoundation.org/show_bug.cgi?id=63154 Commit Notification changed: What|Removed |Added Whiteboard|target:4.1.0

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.documentfoundation.org/show_bug.cgi?id=63154 --- Comment #76 from Commit Notification --- ekuiitr committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.documentfoundation.org/show_bug.cgi?id=63154 jan iversen changed: What|Removed |Added Status|ASSIGNED|NEW

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.documentfoundation.org/show_bug.cgi?id=63154 jan iversen changed: What|Removed |Added CC|libreoffice@lists.freedeskt

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #69 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #67 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #68 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #66 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #63 from Michael Stahl mst...@redhat.com --- (In reply to comment #62) Can I get this patch and correct to reapply the changes I've made? Or I need to create a new patch? something like git revert

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #64 from Alexandre Vicenzi vicenzi.alexan...@gmail.com --- Thanks Michael. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #65 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #61 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #55 from Stephan Bergmann sberg...@redhat.com --- I just notice that this clean-up involves changing occurrences of sal_uLong to sal_uIntPtr, and I doubt that is a good idea. The sal_uLong typedef was originally introduced to do a

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #56 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Stahl committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #57 from Alexandre Vicenzi vicenzi.alexan...@gmail.com --- (In reply to comment #55) I just notice that this clean-up involves changing occurrences of sal_uLong to sal_uIntPtr, and I doubt that is a good idea. The sal_uLong

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #58 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #57) I understand your point of view, and probably it's the best idea. It's wrong to put sal_uLong definition in sal/types.h? Yes, that's wrong. sal_uLong is a

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #59 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #60 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #54 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #6) not sure who had the crazy idea of hard-coding lo into dozens of library loading calls... but clearly that silly lo suffix serves no useful purpose and we

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #53 from Alexandre Vicenzi vicenzi.alexan...@gmail.com --- Hi, Any idea of where to put SVLIBRARY, or it can't be touched yet? -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #52 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #51 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #49 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #50 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #48 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #39 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #40 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #41 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #42 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #43 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #45 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #44 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #46 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #47 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #38 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #35 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Alexandre Vicenzi committed a patch related to this issue. It has been pushed to master:

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #36 from Marcos Souza marcos.souza@gmail.com --- Hi guys, I saw OSL_NETWORD, but it seems to bu unused inside the code. I'm missing something? Can you guys give an example of how to use this...? Thanks a lot since now! -- You

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #37 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #36) I saw OSL_NETWORD, but it seems to bu unused inside the code. I'm missing something? Is part of the published URE API, so even if it is unused in LO

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #33 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #32) clearly any usage of DELETEZ of a member in a destructor is bogus even that need not be true in general -- You are receiving this mail because: You are

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #31 from Marcos Souza marcos.souza@gmail.com --- Can I removed finally the DELETEZ macro too? -- You are receiving this mail because: You are on the CC list for the bug. ___

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #32 from Michael Meeks michael.me...@collabora.com --- There are 600 or so hits of DELETEZ, in each case we'd need to work out whether the memory could be re-used inadvertently and I guess add a manual NULL as/when we think it could

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 Qubit qu...@runcibility.com changed: What|Removed |Added Whiteboard|EasyHack,DifficultyBeginner |EasyHack DifficultyBeginner

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 Thomas Arnhold tho...@arnhold.org changed: What|Removed |Added Attachment #78815|0 |1 is

[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 himanshu hcrobo...@gmail.com changed: What|Removed |Added Assignee|marcos.souza@gmail.com

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #21 from Tor Lillqvist tlillqv...@suse.com --- himanshu, please, we don't need two people working on the same thing. (And this is a too trivial task to count as experience for GSoC anyway.) -- You are receiving this mail because:

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 David Tardon dtar...@redhat.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #4 from Marcos Souza marcos.souza@gmail.com --- Thanks for the tips Stephan! I look at this when my patch about std::max get checked by the build checks. Maybe Windows build could broke with this commit. That patch is big, so I

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #3 from Stephan Bergmann sberg...@redhat.com --- SVLIBRARY should not go into a URE header, as it codifies non-URE knowledge---namely, that some LO libraries carry a lo in their name. The best solution appears to be to keep this in a

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #2 from Marcos Souza marcos.souza@gmail.com --- Guys, and about this: #define STRING_CONCAT3( s1, s2, s3 ) \ s1 s2 s3 // dll file extensions #if defined WNT #define SVLIBRARY( Base ) \ STRING_CONCAT3( Base, lo, .dll )

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 Michael Meeks michael.me...@novell.com changed: What|Removed |Added Whiteboard|

[Libreoffice-bugs] [Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154 Michael Meeks michael.me...@novell.com changed: What|Removed |Added CC|