Re: [GBUILD] Can we get rid of recursively invoking custom targets ?

2012-04-09 Thread Matúš Kukan
On 20 March 2012 11:17, Michael Stahl mst...@redhat.com wrote: i think nobody really likes the way custom targets are currently implemented, and iirc Bjoern even denies being responsible for the design :) So - I re-implemented them. Hopefully it's now better and I did not break too much along

Re: [GBUILD] Can we get rid of recursively invoking custom targets ?

2012-03-24 Thread Matúš Kukan
On 20 March 2012 21:04, Matúš Kukan matus.ku...@gmail.com wrote: On 20 March 2012 11:17, Michael Stahl mst...@redhat.com wrote: but please rename the CDPI variable to packimages_CDPI or expand it (also, CUSTOM_images, CUSTOM_PREFERRED_FALLBACK_[12]) CDPI was supposed to be

Re: [GBUILD] Can we get rid of recursively invoking custom targets ?

2012-03-24 Thread Norbert Thiebaud
On Sat, Mar 24, 2012 at 5:00 PM, Matúš Kukan matus.ku...@gmail.com wrote: On 20 March 2012 21:04, Matúš Kukan matus.ku...@gmail.com wrote: On 20 March 2012 11:17, Michael Stahl mst...@redhat.com wrote: but please rename the CDPI variable to packimages_CDPI or expand it (also, CUSTOM_images,

Re: [GBUILD] Can we get rid of recursively invoking custom targets ?

2012-03-20 Thread Michael Stahl
On 16/03/12 15:47, Matúš Kukan wrote: Hi, I'd like to propose removing gbuild_simple.mk over time. Surely there will be more custom targets as gbuild is growing and I can't see why we would need gbuild_simple. Instead we can write rules to Package_foo.mk makefiles or if that would be

Re: [GBUILD] Can we get rid of recursively invoking custom targets ?

2012-03-20 Thread Matúš Kukan
On 20 March 2012 11:17, Michael Stahl mst...@redhat.com wrote: 1. var namespace collisions:   because make doesn't have namespaces for global variables, it's   possible that variables defined in different modules' custom   makefiles have the same name and thus collide.   this can be avoided