Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-05 Thread Stephan Bergmann
I have zero insight into that area of the code, but from what I gather: GrammarCheckingIterator::GetSuggestedEndOfSentence(rText, ...) -- where rText apparently is one single paragraph -- used to be convoluted code that always returns rText.getLength() for the last few years, whether that chan

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-05 Thread Marcin Milkowski
b5de20926bb25a6b298b4e5dffb66eb2 and LO4 > > > > Yes, we can assume that was the original programmer intent. > > But it worked another way for 3 years and nobody complained about it. :) > > I prefer the unintended behavior, as LO does not assume wrongly what is > the >

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-04 Thread Németh László
> > So what LO will do? > > Olivier > > > > -- > View this message in context: > http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639p4041580.html > Sent from the Dev mailing list archive at Nabble.com. > ___

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-04 Thread Olivier R.
ew this message in context: http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639p4041580.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.fr

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-04 Thread Caolán McNamara
On Sat, 2013-03-02 at 04:09 -0800, Olivier R. wrote: > I bibisected from scratch again, on Linux Mint. I got no crash at all. Looking at the log, (but without testing anything myself) the likely relevant changes are... c0f865c9b5a34b272c9e0b22d18969554265914a on linguistic/source/gciterator.cxx w

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-02 Thread Olivier R.
foundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639p4041086.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-01 Thread Lubos Lunak
On Thursday 28 of February 2013, Olivier R. wrote: > Stephan Bergmann-2 wrote > > > How exactly do you launch LO? If by calling install/program/soffice.bin > > instead of install/program/soffice then the behavior is expected > > (soffice starts and controls soffice.bin, which needs to re-start on

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-27 Thread Olivier R.
ng unequal if 1 == os.access( encfile( path ), os.F_OK) and not path in sys.path: And LO starts. Olivier -- View this message in context: http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639p4040599.html Sent fr

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-27 Thread Stephan Bergmann
On 02/27/2013 06:58 PM, Olivier R. wrote: But I have to say that I am not really sure this result can be trusted. For each times I bibisect, LO didn't launch at the first try, only on the second try. How exactly do you launch LO? If by calling install/program/soffice.bin instead of install/pr

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-27 Thread Olivier R.
at means the paragraph has been split as explained in my previous messages. Direct link to download the French grammar checker: http://www.dicollecte.org/download/fr/Grammalecte-v0.2.5.oxt Regards, Olivier -- View this message in context: http://nabble.documentfoundation.org/Grammar-checker-Undocum

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-26 Thread Caolán McNamara
On Sat, 2013-02-23 at 13:19 -0800, Olivier R. wrote: > Hello Caolan, > > > Caolán McNamara wrote > > No idea, IMO it would be worth bibisecting this to find where it changed > > to re-examine if it was intentional or not. Would then likely be a good > > candidate for a unit test to lock in whiche

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-23 Thread Olivier R.
pl_en.name g_ImplementationHelper = unohelper.ImplementationHelper() g_ImplementationHelper.addImplementation( Lightproof, \ "org.libreoffice.comp.pyuno.Lightproof." + pkg, ("com.sun.star.linguistic2.Proofreader",),) g_ImplementationHelper.addI

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-22 Thread Caolán McNamara
On Sun, 2013-01-20 at 08:25 -0800, Olivier R. wrote: > With LibreOffice 4, each paragraph of a text is passed several times to this > function in the parameter aText, and the parameters nStartOfSentencePosition > and nSuggestedBehindEndOfSentencePosition are the beginning and the end of > each sent

[Grammar checker] Undocumented change in the API for LO 4

2013-01-20 Thread Olivier R.
to parse texts was better than the new one, as it’s up to each grammar checker to decide what to do with the paragraph, how to split it if necessary, etc. Regards, Olivier R. -- View this message in context: http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API