Re: [Libreoffice] [LibreOffice][PATCH] Fixes Compiler Warning

2010-10-18 Thread Caolán McNamara
On Sat, 2010-10-16 at 00:11 +0200, Kenneth Venken wrote: > because sequence checking should only be turned on for certain languages > like Thai, Laotian, Khmer or Vietnamese and only when CTL is enabled. > So, if CTL support is checked, we only need to check for sequence > checking if: previously

Re: [Libreoffice] [LibreOffice][PATCH] Fixes Compiler Warning

2010-10-15 Thread Kenneth Venken
Jan Holesovsky schreef op vr 15-10-2010 om 22:18 [+0200]: > Hi Kenneth, > > On 2010-10-15 at 21:10 +0200, Kenneth Venken wrote: > > > Fixes a compiler warning: "suggest parentheses around && within || " > > I also improved the readability of the code a bit. > > The change you did silents the war

Re: [Libreoffice] [LibreOffice][PATCH] Fixes Compiler Warning

2010-10-15 Thread Jan Holesovsky
Hi Kenneth, On 2010-10-15 at 21:10 +0200, Kenneth Venken wrote: > Fixes a compiler warning: "suggest parentheses around && within || " > I also improved the readability of the code a bit. The change you did silents the warning by doing what the compiler would do; but is that really what was the

[Libreoffice] [LibreOffice][PATCH] Fixes Compiler Warning

2010-10-15 Thread Kenneth Venken
Fixes a compiler warning: "suggest parentheses around && within || " I also improved the readability of the code a bit. diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx index 1ef3e3d..41f470e 100644 --- a/cui/source/options/optgdlg.cxx +++ b/cui/source/options/optgdlg.cx