Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-14 Thread Eike Rathke
Hi Markus, On Saturday, 2011-11-12 16:11:09 +0100, Markus Mohrhard wrote: This part might be worng: if ( bValue ) -aString.AssignAscii( ### ); -aString.Erase( nLen ); +aString = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( ### )); It is. The ### was

Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-14 Thread Caolán McNamara
On Mon, 2011-11-14 at 15:11 +0100, Eike Rathke wrote: The ### was only assigned if the value was numeric, textual values were truncated instead. The change now omits the truncation. Yeah, but I think I remedied that earlier today with fb754a0df859e30255c25af8fa19bfaa75f257e7 C.

Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-12 Thread Chr. Rossmanith
To add some information: LibO builds fine but I keep getting failed tests in the end: make[1]: *** [/Space/LibreOffice_OneGit/core/workdir/unxlngi6.pro/CppunitTest/sc_filters_test.test] Fehler 1 It's ./sc where I made modifications and sc_filters_test which fails... Christina Am

Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-12 Thread Markus Mohrhard
Hello Christina, 2011/11/12 Chr. Rossmanith chrrossman...@gmx.de: To add some information: LibO builds fine but I keep getting failed tests in the end: make[1]: *** [/Space/LibreOffice_OneGit/core/workdir/unxlngi6.pro/CppunitTest/sc_filters_test.test] Fehler 1 It's ./sc where I made

[Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

2011-11-11 Thread Chr. Rossmanith
Hi, currently I'm removing the Fill() method for strings. Comments are very welcome. Christina From 278bc39f8f3914cff1b5d860b74dd5c12d17af7c Mon Sep 17 00:00:00 2001 From: Christina Rossmanith chrrossman...@web.de Date: Fri, 11 Nov 2011 23:09:26 +0100 Subject: [PATCH] Remove String::Fill()