Re: [Libreoffice] [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-12-02 Thread Alex Hudson
(apologies for breaking the thread; I only just subscribed) I offered an opinion on this excellent little patch to Caolán on IRC, basically that I thought the last foreach()/chop combo would be better written as a join. A minor nit, but probably not with much speed benefit. The more perlish

Re: [Libreoffice] [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-12-02 Thread Michael Meeks
Hi Alex, On Thu, 2010-12-02 at 11:32 +, Alex Hudson wrote: (apologies for breaking the thread; I only just subscribed) Great to see you here :-) The more perlish version of optimize_list() would probably look more like this: Soo ... In general, doing a lot of text

[Libreoffice] [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

2010-11-30 Thread Jordan Ayers
Another performance improvement for the perl installer. This one brought my ./bin/ooinstall -l dirname time down from about 4 1/2 minutes to under 4 minutes. (Warning: that number is in the right ballpark, but is from a very small number of install runs.) The only functional change was to