Hi,
I've started looking at the easy hack for removing the macro-defined
vectors in svl/avarray. Chose an easy one to start with. First
attached patch removes all usage of SvShorts from sc (only place it was
used), and the second removes the declaration of it from svl.
Changes are LGPLv3+/MPL
On Fri, 2011-01-28 at 14:09 +, Nigel Hawkins wrote:
Hi,
I've started looking at the easy hack for removing the macro-defined
vectors in svl/avarray. Chose an easy one to start with. First
attached patch removes all usage of SvShorts from sc (only place it was
used), and the second
On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote:
Thanks for your patches.
Oh yeah, I almost forgot. ;-)
You don't need to remove all trailing whitespaces in those files you
modify, as that would create unnecessary hunks making it harder for us
to review your patches.
I thought that it
On Fri, 2011-01-28 at 10:57 -0500, Kohei Yoshida wrote:
You don't need to remove all trailing whitespaces in those files you
modify, as that would create unnecessary hunks making it harder for us
to review your patches.
I wasn't aware I had. I suspect my pesky editor is doing it behind my
On Fri, 2011-01-28 at 17:03 +, Nigel Hawkins wrote:
On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote:
Here, you've changed the semantics of the code. I've fixed that to
push_back(nTab+i) which is probably what we need to do here.
Sorry. My bad.
Not a problem. I eventually
