Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-26 Thread Thorsten Behrens
Eike Rathke wrote: Yep, we're already doing that for some functions, see formula/source/core/resource/core_resource.src section RID_STRLIST_FUNCTION_NAMES_ENGLISH_ODFF where we have several ORG.OPENOFFICE.* and even one COM.MICROSOFT.BAHTTEXT Ah cool, wasn't aware - added some placeholders

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-26 Thread Eike Rathke
Hi Thorsten, On Wednesday, 2011-10-26 11:38:21 +0200, Thorsten Behrens wrote: http://wiki.documentfoundation.org/Development/ODF_Implementer_Notes#LibreOffice_ODFF_extensions - would you want to fill in the blanks? Done. As, naturally, there is no OASIS reference for functions not

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-26 Thread Thorsten Behrens
Eike Rathke wrote: Done. As, naturally, there is no OASIS reference for functions not defined by OASIS ;) I changed the OASIS-reference column to a Note column. Thanks - and of course, the latter makes more sense. :) Cheers, -- Thorsten pgpTPlyZj64md.pgp Description: PGP signature

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-25 Thread Michael Meeks
On Mon, 2011-10-24 at 20:38 +0200, Eike Rathke wrote: However, the naming question remains for future functions not (yet) defined by ODF. Quite. Certainly it should not be ORG.OPENOFFICE.FOO, IMHO it should be ORG.LIBREOFFICE.FOO instead of ORG.DOCUMENTFOUNDATION.FOO, i.e. specify

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-25 Thread Eike Rathke
Hi Michael, On Tuesday, 2011-10-25 14:32:14 +0100, Michael Meeks wrote: On Mon, 2011-10-24 at 20:38 +0200, Eike Rathke wrote: However, the naming question remains for future functions not (yet) defined by ODF. Quite. Certainly it should not be ORG.OPENOFFICE.FOO, IMHO it should

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-24 Thread Eike Rathke
Hi Regina, On Friday, 2011-10-21 13:20:42 +0200, Regina Henschel wrote: For CALC there are some problems. A function FRAC is not defined in ODF1.2 [1]. Markus already gave a hint why we wouldn't even need a FRAC function in Calc as MOD(x,1) does it. However, the naming question remains for

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-21 Thread Andor E
Interestingly enough there seem to be two definitions for the frac function. Your implementation is the one seemingly used by all programming languages, which implement it. But the correct mathematical definition seems to be y = x - floor(x) (http://mathworld.wolfram.com/FractionalPart.html),

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-21 Thread Regina Henschel
Hi August, August Sodora schrieb: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? I'm not sure about it. It seems you are mixing up BASIC functions and CALC interpreter. Kind regards Regina

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-21 Thread Noel Power
On 21/10/11 04:19, August Sodora wrote: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? seems like a nice patch :-). From the basic side of things , all seems fine, if Kohei is happy with the calc parts then I see no

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-21 Thread Regina Henschel
Hi August, August Sodora schrieb: I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? I understand now, that you will do BASIC and CALC at the same time. For CALC there are some problems. A function FRAC is not defined in

Re: [Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-21 Thread August Sodora
Interesting, I'll take a look at those documents. I had actually initially thought that adding something to the BASIC language would be more controversial than adding a calc cell function :) Has there been any discussion on where these types of additions should go in the past? August Sodora

[Libreoffice] [PATCH] Frac function in calc/BASIC

2011-10-20 Thread August Sodora
I came across this feature request today and decided to try my hand at it. Is the attached patch an appropriate solution? August Sodora aug...@gmail.com (201) 280-8138 From df0bb0d95a4343ac13aff62328c62511afaaa92b Mon Sep 17 00:00:00 2001 From: August Sodora aug...@gmail.com Date: Thu, 20 Oct