Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-04-03 Thread David Tardon
On Fri, Apr 01, 2011 at 04:36:03AM -0600, Tor Lillqvist wrote: > > I checked manually if the number was in the file. I didn't check > > further, as I don't know a way to do that. > > OK. I don't know of any clever direct way either, but using > http://opengrok.libreoffice.org/more/libs-core/sv

Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-04-03 Thread Rob Snelders
Hi, Can somebody tell me if this needs to be changed? and if not can somebody put it in the 3.4-tree because the way the adding and removing of color charts works now is a bit strange. M.V.G. Rob Snelders On 01-04-11 12:36, Tor Lillqvist wrote: I checked manually if the number was in the

Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-04-01 Thread Tor Lillqvist
> I checked manually if the number was in the file. I didn't check > further, as I don't know a way to do that. OK. I don't know of any clever direct way either, but using http://opengrok.libreoffice.org/more/libs-core/svx/inc/svx/dialogs.hrc?full=RID_SVX_START++296 and http://opengrok.libre

Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-04-01 Thread Rob Snelders
Hi tml, I checked manually if the number was in the file. I didn't check further, as I don't know a way to do that. On Fri, 01 Apr 2011 02:00:51 -0600, Tor Lillqvist wrote: I have improved my last patch for the Color Charts. Thanks! I will commit it, just a question about one thing I don't

Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-04-01 Thread Tor Lillqvist
> I have improved my last patch for the Color Charts. Thanks! I will commit it, just a question about one thing I don't understand: #define RID_SVXPAGE_ASIAN_LAYOUT(RID_SVX_START + 246) #define RID_OPTPAGE_CHART_DEFCOLORS (RID_SVX_START + 299) +#define RID_OPTQB_COLOR_CHART_

Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-03-31 Thread Bernhard Dippold
Rob Snelders schrieb: Hi, I have improved my last patch for the Color Charts. It now renames the Color Charts, asks a question before removing of a color and selects a new color when deleting of when setting to default. Great! Thanks for your work and your openness to proposals for improvemen

[Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

2011-03-31 Thread Rob Snelders
Hi, I have improved my last patch for the Color Charts. It now renames the Color Charts, asks a question before removing of a color and selects a new color when deleting of when setting to default. This patch is under the LGPLv3+/MPL-licence. -- Greetings, Rob Snelders On 24-03-11 21:37, Ro