On 09/02/12 14:53, Albert Thuswaldner wrote:
Hi,
[...]
So I have improved the patch according to Kohei's suggestion above.
Now I store the prefix at each key-stroke and check for illegal
characters. When an illegal character is entered, the text is reverted
back to the last good prefix. (So
On 09/02/12 14:53, Albert Thuswaldner wrote:
If it was up to me I would go for the visual bell. Any thoughts on this?
actually thinking about it some more I don't find it unnatural to have
the whole ( reverted ) prefix selected after entering an illegal
character ( I think this is a technique
On Mon, Feb 13, 2012 at 12:23, Noel Power nopo...@suse.com wrote:
On 09/02/12 14:53, Albert Thuswaldner wrote:
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
well that would seem to be because your code thinks a blank prefix is
illegal, I
On 09/02/12 14:53, Albert Thuswaldner wrote:
Hi,
[...]
So I have improved the patch according to Kohei's suggestion above.
Now I store the prefix at each key-stroke and check for illegal
characters. When an illegal character is entered, the text is reverted
back to the last good prefix. (So
On 09/02/12 14:53, Albert Thuswaldner wrote:
If it was up to me I would go for the visual bell. Any thoughts on this?
actually thinking about it some more I don't find it unnatural to have
the whole ( reverted ) prefix selected after entering an illegal
character ( I think this is a technique
On Mon, Feb 13, 2012 at 12:23, Noel Power nopo...@suse.com wrote:
On 09/02/12 14:53, Albert Thuswaldner wrote:
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
well that would seem to be because your code thinks a blank prefix is
illegal, I
Hi,
Given that, I still think it's better (and easier) to check for every
key-press, but instead of launching an error dialog for an illegal name,
just put the old legal name back into the text box and sound an beep or
something. That's less intrusive than a big dialog being thrown right
Hi Albert,
At least I get two annoying bugs:
1) The cursor moves In front of the text when the Prefix is reverted.
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
Does someone have a clue whats going on?
Hm, no (not a coder I am). But can you
Hi,
Given that, I still think it's better (and easier) to check for every
key-press, but instead of launching an error dialog for an illegal name,
just put the old legal name back into the text box and sound an beep or
something. That's less intrusive than a big dialog being thrown right
Hi Albert,
At least I get two annoying bugs:
1) The cursor moves In front of the text when the Prefix is reverted.
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).
Does someone have a clue whats going on?
Hm, no (not a coder I am). But can you
Hi,
However something I noticed is that there are still some problems with
entering the 'Prefix name in the options, firstly the input box seems to be
overwritten by the label ( part of the input/edit field for the prefix is
missing until you type )
Hmm, strange, I haven't notice that myself.
On 31/01/12 18:35, Albert Thuswaldner wrote:
Additionally you still can get the prefix name to
be blank ( or at least I managed to do that ) by attempting to change the
name by delete, when all the name is deleted you get a message saying the
sheet prefix is illegal ( actually I find that
On Tue, 2012-01-31 at 20:07 +, Noel Power wrote:
On 31/01/12 18:35, Albert Thuswaldner wrote:
Additionally you still can get the prefix name to
be blank ( or at least I managed to do that ) by attempting to change
the
name by delete, when all the name is deleted you get a
Hi Albert,
On Tuesday, 2012-01-31 19:35:54 +0100, Albert Thuswaldner wrote:
However something I noticed is that there are still some problems with
entering the 'Prefix name in the options, firstly the input box seems to be
overwritten by the label ( part of the input/edit field for the
On 31/01/12 20:29, Kohei Yoshida wrote:
Well, that's rather hard to do with the Options dialog, since you can
freely switch between different option pages and we then would have to
check the validity of all the option tab pages upon dismissal of the
whole Options dialog...
sigh you're correct,
Hello
Le Tue, 31 Jan 2012 21:48:30 +0100, Noel Power nopo...@suse.com a écrit:
On 31/01/12 20:29, Kohei Yoshida wrote:
Well, that's rather hard to do with the Options dialog, since you can
freely switch between different option pages and we then would have to
check the validity of all the
Albert
On 30/01/12 13:07, Noel Power wrote:
Hi I pushed it to master, it's a nice patch
incase you look for your patch, well I thought I committed it but only
noticed now there is a conflict message, will fix after some food
___
LibreOffice mailing
On 30/01/12 13:14, Noel Power wrote:
Albert
On 30/01/12 13:07, Noel Power wrote:
Hi I pushed it to master, it's a nice patch
incase you look for your patch, well I thought I committed it but only
noticed now there is a conflict message, will fix after some food
hopefully I didn't screw it up (
Hi,
Shows a number of likely candidates; connecting to the 'ModifyHdl'
and running the validator on the name, removing characters if it not valid
might work; but of course.
git grep SetModifyHdl
for some instances of that; possibly we don't want to stop user input,
Hi Albert,
On Wed, 2012-01-25 at 21:48 +0100, Albert Thuswaldner wrote:
Can you give me any pointers on how to intercept a input value change
event. I've done some digging (looking for an event listener) but
haven't found it quite yet.
Let me help de-tangle a bit (if I can). It rather
Hi Kohei/LO devs,
Now, a slightly bigger issue. The sheet prefix option input box doesn't
check for valid sheet name. It even allows an empty one, which is not
very good. So, we should at least apply the same restriction as in
ScDocument::ValidTabName() method (located in
Hi Kohei,
Thanks for your comments.
On Fri, Jul 8, 2011 at 05:02, Kohei Yoshida kyosh...@novell.com wrote:
On Sat, 2011-07-02 at 12:09 +0200, Albert Thuswaldner wrote:
Hi
Submitting a patch for review. This one enables the user to set the
default tab prefix name in calc.
The new option is
On Sat, 2011-07-02 at 12:09 +0200, Albert Thuswaldner wrote:
Hi
Submitting a patch for review. This one enables the user to set the
default tab prefix name in calc.
The new option is located in Menu - Tools - Options - LibreOffice
Calc - Defaults
- I think this Is a useful feature for some
On Thu, 2011-07-07 at 23:02 -0400, Kohei Yoshida wrote:
Now, a slightly bigger issue. The sheet prefix option input box doesn't
check for valid sheet name.
A little follow-up on this. I see that you *do* do naming fallback in
case the custom name is not a valid name. But instead of doing
Hi
Submitting a patch for review. This one enables the user to set the
default tab prefix name in calc.
The new option is located in Menu - Tools - Options - LibreOffice
Calc - Defaults
- I think this Is a useful feature for some at least, a few LO/OOo
users i've talked to seem to agree.
- it is
25 matches
Mail list logo
