Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Michaël Lefèvre
Damned misunderstanding ;) I've posted the patches once the compilation succeeds yesterday evening. Michaël 2011/3/16 Michaël Lefèvre : > Actually not tested :( > Just keep compiling. > > Solar.h > #define F_PI 3.14159265358979323846 > > And ftools.h > #define F_PI M_PI > > M_PI defined in OdgEx

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Thorsten Behrens
Michaël Lefèvre wrote: > Just keep compiling. > That's ok in this case. Give us a poke if your build succeeds. Cheers, -- Thorsten pgpidvIb1p5rX.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://list

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Michaël Lefèvre
Actually not tested :( Just keep compiling. Solar.h #define F_PI 3.14159265358979323846 And ftools.h #define F_PI M_PI M_PI defined in OdgExporter.cxx as #define M_PI 3.14159265358979323846 Same values. The value changed in the other constants F_PI*. In solar.h, these are fixed, where in ftool

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Cedric Bosdonnat
Hi Michael, Did you test that your patches didn't introduce a regression? As the two F_PI constants don't have the same value, some bugs can be introduced by using a more precise value. I'll try to have a look at it before the end of the week, many thanks for your patches! On Tue, 2011-03-15 at

[Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-15 Thread Michael Lefevre
Easy hack, constants already defined in libs-gui/basegfx/inc/basegfx/numeric/ftools.hxx --- oox/source/drawingml/chart/converterbase.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/oox/source/drawingml/chart/converterbase.cxx b/oox/source/drawingml/chart/converterba

[Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-15 Thread Michael Lefevre
Easy hack, constants already defined in libs-gui/basegfx/inc/basegfx/numeric/ftools.hxx --- basic/source/runtime/props.cxx |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/basic/source/runtime/props.cxx b/basic/source/runtime/props.cxx index 44f87c1..5c39f69 100644 --- a/b

[Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-15 Thread Michael Lefevre
Easy hack, constants already defined in libs-gui/basegfx/inc/basegfx/numeric/ftools.hxx --- tools/inc/tools/solar.h | 26 -- 1 files changed, 0 insertions(+), 26 deletions(-) diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h index 1c1c6ab..e8034b0 100644 --