Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Bjoern Michaelsen
On Thu, 24 Feb 2011 10:53:32 -0500 Kohei Yoshida wrote: > On Thu, 2011-02-24 at 15:30 +, Caolán McNamara wrote: > > On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote: > > > On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote: > > > > 2) must we remove all the "rtl::" stuff ? > > > > >

Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Kohei Yoshida
On Thu, 2011-02-24 at 15:30 +, Caolán McNamara wrote: > On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote: > > On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote: > > > 2) must we remove all the "rtl::" stuff ? > > > > If you mean "using namespace rtl;", yes, because that could cause >

Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Bjoern Michaelsen
Hi, On Thu, 24 Feb 2011 15:30:45 + Caolán McNamara wrote: > On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote: > > On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote: > > > 2) must we remove all the "rtl::" stuff ? > -using namespace rtl; > which looks fine, +1 > +using ::rtl::OU

Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote: > On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote: > > 2) must we remove all the "rtl::" stuff ? > > If you mean "using namespace rtl;", yes, because that could cause > conflict between com::sun::star::uno::Reference and rtl::Reference.

Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Kohei Yoshida
On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote: > Hello, > > Here is the first try with this easyhack. > Could you tell me > 1) if my patch is ok ? (I can push it myself) Yes, it looks good to me. As long as it builds fine I'm all for it. > 2) must we remove all the "rtl::" stuff ? If y

[Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

2011-02-24 Thread Julien Nabet
Hello, Here is the first try with this easyhack. Could you tell me 1) if my patch is ok ? (I can push it myself) 2) must we remove all the "rtl::" stuff ? Julien. commit 9c2bd745cde4a6d635b0f0083d40f702ce1e66cc Author: Julien Nabet Date: Thu Feb 24 15:22:42 2011 +0100 Remove "using names