[Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

2012-01-31 Thread Noel Grandin
Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx index 98f2df5..c8b1495 100644 --- a/sd/sou

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

2012-01-31 Thread Noel Grandin
sorry, that should be "converted to std::vector" On 2012-01-31 16:22, Noel Grandin wrote: Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

2012-02-01 Thread Noel Power
Hi Noel On 31/01/12 14:24, Noel Grandin wrote: sorry, that should be "converted to std::vector" you mean boost::ptr_vector I think :-) Hope I didn't miss anything this time, I made some minor changes ( see attached patch ) e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

2012-02-01 Thread Noel Grandin
On 2012-02-01 13:58, Noel Power wrote: e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as the vector will go out of scope here anyway and delete the container contents. Really? I wasn't sure about that - the boost documentation isn't that great. So I scanned the LibO co

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

2012-02-01 Thread Noel Power
On 01/02/12 11:59, Noel Grandin wrote: On 2012-02-01 13:58, Noel Power wrote: e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as the vector will go out of scope here anyway and delete the container contents. Really? I wasn't sure about that - the boost documentation is