Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

2012-02-06 Thread Noel Power
On 02/02/12 18:17, Muhammad Haggag wrote: On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag > wrote: On Thu, Feb 2, 2012 at 2:01 PM, Noel Power mailto:nopo...@suse.com>> wrote: very nice patch, looking at the spec I agree and this looks like a credibl

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

2012-02-02 Thread Muhammad Haggag
On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag wrote: > On Thu, Feb 2, 2012 at 2:01 PM, Noel Power wrote: > >> very nice patch, looking at the spec I agree and this looks like a >> credible fix for me so pushed to master. Look forward to more like this, >> thanks >> >> Thanks for the review! If

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

2012-02-02 Thread Muhammad Haggag
On Thu, Feb 2, 2012 at 2:01 PM, Noel Power wrote: > very nice patch, looking at the spec I agree and this looks like a > credible fix for me so pushed to master. Look forward to more like this, > thanks > > Thanks for the review! If you'd pardon my absolute noobiness, do I have access to push to

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

2012-02-02 Thread Noel Power
On 01/02/12 19:21, Muhammad Haggag wrote: Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43398 Cause: dmapper used to treat the presence of a w:BiDi element in a paragraph's properties as an indicator of RTL directionality, which is incorrect. A w:BiDi element may have a value of 0, indicat

[Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

2012-02-01 Thread Muhammad Haggag
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43398 Cause: dmapper used to treat the presence of a w:BiDi element in a paragraph's properties as an indicator of RTL directionality, which is incorrect. A w:BiDi element may have a value of 0, indicating LTR. Fix: Inspect the integral value of w