Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-03 Thread surensp...@gmail.com
Hey Sebastian, I did the push in rawbuild directory and not in build directory. This specific file within clone even was not in git repo. Not sure how that is possible though. Thanks, ~Suren On Wed, Nov 3, 2010 at 2:15 PM, Sebastian Spaeth wrote: > On Wed, 3 Nov 2010 10:12:08 +0530, "surensp...

Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-03 Thread Sebastian Spaeth
On Wed, 3 Nov 2010 10:12:08 +0530, "surensp...@gmail.com" wrote: > I also faced the issue. I just had to add a paranthesis to fix it and > proceed with the build. But when I thought of submitting the patch, > that ucalc.cxx file was not git revisioned. Just for knowledge, How > are these files ge

Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-02 Thread surensp...@gmail.com
I also faced the issue. I just had to add a paranthesis to fix it and proceed with the build. But when I thought of submitting the patch, that ucalc.cxx file was not git revisioned. Just for knowledge, How are these files generated ? Thanks, ~Suren On Wed, Nov 3, 2010 at 2:54 AM, Caolán McNamara

Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-02 Thread Caolán McNamara
On Tue, 2010-11-02 at 20:00 +0100, Gert Faller wrote: > Hi, > > On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote: > > Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing > > > > My fault, sorry. Fear not, I've broken the build about fifteen times already. It

[Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-02 Thread Gert Faller
Hi, On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote: > Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing > My fault, sorry. Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fr

Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-02 Thread David Tardon
On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote: > Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing > Hi, you're too late :) Caolan has already fixed it. D. ___ LibreOffice mailing list LibreOffice@lists.freed

[Libreoffice] [PATCH] sc: fix parenthesis mixup

2010-11-02 Thread Sebastian Spaeth
Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing Signed-off-by: Sebastian Spaeth --- sc/qa/unit/ucalc.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 4fbdbdd..366eff5 100644 --- a/sc/qa/unit/