Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack SmNode*

2011-12-07 Thread Eike Rathke
Hi, On Wednesday, 2011-12-07 00:28:11 +0100, Stephan Bergmann wrote: i.e., at SmNode *pNode = m_aNodeStack.top() in SmParser::Expression(), where m_aNodeStack is empty. It *looks* to me that the following happens: The stack is rightfully empty, but the old implementation of tools' stack

Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack SmNode*

2011-12-07 Thread Eike Rathke
Hi, On Wednesday, 2011-12-07 14:34:02 +0100, Eike Rathke wrote: who knows which other code depended on this magnificent misfeature of the old stack implementation, too... I'm inspecting that and will fix.

Re: [Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack SmNode*

2011-12-06 Thread Stephan Bergmann
On 12/01/2011 11:09 AM, Marcel Metz wrote: --- starmath/inc/parse.hxx |3 +- starmath/source/math_pch.cxx |1 - starmath/source/mathmlimport.cxx | 223 ++ starmath/source/mathmlimport.hxx |8 ++- starmath/source/parse.cxx

[Libreoffice] [PATCH 05/11] Replace SmNodeStack with std::stack SmNode*

2011-12-01 Thread Marcel Metz
--- starmath/inc/parse.hxx |3 +- starmath/source/math_pch.cxx |1 - starmath/source/mathmlimport.cxx | 223 ++ starmath/source/mathmlimport.hxx |8 ++- starmath/source/parse.cxx| 222 -- 5