[Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Caolán McNamara
On Sun, 2011-01-16 at 12:07 +0100, Julien Nabet wrote: Hello, Here is a patch for some cppcheck cleaning in ucb Compiling was ok Pushed the first part. For the second one, that one in gio is a false positive, it's only compiled with you do --enable-gio, which is probably why it compiled

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Jesse Adelman
On 01/17/11 04:16, Caolán McNamara wrote: On Sun, 2011-01-16 at 12:07 +0100, Julien Nabet wrote: Hello, Here is a patch for some cppcheck cleaning in ucb Compiling was ok Pushed the first part. For the second one, that one in gio is a false positive, it's only compiled with you do

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Julien Nabet
Le 17/01/2011 13:16, Caolán McNamara a écrit : On Sun, 2011-01-16 at 12:07 +0100, Julien Nabet wrote: Hello, Here is a patch for some cppcheck cleaning in ucb Compiling was ok Pushed the first part. For the second one, that one in gio is a false positive, it's only compiled with

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Caolán McNamara
On Mon, 2011-01-17 at 21:57 +0100, Julien Nabet wrote: Ok. And to respond to Jesse Adelman, there is now the tracker 2479 on cppcheck for this. Oops I stepped on your toes there. I was also logging the test-case as http://sourceforge.net/apps/trac/cppcheck/ticket/2480 I'll mark one as a

Re: [Libreoffice] [PUSHED, partial] Re: [PATCH] some cppcheck cleaning in ucb

2011-01-17 Thread Julien Nabet
Le 17/01/2011 22:15, Caolán McNamara a écrit : On Mon, 2011-01-17 at 21:57 +0100, Julien Nabet wrote: Ok. And to respond to Jesse Adelman, there is now the tracker 2479 on cppcheck for this. Oops I stepped on your toes there. I was also logging the test-case as