Re: [Libreoffice] [PUSHED][PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

2011-11-12 Thread Noel Grandin
Seems like this is a case where you should be able to find unit testing in some other open source project, rather than writing them from scratch. Mozilla, Apache Harmony, Perl, Webkit, Python, should all have a bunch of unit testing code for their regular expression features. In fact, there are a

Re: [Libreoffice] [PUSHED][PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

2011-11-11 Thread Eike Rathke
Hi Karl, On Thursday, 2011-11-10 21:44:33 -0800, Karl Koehler wrote: investigating further I have come to the conclusion that the attached ( and previously inlined ) patch is correct, in the sense that regular expressions of the failing type are now handled correctly. e.g. A[\[:\]]

Re: [Libreoffice] [PUSHED] [PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

2011-11-11 Thread Noel Power
On 11/11/11 05:44, Karl Koehler wrote: Hi, investigating further I have come to the conclusion that the attached ( and previously inlined ) patch is correct, in the sense that regular expressions of the failing type are now handled correctly. e.g. A[\[:\]] should find an 'A' followed by one

Re: [Libreoffice] [PUSHED][PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

2011-11-11 Thread Noel Power
On 11/11/11 13:32, Eike Rathke wrote: now I see why my push failed appears you beat me to it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED][PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

2011-11-11 Thread koehlerkarl
Hi Eike, I confirm I contribute this and all future patches for LibreOffice under the LGPLv3+ and MPL 1.1 . Yes, there are quite some shortcomings and bugs with that code. I wouldn't invest too much time though, plan is to replace that legacy code entirely with the more suitable ICU