Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

2011-11-29 Thread Caolán McNamara
On Mon, 2011-11-28 at 21:26 +0200, Khaled Hosny wrote: > Anyway, the font can be obtained from here[1], and I'm > attaching a test file that shows this issue. > > [1] https://sourceforge.net/projects/amiri/files/ Great, thanks. Added it as a test doc as http://cgit.freedesktop.org/libreoffice/cor

Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

2011-11-28 Thread Khaled Hosny
Hi Thorsten, On Mon, Nov 28, 2011 at 11:57:04AM +0100, Thorsten Behrens wrote: > Khaled Hosny wrote: > > This patch removes the "reasonable default" value of mnMinKashida which > > makes no sense at all; either the font have a Kashida glyph and > > mnMinKashida is set to its width or it doesn't an

Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

2011-11-28 Thread Thorsten Behrens
Khaled Hosny wrote: > This patch removes the "reasonable default" value of mnMinKashida which > makes no sense at all; either the font have a Kashida glyph and > mnMinKashida is set to its width or it doesn't and mnMinKashida is kept > 0. > Hi Khaled, nice one, pushed - by any chance, do you have