[Libreoffice] [PUSHED] Docuview code cleanup #2

2011-11-24 Thread Michael Meeks
Hi Matteo, On Thu, 2011-11-24 at 02:04 +0100, Matteo Casalin wrote: > * a revised patch, with a new ImplDrawSymbol; Lovely :-) it reads more nicely now, I pushed it & good work. > * a picture with the drawings of all symbols, produced by both the old >and by the new routines. All sym

Re: [Libreoffice] [PUSHED] Docuview code cleanup

2011-11-24 Thread Matteo Casalin
Hi Michael, please also note that for SYMBOL_CHECKMARK I kept both normal and mirrored versions of the symbol, as in the original routine, although the comment // #106953# never mirror checkmarks seems to mean that this is not desired. But I don't know if the comment is obsolete, misleadin

Re: [Libreoffice] [PUSHED] Docuview code cleanup

2011-11-23 Thread Matteo Casalin
Hi Michael, you were faster than me: I've been playing with that code lately, rewriting all of the ImplDrawSymbol routine and was planning to do the last verifications/cleanups this evening and send it today or tomorrow with also a picture including all of the old symbols and the "new" ones, in b

[Libreoffice] [PUSHED] Docuview code cleanup

2011-11-23 Thread Michael Meeks
Hi Matteo, On Sun, 2011-11-13 at 19:54 +0100, Matteo Casalin wrote: > my name's Matteo and this is my first contribution [attempt] to > this wonderful piece of work, besides "spreading the word". Cool - welcome ! and I'm sorry it took so long to get to reviewing this properly. > Th