On Sun, 2010-11-21 at 21:35 +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch for libs-core/vbahelper
> Julien.
Reviewed the vbahelper patch, looks good. Pushed this, thanks for you
efforts.
btw, when you're sending these patches, you're including the content of
previous patches in there as
On Sat, 2010-11-20 at 13:47 +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch for libs-core/embeddedobj
Thanks for this. Pushed.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libre
On Sun, 2010-11-21 at 02:36 +0900, Takeshi Abe wrote:
> Both versions of "i18n" return a QString.
Thanks. Yeah, and with an operator to convert to const char*, not a
candidate for RTL_CONSTASCII_USTRINGPARAM then. The check I have in the
rostrings branch would catch that when integrated once I fig
Hi Caolán,
On Sat, 20 Nov 2010 16:38:45 +, Caolán McNamara wrote:
> -(::rtl::OUString::createFromAscii( i18n("Address Book") ));
> +(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n("Address
> Book")) ));
>
> Hmm, what's "i18n" in this context, I can't seem to see a define o
On Sat, 2010-11-20 at 17:50 +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch for libs-core/fpicker
Looks all good. Thanks for this.
I did leave out the changes inside the VISTAFILEDIALOG_CHECKED_COMCALL
macro.
as its inside a define where the parameter is passed into it, so it
can't be gu
On Fri, 2010-11-19 at 23:23 +0100, Julien Nabet wrote:
> Hello,
>
> Here's a patch for libs-core
Looks good, top part was duplicate of previous patch. So pushed the
extra bits. Thanks for this.
When I see an empty sting being created, e.g.
OUString::createFromAscii("") best to just replace it wi
On Fri, 2010-11-19 at 22:53 +0100, Julien Nabet wrote:
> Hello,
>
> Here's patch for the last changes to do that I've seen in
> libs-core/connectivity/drivers
-(::rtl::OUString::createFromAscii( i18n("Address Book") ));
+(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n("Address
