Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Caolán McNamara
On Sun, 2010-11-21 at 02:36 +0900, Takeshi Abe wrote: > Both versions of "i18n" return a QString. Thanks. Yeah, and with an operator to convert to const char*, not a candidate for RTL_CONSTASCII_USTRINGPARAM then. The check I have in the rostrings branch would catch that when integrated once I fig

Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Takeshi Abe
Hi Caolán, On Sat, 20 Nov 2010 16:38:45 +, Caolán McNamara wrote: > -(::rtl::OUString::createFromAscii( i18n("Address Book") )); > +(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n("Address > Book")) )); > > Hmm, what's "i18n" in this context, I can't seem to see a define o

[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Caolán McNamara
On Fri, 2010-11-19 at 22:53 +0100, Julien Nabet wrote: > Hello, > > Here's patch for the last changes to do that I've seen in > libs-core/connectivity/drivers -(::rtl::OUString::createFromAscii( i18n("Address Book") )); +(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n("Address