Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
It now works with the new sheet local DB ranges, which are no longer
available through UNO API. Additionally I changed those methods that they my
no longer manipulate named DB ranges because Ex
On Thu, 2011-04-21 at 22:34 +0200, Markus Mohrhard wrote:
> Hello,
>
> here a short patch that reworks the
> ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
Hi Markus,
Just a minor thing. In ScVbaWorksheet::setAutoFilterMode(), you do
+if (bAutoFilterMode && pDoc)
but you
Hello Kohei,
yes you're right. This part was copied from another method and I didn't
notice it. But I don't think that you must check for ScDocShell, because the
whole class is build without any check for it.
Should I send a reworked patch? There are just the two occurences of this
check. Only th
Hi Markus,
On Fri, 2011-04-22 at 19:29 +0200, Markus Mohrhard wrote:
> Hello Kohei,
>
> yes you're right. This part was copied from another method and I
> didn't notice it. But I don't think that you must check for
> ScDocShell, because the whole class is build without any check for it.
Agreed.
On Thu, 2011-04-21 at 22:34 +0200, Markus Mohrhard wrote:
> Hello,
>
> here a short patch that reworks the
> ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
Ok. I had to push this first since your later patch depends on it, and
I didn't want you blocking on us.
Noel, the change loo
On 21/04/11 21:34, Markus Mohrhard wrote:
Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
I see Kohei has pushed it :-)
P.S. Noel did you push the last patch?
yes ( done now ), thanks for reminding me :-)
thanks again
Noel
__
On 25/04/11 21:27, Kohei Yoshida wrote:
Noel, the change looked okay to me, so I took the liberty of pushing
this patch. If you see anything that needs changing or tweaking, feel
free to make or suggest the change. Thanks.
Kohei
no problem, looks good to me as well
Noel
