[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping, take 2

2012-01-24 Thread Kohei Yoshida
Hi there, I've found a better way to fix it. Attached is tailored specifically for the 3-5 branch. I'll port this fix to master separately since master has my earlier commit that would make this patch not apply without adjusting. Again, this fixes https://bugs.freedesktop.org/show_bug.cgi?id=4

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-24 Thread Kohei Yoshida
On Tue, 2012-01-24 at 12:24 +0100, Eike Rathke wrote: > Hi, > > On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote: > > > Did you check with libreoffice 3-5? I think that eike's work for date > > patterns is missing in 3-5 > > Yes, that's only on master. > > > so that this patch does

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-24 Thread Eike Rathke
Hi, On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote: > Did you check with libreoffice 3-5? I think that eike's work for date > patterns is missing in 3-5 Yes, that's only on master. > so that this patch does reopen the bug we > discussed on IRC. At least your unit test fails and I

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-24 Thread Markus Mohrhard
Hello Kohei, 2012/1/24 Kohei Yoshida : > Hi there, > > I would like > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde > > to be backported to the 3-5 branch.  It fixes > > https://bugs.freedesktop.org/show_bug.cgi?id=45067 > > Review and sign-off

[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-23 Thread Kohei Yoshida
Hi there, I would like http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde to be backported to the 3-5 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=45067 Review and sign-off appreciated. Kohei -- Kohei Yoshida, LibreOffice hacke