Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-17 Thread Cedric Bosdonnat
Hi Caolan, On Tue, 2011-08-16 at 14:26 +0100, Caolán McNamara wrote: > On Tue, 2011-08-16 at 05:48 -0700, cbosdonnat wrote: > > All is now working fine, and that later commit could be applied to 3.4 > > safely. > > Sorry, not trying to be a pain or anything, but that assignment operator > now lea

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread Caolán McNamara
On Tue, 2011-08-16 at 05:48 -0700, cbosdonnat wrote: > All is now working fine, and that later commit could be applied to 3.4 > safely. Sorry, not trying to be a pain or anything, but that assignment operator now leaks the original mpXPoly of the SdrRectObj that's assigned to if there was one. C.

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread Lubos Lunak
On Tuesday 16 of August 2011, cbosdonnat wrote: > Caolán McNamara wrote: > > On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: > Indeed that remembers me of a discussion like that with Lubos... though I'm > not good enough in C++ to see those subtleties. I reverted the above > mentioned pa

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread cbosdonnat
Caolán McNamara wrote: > > On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: >> I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick >> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 >> to 3.4.2. > > Forgot all a

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-11 Thread Caolán McNamara
On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: > Hi all, > > I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 > to 3.4.2. Forgot all about that one. Don't yo

[Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-11 Thread Cedric Bosdonnat
Hi all, I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 to 3.4.2. Can someone review, sign-off and cherry-pick it? Thanks, -- Cédric Bosdonnat LibreOffice hacker http:/