On Thu, 2011-03-03 at 21:43 -0500, Kohei Yoshida wrote:
> Now, can someone please sign off of this, or is this change still too
> risky or questionable? :-)
Are we absolutely clear that this is too risky to be signed off for
3.3.2, or is this being overlooked?
Kohei
--
Kohei Yoshida, LibreOffi
On Thu, 2011-03-03 at 09:42 -0500, Kevin Hunter wrote:
So, the reason for the negative value is in the following line
> 484: sal_Int32 nIntervalCount = static_cast( fSub /
> m_rIncrement.Distance );
where fSub / m_rIncrement.Distance value (which is double divided by
double) is still positive *
On Thu, 2011-03-03 at 10:32 -0500, Kohei Yoshida wrote:
> One thing to note when reading LibO's code (and also OOo's) is that, a
> lot of code that are written by the Oracle folks avoid using unsigned
> integers in favor of signed ones even though unsigned ones would make
> more sense logically. T
On Thu, 2011-03-03 at 09:42 -0500, Kevin Hunter wrote:
> At first glance, getTickDepth() and getMaxTickCount() read to me as
> requests for non-negative values (from an English/math sense).
> However,
> I note that the return values are sal_Int32 instead of sal_uInt32.
One thing to note when re
At 4:22am -0500 Thu, 03 Mar 2011, Tor Lillqvist wrote:
for a cherry-pick candidate to libreoffice-3-3. It's a very simple&
safe fix, and fixes a crasher as reported in
But do you know how those values can end up being negative in the
first place, is that a symptom of something being horribly wr
On Thu, 2011-03-03 at 02:22 -0700, Tor Lillqvist wrote:
> > for a cherry-pick candidate to libreoffice-3-3. It's a very simple &
> > safe fix, and fixes a crasher as reported in
>
> But do you know how those values can end up being negative in the
> first place, is that a symptom of something bei
> for a cherry-pick candidate to libreoffice-3-3. It's a very simple &
> safe fix, and fixes a crasher as reported in
But do you know how those values can end up being negative in the first place,
is that a symptom of something being horribly wrong otherwise, and this patch
now then just plaste
Please review this commit
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=1e3b1a7a8c939a0ae08a14d5efdd65b17355dae9
for a cherry-pick candidate to libreoffice-3-3. It's a very simple &
safe fix, and fixes a crasher as reported in
https://bugs.freedesktop.org/show_bug.cgi?id=34350
Thanks
