[Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

2012-01-31 Thread Markus Mohrhard
Hey, this patch fixes a crash in 3-5. We delete the thread while it is still running. The patch just adds a Thread::join call to wait till the thread is correctly termintated before the thread is deleted. I think the patch is safe and should be applied to 3-5 and maybe even to 3-5-0. Regards,

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

2012-01-31 Thread Kohei Yoshida
On Tue, 2012-01-31 at 21:50 +0100, Markus Mohrhard wrote: Hey, this patch fixes a crash in 3-5. We delete the thread while it is still running. The patch just adds a Thread::join call to wait till the thread is correctly termintated before the thread is deleted. I think the patch is safe

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

2012-01-31 Thread Peter Jentsch
Hi Markus, thanks for spotting and fixing this. I pushed a fix for that to master last december and hoped for it to magically move to the 3-5 branch, which it didn't. Sigh.

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

2012-01-31 Thread Markus Mohrhard
Hi Peter, thanks for spotting and fixing this. I pushed a fix for that to master last december and hoped for it to magically move to the 3-5 branch, which it didn't. Sigh.

Re: [Libreoffice] [REVIEW] fix for fd#45401, crash in our inbuild xslt transformation filters

2012-01-31 Thread Eike Rathke
Hi, On Tuesday, 2012-01-31 22:38:56 +0100, Markus Mohrhard wrote: I think we now only need one more review to get this patch into 3-5-0. Pushed to 3-5-0 with my sign-off http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0id=8558246af43c01bc437c4884e5ff144d714dc848 Eike