[Libreoffice] [REVIEW] fix for fdo#37584

2011-06-08 Thread Cedric Bosdonnat
Hi all, Could someone review the attached patch, sign it off and push it to the 3.4 branch? John, I CC'ed you particularly to point out a bug in one of your previous commits... that made me search hours long the source of the bug. Please take care of these kind of things for your next patches.

Re: [Libreoffice] [REVIEW] fix for fdo#37584

2011-06-08 Thread John LeMoyne Castle
Cedric, I apologize for the time cost for you to dig this up. I do remember removing a string copy (or maybe two?). I should have clearly seen the need for a full copy after digging into the counting process and seeing the changes it made to the string in order to count excluding hidden or

Re: [Libreoffice] [REVIEW] fix for fdo#37584

2011-06-08 Thread John LeMoyne Castle
Test with LibreOffice 3.3.2 OOO330m19 (Build:202) tag libreoffice-3.3.2 shows that Changes-Record does not produce redlining there either I feel sick jlc=={*-P} -- View this message in context: http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37584-tp3038258p3039788.html Sent from