[Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-15 Thread Júlio Hoffimann
Hi devs, How hard is to rename all the C++ namespaces to most comprehensive and consistent names with the project? It would help us, external contributors, to understand the code and make substantial changes. I'm trying to get familiar, but there is a complex mix of namespaces from StarOffice/Ope

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-16 Thread Júlio Hoffimann
Hi, Before i forget... If you think this is not a so bad idea, just let me know. Would be a pleasure to prepare the files for you. :-) I need just a map with the new names and a file name (#include "changingName.hpp"). Best regards, Júlio. ___ LibreOff

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Caolán McNamara
On Fri, 2011-04-15 at 18:27 -0300, Júlio Hoffimann wrote: > Hi devs, > > > How hard is to rename all the C++ namespaces to most comprehensive and > consistent names with the project? Well, one fairly common pattern is sprinkled around of... namespace css = com::sun::star; namespace cssu = com::

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Júlio Hoffimann
Hi Caolán, I was thinking in the LibreOffice identity too. Renaming the namespaces created by sun and other previous versions would help us to understand the code, but also would make we feel in a new software, a real community software. This is not so hard to do because C++ is powerful as we know

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Lubos Lunak
On Tuesday 19 of April 2011, Júlio Hoffimann wrote: > Hi Caolán, > > I was thinking in the LibreOffice identity too. Renaming the namespaces > created by sun and other previous versions would help us to understand the > code, but also would make we feel in a new software, a real community > softwar

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Júlio Hoffimann
> > If this is about those com::sun::start::whatever namespaces specifically, > then I think it's part of the UNO interfaces and as such it needs to be > kept > for backwards compatibility for extensions. I think this is a wrong vision, this is why the code is like it is. Maintain backwards comp

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Joop Kiefte
As this is an API issue, maybe it's an idea to create a new, cleaner, namespace scheme first and deprecate the old way but not disable it yet... Maybe you could think of finally removing the old namespaces completely in LibreOffice 4 or something like that (a new mayor version is a good moment to b

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Júlio Hoffimann
Hi Joop, The first message in this conversation does exactly what you said. The change would be made gradually, the build would not break, namespaces are just aliases. When the last old name is removed, the header is not useful and should be removed by regexp again. Regards, Júlio. __

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Tor Lillqvist
> The change would be made gradually, the build would not break, namespaces are > just aliases. So one would code as if stuff was in various libreoffice::foo namespaces, but in all compiler and linker error messages, in debugger backtraces in bug reports etc, one would still see the actual com::

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Júlio Hoffimann
Hi Tor, This is a real problem, but i think it's necessary if we need to grow faster. Every migration or any big change is painful, i'm here now trying to remove Blitz++ dependency in a particular project to use the Boost libraries. Painful today, amazing tomorrow. :-) Regards, Júlio. 2011/4/19

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Bjoern Michaelsen
Hi Caolán, On Tue, 19 Apr 2011 09:55:59 +0100 Caolán McNamara wrote: > namespace libreoffice = com::sun::star;, or something of that nature, > in some header probably isn't the worst idea in the world. Though it > does generate a lot of churn to go around changing anything, and the > other langu

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Júlio Hoffimann
The gradual migration is the only way i see to change thousand of names. Even with regular expressions, the task is not easy to do. About the half percentage of Easy Hacks, no matters. We are doing it (in parallel), that is important. Tor was the first to say something really problematic about the

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Christian Lohmaier
Hi *, 2011/4/20 Júlio Hoffimann : > The gradual migration is the only way i see to change thousand of names. > Even with regular expressions, the task is not easy to do. Well, easy or hard to do doesn't matter, when the benefit is not so clear to other people. I for example do not see anything th

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Cor Nouws
Júlio Hoffimann wrote (19-04-11 18:12) Btw, LibreOffice was born ~one year ago, "backwards" doesn't make so much sense. The aim was and still is to be the continuation of. So let's be careful with out assets, the users and companies that build on us. Cor -- - http://nl.libreoffice.org -

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Bjoern Michaelsen
Hi Júlio, On Tue, 19 Apr 2011 20:49:57 -0300 Júlio Hoffimann wrote: > The gradual migration is the only way i see to change thousand of > names. Even with regular expressions, the task is not easy to do. There are feature branches. Absolutely no need to do this on master. > Again, painful toda

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-20 Thread Júlio Hoffimann
Thank you all for the replies, was a great discussion. :-) I won't persist in this idea, even discording in the actual situation. Let's go back for coding... $ cd libo/wizards/com/sun/star/wizards :-( Regards, Júlio. ___ LibreOffice mailing list LibreO