Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-10 Thread julien
Le 08/11/2010 21:08, julien a écrit : Le 08/11/2010 14:33, Caolán McNamara a écrit : On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: the if() can only be true if that value is not 0 so here you have a false positive. Julien, could you

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-08 Thread julien
Le 08/11/2010 14:33, Caolán McNamara a écrit : On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: the if() can only be true if that value is not 0 so here you have a false positive. Julien, could you log a bug against cp

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-08 Thread Caolán McNamara
On Mon, 2010-11-08 at 10:57 -0500, Norbert Thiebaud wrote: > On 11/8/10, Noel Power wrote: > > returns true if it was able to successfully extract the value from the > > 'theAny' into 'something' so there is a possibility of a runtime divide > > by zero ( and probably should be defensively coded a

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-08 Thread Norbert Thiebaud
On 11/8/10, Noel Power wrote: > On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: >> On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > >> Ahh, welcome to the wonderful world of operator overload. >> >>= is not a right shift but instead, here, nMapWith get populated with >> >> the property

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-08 Thread Caolán McNamara
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: > On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > >the if() can only be true if that value is not 0 so here you have a false > >positive. Julien, could you log a bug against cppcheck itself with this example, including the operator overl

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-08 Thread Noel Power
On Sun, 2010-11-07 at 12:33 -0600, Norbert Thiebaud wrote: > On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > Ahh, welcome to the wonderful world of operator overload. > >>= is not a right shift but instead, here, nMapWith get populated with the > >>property (uno) value, converted to a int32. >

Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-07 Thread Norbert Thiebaud
On Sun, Nov 7, 2010 at 7:00 AM, julien wrote: > Hello, > > I'm currently running a cppcheck on the clone directory (i had try to launch > cppcheck on the build/libreoffice... but it seemed it freezed). > I've seen this issue : > [./extensions/sdext/source/minimizer/unodialog.cxx:359]: (error) Divi

[Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx

2010-11-07 Thread julien
Hello, I'm currently running a cppcheck on the clone directory (i had try to launch cppcheck on the build/libreoffice... but it seemed it freezed). I've seen this issue : [./extensions/sdext/source/minimizer/unodialog.cxx:359]: (error) Division by zero I opened the file and saw this : sal_In