Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Stephan Bergmann
On 12/13/2011 07:56 PM, Lubos Lunak wrote: On Monday 12 of December 2011, Stephan Bergmann wrote: Shrug. Neither nor something printf-like is particularly sexy, IMO. And trading for +, when it requires you to wrap non-string arguments in rtl::OUString::valueOf, doesn't look too exciting

Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Stephan Bergmann
On 12/13/2011 10:21 PM, Michael Meeks wrote: On Mon, 2011-12-12 at 22:59 +0100, Stephan Bergmann wrote: To be honest, I don't think the stated benefits (a different syntax) are worth a switch. Well; the syntax that makes translation possible is a nice thing; but Again, translation

Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Lubos Lunak
On Thursday 15 of December 2011, Stephan Bergmann wrote: On 12/13/2011 07:56 PM, Lubos Lunak wrote: But it might the moment you realize you're trading away things like SAL_INFO( foo, 1 2 ) or SAL_INFO( foo, bar baz ). Trading away the former, having to parenthesize (1 2) instead,

Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Stephan Bergmann
On 12/15/2011 02:57 PM, Lubos Lunak wrote: On Thursday 15 of December 2011, Stephan Bergmann wrote: On 12/13/2011 07:56 PM, Lubos Lunak wrote: But it might the moment you realize you're trading away things like SAL_INFO( foo, 1 2 ) or SAL_INFO( foo, bar baz ). Trading away the

Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Lubos Lunak
On Thursday 15 of December 2011, Stephan Bergmann wrote: On 12/15/2011 02:57 PM, Lubos Lunak wrote: The bar baz, which, at first glance, is nonsense. Code is not only written, it is also read, and many more times. Still don't get what you mean. You mean, bar baz should be forbidden by

Re: [Libreoffice] Simpler logging using a string format function

2011-12-13 Thread Lubos Lunak
On Monday 12 of December 2011, Stephan Bergmann wrote: On 12/12/2011 04:30 PM, Lubos Lunak wrote: I'd like to propose changes to the SAL_INFO etc. family of the new logging functions that would replace the somewhat strange usage SAL_INFO(foo, string s of length n) with

Re: [Libreoffice] Simpler logging using a string format function

2011-12-13 Thread Lubos Lunak
On Monday 12 of December 2011, Michael Meeks wrote: On Mon, 2011-12-12 at 16:30 +0100, Lubos Lunak wrote: The format-based usage uses a printf-like function that, unlike printf, is typesafe and extensible. If people would be interested, the function itself could be made public API (after

Re: [Libreoffice] Simpler logging using a string format function

2011-12-13 Thread Michael Meeks
On Mon, 2011-12-12 at 22:59 +0100, Stephan Bergmann wrote: To be honest, I don't think the stated benefits (a different syntax) are worth a switch. Well; the syntax that makes translation possible is a nice thing; but to me - having something efficient - that does not turn into some

[Libreoffice] Simpler logging using a string format function

2011-12-12 Thread Lubos Lunak
Hello, I'd like to propose changes to the SAL_INFO etc. family of the new logging functions that would replace the somewhat strange usage SAL_INFO(foo, string s of length n) with SAL_INFO(foo, string %1 of length %2, s, n ) while still leaving the possibility to do SAL_INFO(foo,

Re: [Libreoffice] Simpler logging using a string format function

2011-12-12 Thread Lubos Lunak
On Monday 12 of December 2011, Lubos Lunak wrote: Attached source code has a testing implementation of the format function and a simple logging macro. In case somebody actually tries to build it :), the easiest way seems to be: g++ -Wall -O2 -save-temps a.cxx -DUNX -DLINUX

Re: [Libreoffice] Simpler logging using a string format function

2011-12-12 Thread Michael Meeks
Hi Lubos, On Mon, 2011-12-12 at 16:30 +0100, Lubos Lunak wrote: I'd like to propose changes to the SAL_INFO etc. family of the new logging functions that would replace the somewhat strange usage SAL_INFO(foo, string s of length n) with SAL_INFO(foo, string %1 of length %2, s,

Re: [Libreoffice] Simpler logging using a string format function

2011-12-12 Thread Stephan Bergmann
On 12/12/2011 04:30 PM, Lubos Lunak wrote: I'd like to propose changes to the SAL_INFO etc. family of the new logging functions that would replace the somewhat strange usage SAL_INFO(foo, string s of length n) with SAL_INFO(foo, string %1 of length %2, s, n ) while still leaving