Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-15 Thread Kohei Yoshida
Hi Christoph, On Sat, 2010-11-13 at 01:15 +0100, Christoph Noack wrote: A first look ... did that help anyhow? Yes, that helped a lot! :-) Thanks a lot for the very detailed analysis on this. If I read your analysis correctly, we can probably safely remove this without upsetting too many

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-14 Thread Sebastian Spaeth
On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks michael.me...@novell.com wrote: On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. +1 for removing that beast anyway. Sebastian

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-14 Thread Kálmán „KAMI” Szalai
Title: Szalai Kálmán It is easy way to inset links KAMI 2010-11-14 17:35 keltezéssel, Sebastian Spaeth írta: On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks michael.me...@novell.com wrote: On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-14 Thread Cor Nouws
Hi Kami, Kálmán „KAMI” Szalai wrote (14-11-10 18:11) It is easy way to inset links Yes indeed, I realised that is allows working with hyperlinks without being kept in a modal dialogue :-) But to be honest, close to all hyperlinks I create is just by typing and autoformatting the URL.

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-14 Thread Camille Moulin
On 14/11/2010 18:11, Kálmán „KAMI” Szalai wrote: 2010-11-14 17:35 keltezéssel, Sebastian Spaeth írta: On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks michael.me...@novell.com wrote: On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Kohei Yoshida
On Fri, 2010-11-12 at 12:26 +, Michael Meeks wrote: Hi there, On Fri, 2010-11-05 at 09:28 -0400, Kohei Yoshida wrote: On Fri, 2010-11-05 at 00:51 -0400, Kohei Yoshida wrote: Does anyone know if SvxHyperlinkDlg* is still used? Did a full git grep SvxHyperlinkDlg on all repos

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Kohei Yoshida
On Fri, 2010-11-12 at 15:32 +, Michael Meeks wrote: On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never instantiated. It is registered by the applications on startup, but that's the only place I see it being used.

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Kohei Yoshida
On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Did you do the unwinding to satisfy yourself that whatever mapping between SID_HYPERLINK_INSERT and this dialog is never exploited ? Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. Go to

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Kohei Yoshida
On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: On Fri, 2010-11-12 at 15:32 +, Michael Meeks wrote: On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never instantiated. It is registered by the applications on

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Michael Meeks
On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. ;- Go to View - Toolbars - Hyperlink Bar to enable a new toolbar to allow some sort of quick insertion of URL buttons. That toolbar

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Cor Nouws
Michael Meeks wrote (12-11-10 17:46) Riight - on the other hand, using that toolbar I'm somewhat appalled by it. Christoph - any chance of some quick review of that hyperlink bar ? it looks to me as if it is some legacy cruft from the days when StarOffice was an HTML editor.

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Christoph Noack
Hi Michael, hi Kohei, all! Am Freitag, den 12.11.2010, 16:46 + schrieb Michael Meeks: On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. ;- Yep, it also looks a bit dated ... To me,

Re: [Libreoffice] SvxHyperlinkDlg still used?

2010-11-12 Thread Andrew C. E. Dent
Just to add my 'Aye' to Michaels comments (as a humble user).A quick Google reveals that predominately the full insert hyperlink function is referenced in online guides.I think this is a fair reflection of the expected UX and the toolbar is redundant. Cheers,Andrew

[Libreoffice] SvxHyperlinkDlg still used?

2010-11-04 Thread Kohei Yoshida
Hi there, Does anyone know if SvxHyperlinkDlg* is still used? Just by looking at the code, that dialog doesn't appear to be used anymore. It gets registered in Calc and Writer (haven't checked other apps), but they don't appear to be used anywhere in those apps. If it's no longer used, that