Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-28 Thread Lior Kaplan
On Tue, Dec 27, 2011 at 4:08 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: Hi Lior, *, On Tue, Dec 27, 2011 at 2:51 PM, Lior Kaplan kaplanl...@gmail.com wrote: Hi, I'm attaching a patch (already done for master/3.5.0) for fdo#44178 in the 3.4 branch. Do we

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-28 Thread Christian Lohmaier
Hi Lior, *, On Wed, Dec 28, 2011 at 11:10 PM, Lior Kaplan kaplanl...@gmail.com wrote: On Tue, Dec 27, 2011 at 4:08 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: On Tue, Dec 27, 2011 at 2:51 PM, Lior Kaplan kaplanl...@gmail.com wrote: I'm attaching a patch (already done

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-28 Thread Lior Kaplan
On Tue, Dec 27, 2011 at 3:51 PM, Lior Kaplan kaplanl...@gmail.com wrote: Hi, I'm attaching a patch (already done for master/3.5.0) for fdo#44178 in the 3.4 branch. Do we want it in the 3.4.5 branch or should it be done for 3.4 branch and taken for 3.4.6 (if release at all) ? Pushed the

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-27 Thread Florian Effenberger
Hi, Christian Lohmaier wrote on 2011-12-27 15:13: Yes, but setting them up is easy. Changing them to point to a better page is easy. but changing URLs in a released product is not (is impossible). (and to be clear for everyone: hub.libreoffice.org will be a redirection to the extensions site,

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-27 Thread Florian Effenberger
These do not exist yet, so we have to set them up Christian Lohmaier wrote on 2011-12-27 15:08: Please don't use platform-limited URLs. Please make ithttp://hub.libreoffice.org/extensions?type=dictionaries orhttp://hub.libreoffice.org/dictionaries instead. -- Florian Effenberger

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-27 Thread Rainer Bielefeld
Lior Kaplan schrieb: I'm attaching a patch (already done for master/3.5.0) for fdo#44178 in the 3.4 branch. Hi, If I understand you right the patch replaces http://extensions.libreoffice.org/dictionary/; by http://extensions.libreoffice.org/dictionaries/; That would be correct human

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-27 Thread Christian Lohmaier
Hi *, On Tue, Dec 27, 2011 at 3:09 PM, Florian Effenberger flo...@documentfoundation.org wrote: These do not exist yet, so we have to set them up Yes, but setting them up is easy. Changing them to point to a better page is easy. but changing URLs in a released product is not (is impossible).

Re: [Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-27 Thread Christian Lohmaier
Hi Lior, *, On Tue, Dec 27, 2011 at 2:51 PM, Lior Kaplan kaplanl...@gmail.com wrote: Hi, I'm attaching a patch (already done for master/3.5.0) for fdo#44178 in the 3.4 branch. Do we want it in the 3.4.5 branch or should it be done for 3.4 branch and taken for 3.4.6 (if release at all) ?

[Libreoffice] cherry pick to fix fdo#44178 - Wrong URL for Dictionary Download

2011-12-27 Thread Lior Kaplan
Hi, I'm attaching a patch (already done for master/3.5.0) for fdo#44178 in the 3.4 branch. Do we want it in the 3.4.5 branch or should it be done for 3.4 branch and taken for 3.4.6 (if release at all) ? Kaplan From 51027876681f348a6aea6b8efb1e739f7b2835dd Mon Sep 17 00:00:00 2001 From: Lior