[Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-07 Thread Julien Nabet
Hello, Here are 2 examples of "Same expression on both sides of '!='" I found : [sc/source/core/tool/rangeutl.cxx:507] -> [sc/source/core/tool/rangeutl.cxx:507]: (style) Same expression on both sides of '!=' [sc/source/core/tool/rangeutl.cxx:534] -> [sc/source/core/tool/rangeutl.cxx:534]: (sty

[Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-16 Thread Julien Nabet
Hello, Here a line I get in cppcheck (updated today) : [source/core/layout/flycnt.cxx:1194] -> [source/core/layout/flycnt.cxx:1194]: (style) Same expression on both sides of '<'. I checked the file git history, it's there since the beginning. while ( pDownFrm && ( ( nDown.nMai

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-07 Thread Rafael Dominguez
Well it does look weird, but its the same object getting compared on both sides, so i think theres a problem there, but better wait for someone with more experience in the code say something about it. On Sat, May 7, 2011 at 9:31 AM, Julien Nabet wrote: > Hello, > > Here are 2 examples of "Same e

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-07 Thread Joop Kiefte
Maybe worth it to look those places up in the version control history... 2011/5/7 Rafael Dominguez : > Well it does look weird, but its the same object getting compared on both > sides, so i think theres a problem there, but better wait for someone with > more experience in the code say something

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-07 Thread Regina Henschel
Hi Julian, Julien Nabet schrieb: Hello, Here are 2 examples of "Same expression on both sides of '!='" I found : [sc/source/core/tool/rangeutl.cxx:507] -> [sc/source/core/tool/rangeutl.cxx:507]: (style) Same expression on both sides of '!=' [sc/source/core/tool/rangeutl.cxx:534] -> [sc/source/c

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-08 Thread Julien Nabet
Le 07/05/2011 16:01, Julien Nabet a écrit : Hello, Here are 2 examples of "Same expression on both sides of '!='" I found : [sc/source/core/tool/rangeutl.cxx:507] -> [sc/source/core/tool/rangeutl.cxx:507]: (style) Same expression on both sides of '!=' [sc/source/core/tool/rangeutl.cxx:534] ->

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-13 Thread Korrawit Pruegsanusak
Hello all, Joop Kiefte wrote: > Maybe worth it to look those places up in the version control history... I've annotated this file and found the added version since Sep 2010. Let's take a look from this link: http://opengrok.libreoffice.org/diff/calc/sc/source/core/tool/rangeutl.cxx?r2=%2Fcalc%2Fs

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-13 Thread Kohei Yoshida
On Fri, 2011-05-13 at 23:54 +0700, Korrawit Pruegsanusak wrote: > Hello all, > > Joop Kiefte wrote: > > Maybe worth it to look those places up in the version control history... > > I've annotated this file and found the added version since Sep 2010. > Let's take a look from this link: > http://op

Re: [Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-17 Thread Michael Meeks
Hi Julien, On Mon, 2011-05-16 at 19:08 +0200, Julien Nabet wrote: > Here a line I get in cppcheck (updated today) : > [source/core/layout/flycnt.cxx:1194] -> > [source/core/layout/flycnt.cxx:1194]: (style) Same expression on both > sides of '<'. What fun :-) > I checked the file git hi

Re: [Libreoffice] Cppcheck Same expression on both sides of '<'

2011-05-17 Thread Julien Nabet
Le 17/05/2011 15:04, Michael Meeks a écrit : ... nDownLst< nDownLst So - this is the guy. sal_Bool operator<( const SwDistance& rTwo ) { return nMain< rTwo.nMain || ( So - we end up with: that equating to: nDownLst.nSub&& nDownLst.nSub&& nDownLst.n