Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-17 Thread Stephan Bergmann
On Aug 11, 2011, at 12:22 PM, Lubos Lunak wrote: > On Wednesday 10 of August 2011, Stephan Bergmann wrote: >> On Aug 10, 2011, at 12:31 PM, Lubos Lunak wrote: >>> On Tuesday 09 of August 2011, Stephan Bergmann wrote: Technically, lostd::list is no longer a container, as it violates the re

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-11 Thread Lubos Lunak
On Wednesday 10 of August 2011, Stephan Bergmann wrote: > On Aug 10, 2011, at 12:31 PM, Lubos Lunak wrote: > > On Tuesday 09 of August 2011, Stephan Bergmann wrote: > >> Technically, lostd::list is no longer a container, as it violates the > >> requirement that the return type of size() is size_typ

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-10 Thread Stephan Bergmann
On Aug 10, 2011, at 12:31 PM, Lubos Lunak wrote: > On Tuesday 09 of August 2011, Stephan Bergmann wrote: >> Technically, lostd::list is no longer a container, as it violates the >> requirement that the return type of size() is size_type. (And if you >> redefine size_type as int, as you should do a

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-10 Thread Lubos Lunak
On Tuesday 09 of August 2011, Stephan Bergmann wrote: > On Aug 9, 2011, at 5:15 PM, Lubos Lunak wrote: > > namespace lostd // or just no namespace at all, any other 'list' class is > > unlikely > > { > > template< ... > > > class list : public ::std::list< ... > > > { > > ... > > int size() const {

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-09 Thread Stephan Bergmann
On Aug 9, 2011, at 5:15 PM, Lubos Lunak wrote: > On Tuesday 09 of August 2011, Stephan Bergmann wrote: >> On Aug 9, 2011, at 3:02 PM, Lubos Lunak wrote: >>> Too bad usage of STL drags in these problems, but that's not a problem >>> that couldn't be solved. >> >> How? > > namespace lostd // or jus

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-09 Thread Lubos Lunak
On Tuesday 09 of August 2011, Stephan Bergmann wrote: > On Aug 9, 2011, at 3:02 PM, Lubos Lunak wrote: > > Too bad usage of STL drags in these problems, but that's not a problem > > that couldn't be solved. > > How? namespace lostd // or just no namespace at all, any other 'list' class is unlikel

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-09 Thread Lubos Lunak
On Tuesday 09 of August 2011, Stephan Bergmann wrote: > On Aug 6, 2011, at 3:32 PM, Maciej Rumianowski wrote: > >> @@ -1325,7 +1288,7 @@ String > >> SvxNumberFormatShell::GetComment4Entry(short nEntry) if(nEntry < 0) > >> return String(); > >> > >> -if(nEntry >> +if(nEntry < (short)

[Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-09 Thread Stephan Bergmann
On Aug 6, 2011, at 3:32 PM, Maciej Rumianowski wrote: > I was working on SvULongs in libs-core and I decided to split my work in > several Patches. > > With this patch comes some questions: >> @@ -228,9 +229,9 @@ private: >> String aValStr; >> double nValNum; >> sal_Bool bUndoAddList;