Re: [PATCH] EasyHack Bug 46610

2012-04-04 Thread Daniel Bankston [danthedev]
On 04/04/2012 08:51 AM, Lubos Lunak wrote: On Wednesday 04 of April 2012, Daniel Bankston wrote: Lubos Lunak wrote: It seems to me you are correct. I've added !IsEmpty() check to the if(), which should do what the original author wanted. I'm still a little worried about that aClip object that

Re: [PATCH] EasyHack Bug 46610

2012-04-04 Thread Lubos Lunak
On Wednesday 04 of April 2012, Daniel Bankston wrote: > Lubos Lunak wrote: > > It seems to me you are correct. I've added !IsEmpty() check to the if(), > > which should do what the original author wanted. > > I'm still a little worried about that aClip object that is being > intersected with aRegio

Re: [PATCH] EasyHack Bug 46610

2012-04-03 Thread Daniel Bankston
y considered that before when you replied and pushed the patch. Thanks. -- View this message in context: http://nabble.documentfoundation.org/PATCH-EasyHack-Bug-46610-tp3879786p3883107.html Sent from the Dev mailing list archive at Nabble.com. ___

[PUSHED]Re: [PATCH] EasyHack Bug 46610

2012-04-03 Thread Lubos Lunak
On Tuesday 03 of April 2012, Lubos Lunak wrote: > On Tuesday 03 of April 2012, Daniel Bankston [danthedev] wrote: > > Hello, everyone, > > > > I have attached my patches for EasyHack Bug 46610. > > Looks good to me, I only removed the return's at the end of function, as > they are superfluous in v

Re: [PATCH] EasyHack Bug 46610

2012-04-03 Thread Lubos Lunak
On Tuesday 03 of April 2012, Daniel Bankston [danthedev] wrote: > Hello, everyone, > > I have attached my patches for EasyHack Bug 46610. Looks good to me, I only removed the return's at the end of function, as they are superfluous in void functions. Pushed, thank you. > I identified that the r

[PATCH] EasyHack Bug 46610

2012-04-02 Thread Daniel Bankston [danthedev]
Hello, everyone, I have attached my patches for EasyHack Bug 46610. Here is a little more information on what I did and found out: For both versions of the Region class's Union, Intersect, Exclude, and XOr, I changed the return types from sal_Bool to void. Then I searched vcl for all callers