Re: [PATCH] Missing sub-menu arrows with 3.5.x and GTK 2.15

2012-03-20 Thread Michael Meeks
Hi David, On Mon, 2012-03-19 at 17:48 -0400, David Bolen wrote: Even if the implementation stinks using it was easy enough :-) :-) (a) Direct use of gtk_widget_class_find_style_property in lieu of the version check. This looks really nice. (a) is a more conservative

[PATCH] Missing sub-menu arrows with 3.5.x and GTK 2.15

2012-03-19 Thread Michael Meeks
Hi David, On Sun, 2012-03-18 at 22:08 -0400, David Bolen wrote: Using LO 3.5.x on a system with GTK 2.15.0 loses all the sub-menu icons, because there is no menu item arrow-scaling property until then, so the code introduced in commit 948c14ee appears to scale the arrows to 0%. Ah

Re: [PATCH] Missing sub-menu arrows with 3.5.x and GTK 2.15

2012-03-19 Thread David Bolen
On Mon, Mar 19, 2012 at 5:59 AM, Michael Meeks michael.me...@suse.com wrote:        Sounds very sensible. Just one minor complaint: - I loathe the implementation of gtk_check_version - its impl. is as clear as mud, it returns an non-translated string not a boolean etc. etc. ;-)        Any

[PATCH] Missing sub-menu arrows with 3.5.x and GTK 2.15

2012-03-18 Thread David Bolen
Using LO 3.5.x on a system with GTK 2.15.0 loses all the sub-menu icons, because there is no menu item arrow-scaling property until then, so the code introduced in commit 948c14ee appears to scale the arrows to 0%. I realize that's a pretty old GTK version, but I ran into this on my Ubuntu 8.04