Re: [PATCH] More STL'ification (7)

2012-08-14 Thread Noel Grandin
On 2012-08-13 22:53, Michael Stahl wrote: On 13/08/12 15:37, Noel Grandin wrote: Hi These patches convert various places from using tools/list.hxx to using normal STL containers. thanks, pushed to master. Thanks. At this point, it seems like all of the STL'ification work is done, unless

Re: [PATCH] More STL'ification (7)

2012-08-14 Thread David Tardon
Hi Noel, On Tue, Aug 14, 2012 at 08:57:30AM +0200, Noel Grandin wrote: On 2012-08-13 22:53, Michael Stahl wrote: On 13/08/12 15:37, Noel Grandin wrote: Hi These patches convert various places from using tools/list.hxx to using normal STL containers. thanks, pushed to master.

Re: [PATCH] More STL'ification (7)

2012-08-14 Thread Noel Grandin
On 2012-08-14 09:23, David Tardon wrote: There is still List (tools/inc/tools/list.hxx) and Container (tools/inc/tools/contnr.hxx :-) There is only one usage of tools/list.hxx remaining, after which it could be moved to binfilter. Although Michael might have already done that, in which case

Re: [PATCH] More STL'ification (7)

2012-08-14 Thread David Tardon
Hi, On Tue, Aug 14, 2012 at 09:46:11AM +0200, Noel Grandin wrote: On 2012-08-14 09:23, David Tardon wrote: There is still List (tools/inc/tools/list.hxx) and Container (tools/inc/tools/contnr.hxx :-) There is only one usage of tools/list.hxx remaining, after which it could be moved to

Re: [PATCH] More STL'ification (7)

2012-08-14 Thread Noel Grandin
On 2012-08-14 10:09, David Tardon wrote: Anything else that you're aware of? Well, there is still Container :-) It is used at ~10 places in svx and possibly elsewhere. Thanks, I'll go work on those. Disclaimer: http://www.peralex.com/disclaimer.html

Re: [PATCH] More STL'ification (7)

2012-08-14 Thread Michael Meeks
On Tue, 2012-08-14 at 08:57 +0200, Noel Grandin wrote: At this point, it seems like all of the STL'ification work is done, unless there is something more you are aware of? Wow - fantastic work ! :-) this is really encouraging, thank you to all involved ! Naturally removing

Re: [PATCH] More STL'ification (7)

2012-08-13 Thread Michael Stahl
On 13/08/12 15:37, Noel Grandin wrote: Hi These patches convert various places from using tools/list.hxx to using normal STL containers. thanks, pushed to master. patch #2 had some problems; nIdx becomes n here: (ridiculous indentation by original code author) -