Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-13 Thread Eike Rathke
Hi Cor, On Wednesday, 2012-06-13 14:32:31 +0200, Cor Nouws wrote: > Imagine a range where I want to see al the "Cor" entries. > With the old autofilter, is is sufficient to > (start it with Alt-D, F, Enter) > Launch it with ALt-Down > Type "C" (if needed "Co"), Enter and you're done. > > With th

Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-13 Thread Cor Nouws
Hi Eike, Eike Rathke wrote (13-06-12 13:52) I fail to see why you would like to use the old dialog again. The new one is much prettier and offers more capabilities. No doubt that the new one is much prettier and offers more functions :-) However, I expect an significant part of the use is a s

Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-13 Thread Eike Rathke
Hi Cor, On Wednesday, 2012-06-13 08:20:10 +0200, Cor Nouws wrote: > >That's the old AutoFilter button dialog, now obsoleted by Kohei's new > >dialog implemented in LaunchAutoFilterMenu(). In fact > >LaunchDataSelectMenu() now is only called with bDataSelect=true so the > >entire !bDataSelect code

Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-12 Thread Cor Nouws
Hi, Eike Rathke wrote (13-06-12 00:56) That's the old AutoFilter button dialog, now obsoleted by Kohei's new dialog implemented in LaunchAutoFilterMenu(). In fact LaunchDataSelectMenu() now is only called with bDataSelect=true so the entire !bDataSelect code branch and the parameter can be remo

Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-12 Thread Eike Rathke
Hi, On Monday, 2012-06-11 08:18:44 +0200, Markus Mohrhard wrote: > > As written in the previous mail, apparently, SCSTR_ALLFILTER is not used. > > Therefore I removed SCSTR_ALLFILTER from sc/source/ui/view/gridwin.cxx, > > where it is passed to a pFilterBox object, but has no effect. > > > > To m

Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-11 Thread Cor Nouws
Hi Markus, Markus Mohrhard wrote (11-06-12 08:18) I'm sorry but your analysis is not correct. The string is used there to fill the dialog with elements Yes, that is what the old code suggests, but I removed SCSTR_ALLFILTER and I see no difference in appearance or behaviour of the filter nor

Re: [PATCH] Remove unused argument from gridwin.cxx

2012-06-10 Thread Markus Mohrhard
Hey Cor, 2012/6/10 Cor Nouws : > Hi, > > As written in the previous mail, apparently, SCSTR_ALLFILTER is not used. > Therefore I removed SCSTR_ALLFILTER from sc/source/ui/view/gridwin.cxx, > where it is passed to a pFilterBox object, but has no effect. > > To me it looks that SCSTR_ALLFILTER  isn'

[PATCH] Remove unused argument from gridwin.cxx

2012-06-10 Thread Cor Nouws
Hi, As written in the previous mail, apparently, SCSTR_ALLFILTER is not used. Therefore I removed SCSTR_ALLFILTER from sc/source/ui/view/gridwin.cxx, where it is passed to a pFilterBox object, but has no effect. To me it looks that SCSTR_ALLFILTER isn't used anywhere. opengrok shows it in the